From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id wUGcNKyymWCaKwAAWB0awg (envelope-from ) for ; Mon, 10 May 2021 18:24:44 -0400 Received: by simark.ca (Postfix, from userid 112) id C8AB01F11C; Mon, 10 May 2021 18:24:44 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2E57B1E783 for ; Mon, 10 May 2021 18:24:44 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C3EB83858039; Mon, 10 May 2021 22:24:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C3EB83858039 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1620685483; bh=TuJElZNUhioMKVx2auvtHlJcgRoNtypezQfEdzDl6z8=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=vzmnDwDpp3Z5BcS3XGqPcypVgYibcoFt3wGmlj5pmtwmj54WjkiC2N3pcrkSdNvFX 8Fg+6wBN1wlUhQorjNaTK+jcL563qOgvB82Z5/rJzHwfRQmab77sj4sD8mKQtPBDIc b8B9s/dhQNRnVjPqrtuqKWBu8s/dgvSlVCZIgZWc= Received: from lndn.lancelotsix.com (lndn.lancelotsix.com [51.195.220.111]) by sourceware.org (Postfix) with ESMTPS id 4CDFC3858039 for ; Mon, 10 May 2021 22:24:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 4CDFC3858039 Received: from Plymouth (unknown [IPv6:2a02:390:9086:0:d8a0:6b4d:8ab:1b42]) by lndn.lancelotsix.com (Postfix) with ESMTPSA id CBE49817E9; Mon, 10 May 2021 22:24:38 +0000 (UTC) Date: Mon, 10 May 2021 23:24:33 +0100 To: Simon Marchi Subject: Re: [PATCH v4] [PR gdb/27614] gdb-add-index fails on symlinks. Message-ID: <20210510222433.alsctoniwj3jo3n3@Plymouth> References: <20210329205224.12859-1-lsix@lancelotsix.com> <2697b784-fd81-acb3-c4af-f5a65267c06f@polymtl.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2697b784-fd81-acb3-c4af-f5a65267c06f@polymtl.ca> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.11 (lndn.lancelotsix.com [0.0.0.0]); Mon, 10 May 2021 22:24:39 +0000 (UTC) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Lancelot SIX via Gdb-patches Reply-To: Lancelot SIX Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Hi, Thanks. This is pushed. Lancelot. On Sun, May 09, 2021 at 08:14:02PM -0400, Simon Marchi wrote: > On 2021-03-29 4:52 p.m., Lancelot SIX via Gdb-patches wrote: > > Since V3: > > - Do net rely on GDB's maintenance commands to resolve > > symlinks, revert to using readlink while maximizing portability. > > > > Since V2: > > - Use GDB to follow symlink instead of readlink. Unlike > > readlink, GDB is guaranteed to be available. > > > > Since V1: > > - Replace '&>/dev/null' with '>/dev/null 2>&1' > > > > -- > > > > PR 27614 shows that gdb-add-index fails to generate the index when its > > argument is a symlink. > > > > The following one liner illustrates the reported problem: > > > > $ echo 'int main(){}'|gcc -g -x c -;ln -s a.out symlink;gdb-add-index symlink > > gdb-add-index: No index was created for symlink > > gdb-add-index: [Was there no debuginfo? Was there already an index?] > > $ ls -l > > -rwxr-xr-x 1 25712 Mar 19 23:05 a.out* > > -rw------- 1 8277 Mar 19 23:05 a.out.gdb-index > > lrwxrwxrwx 1 5 Mar 19 23:05 symlink -> a.out* > > > > GDB generates the .gdb-index file with a name that matches the name of > > the actual program (a.out.gdb-index here), not the symlink that > > references it. The remaining of the script is looking for a file named > > after the provided argument (would be 'symlink.gdb-index' in our > > example). > > > > gdb/ChangeLog: > > > > PR gdb/27614 > > * contrib/gdb-add-index.sh: Fix when called with a symlink as an > > argument. > > > > gdb/testsuite/ChangeLog: > > > > PR gdb/27614 > > * gdb.dwarf2/gdb-add-index-symlink.exp: New test. > > This is ok, thanks! > > Simon -- Lancelot SIX