From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id IBRnKM9hmWD0IQAAWB0awg (envelope-from ) for ; Mon, 10 May 2021 12:39:43 -0400 Received: by simark.ca (Postfix, from userid 112) id A3A3C1F11C; Mon, 10 May 2021 12:39:43 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 83A701E813 for ; Mon, 10 May 2021 12:39:42 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4C4363854819; Mon, 10 May 2021 16:39:42 +0000 (GMT) Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by sourceware.org (Postfix) with ESMTPS id 45CE6385740D for ; Mon, 10 May 2021 16:39:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 45CE6385740D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=andrew.burgess@embecosm.com Received: by mail-wm1-x32e.google.com with SMTP id a10-20020a05600c068ab029014dcda1971aso9415108wmn.3 for ; Mon, 10 May 2021 09:39:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=h6WlKPQYMUbfNnhSYd/Rc4GkFgRHCHlCAgPrMk1sYGk=; b=BUr/TSyt5XXC1eMGb24CVvmFXifgobGi85iy58d1W1eEKjxVlq/TAZltGPVQwLmJTx +Ta8DY7wnEr1MBs9G9NyD4Xet7uF+vATRs2uFOK37TK1u9rBW0Kxtm2orOC5GmaXDAtu e+EDZUVAitcC6EQ+6uAkbsN4XPDDajXDUJasN7BtMLTagJ2oahO5pgMqc3cd5MWAmy6V JUI5DlgM4eCcFpm4bt4lWvUEuwCbJjX5MiegOT51if9J2Gs5+zNWzKSlWWsdlU1EHnR9 pJbiLx8HfypD3f2Y0GXLB5iOUSRkHfRi6d99bAIhW/9eAFjzi1itjdnNAVMrsA5EgHJg tD/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=h6WlKPQYMUbfNnhSYd/Rc4GkFgRHCHlCAgPrMk1sYGk=; b=cKXwk7tAo2Htx3AGN0xQKcgw4qzmJ8yUbLWQjj3O6i1C/Ws5qnhd2bzayW/V7bWbJD 8lIDIIQs5lboAvIbgZ/rvao4ayJkz2noGxg4FOzLhkJVFrDfvimqyRDkWT0XcvRbcZxY TVucOzEFao8zU4P0e9KHF/mCAscl2cV4qWJOzUimTikFABarDy+Vw7r1UzimRp7qVK32 gBoI4i7ze1cimlHtY7VmJyfFF99he8Mvh7yv2KvM1dlLXVgsASRZLSEFe494y7s4cn+E 1Yd8Qf4RrAIETemuqOkMpXGjKOnRkkg7jsnQ29vnF2/VQEmlhlvcVMD0h+WGr3Tx2JHO Uw5Q== X-Gm-Message-State: AOAM530+2OaYSouimmUdtHcn31k/SViUucML5w2vF0K7+cIgVcDdQBGR kIk6KntPXAAeWa9C7HaH/okwwPVJkbeg4A== X-Google-Smtp-Source: ABdhPJxcyQ+/hgTOOkaiNT4TVJvCkKdVOkd3s06CLwBehan+CcCLkUPdta1RgON8MphjsS6EmHLr0w== X-Received: by 2002:a7b:c8cb:: with SMTP id f11mr38580867wml.163.1620664779425; Mon, 10 May 2021 09:39:39 -0700 (PDT) Received: from localhost (host109-151-46-70.range109-151.btcentralplus.com. [109.151.46.70]) by smtp.gmail.com with ESMTPSA id q10sm20166762wmc.31.2021.05.10.09.39.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 May 2021 09:39:39 -0700 (PDT) Date: Mon, 10 May 2021 17:39:38 +0100 From: Andrew Burgess To: Simon Marchi Subject: Re: [PATCH] gdb/testsuite: use proc parameters in gdb.arch/amd64-osabi.exp Message-ID: <20210510163938.GR6612@embecosm.com> References: <20210510160152.1398199-1-simon.marchi@polymtl.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210510160152.1398199-1-simon.marchi@polymtl.ca> X-Operating-System: Linux/5.8.18-100.fc31.x86_64 (x86_64) X-Uptime: 17:39:26 up 7 days, 5:33, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" * Simon Marchi via Gdb-patches [2021-05-10 12:01:52 -0400]: > This test has a little oversight: the test procedure doesn't actually > use its parameters, the commands and expected patterns are hard-coded, > so we always test with i386:x86-64, instead of with the three arches. > Fix that. > > gdb/testsuite/ChangeLog: > > * gdb.arch/amd64-osabi.exp (test_osabi_none): Use the > parameters. LGTM. Thanks, Andrew > > Change-Id: Iee2c32963d09e502ae791d5df2b6c04a1f49a57a > --- > gdb/testsuite/gdb.arch/amd64-osabi.exp | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/gdb/testsuite/gdb.arch/amd64-osabi.exp b/gdb/testsuite/gdb.arch/amd64-osabi.exp > index 0c435893bfd3..151fa35e8e4c 100644 > --- a/gdb/testsuite/gdb.arch/amd64-osabi.exp > +++ b/gdb/testsuite/gdb.arch/amd64-osabi.exp > @@ -24,10 +24,10 @@ if { ![istarget x86_64-*-* ] } { > proc test_osabi_none { arch void_ptr_size long_double_size } { > clean_restart > > - gdb_test "set architecture i386:x86-64" "The target architecture is set to \"i386:x86-64\"\\." > + gdb_test "set architecture $arch" "The target architecture is set to \"$arch\"\\." > gdb_test_no_output "set osabi none" "set osabi none" > - gdb_test "print sizeof (void*)" " = 8" > - gdb_test "print sizeof (long double)" " = 16" > + gdb_test "print sizeof (void*)" " = $void_ptr_size" > + gdb_test "print sizeof (long double)" " = $long_double_size" > } > > set infos { \ > -- > 2.30.1 >