From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id OdQQAYcAlWDePAAAWB0awg (envelope-from ) for ; Fri, 07 May 2021 04:55:35 -0400 Received: by simark.ca (Postfix, from userid 112) id EAEC11F11C; Fri, 7 May 2021 04:55:34 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id DCFBC1E813 for ; Fri, 7 May 2021 04:55:33 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 636D33835819; Fri, 7 May 2021 08:55:33 +0000 (GMT) Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by sourceware.org (Postfix) with ESMTPS id B74E5386EC59 for ; Fri, 7 May 2021 08:55:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B74E5386EC59 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=andrew.burgess@embecosm.com Received: by mail-wr1-x434.google.com with SMTP id d11so8353649wrw.8 for ; Fri, 07 May 2021 01:55:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=HqcJgVtfkBfl8V6Epy4tWPGp9RZAPynSXGVz9BUTB04=; b=Mk3uBA+qFEdPwculMWaGLhN6WJuXaTHXCN2OpuM4xhBn+k5zwlMTLtUmJXDgi0dkpF EmK9T6n6MrVMjhZljAlK3xL9v+ZrbaES/lsLz8bx6vR00Wo5Dkuz/9e7iXiboeN1hGS+ HDF4Uk2FftBHf10UVwOvuYMuFR0EcQJobnObA4VoGO3vR5GgUzTkUQqzpEXcIj2HhvmG hJ0q6I6JxNqWdKnvbXjFLLUE5GLMW+grNPI4wRwf+lb7GXBwinlvE9dd4bsT47poag8Z vPjdcMuXjzFOwvXlrjr/CcYQVfCVs5V5lHdpYjHgvJYFHV/XJKpIwO6bR666P83KD2ci MT8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=HqcJgVtfkBfl8V6Epy4tWPGp9RZAPynSXGVz9BUTB04=; b=AoE+KZQNR8njG4X9B8lunSILFEKRQrz59UBPKyNDIT2grghy0yyjwc8C55w9u8jrf8 llDvjmDtQUpbfiXVQE2NCCdCe8pLo6ozUU7j2ps1AGCDX9U1+NZLlS5yXYDuZhnqIUyK tDun4W/wiwWYUJ7CP5BgOJEeNqmyD6bq7w6wfb3YD3v8cwsl+qziQKwCk7gokHJoxIUr cb1W6s8p4yDO3bTxb1c7lwm0flXFBkPudEoP2FICsS+GwQIGKN9EXJESxWFpqlO2yeTY oNscESSRhczGxS+VPDEHwqC/a+cex798e+r+L5qkrhwTjq6t9gZNRjJpxWfJOV3nQNJe hi5w== X-Gm-Message-State: AOAM532VEwjfFK4IijTZjXaLJYItCkiCQdpeCjR4iYxKdl3gUlfbKQbu 1Hf07+N9hrOzZ9H5hfMwGcYdY0BkMWdQzA== X-Google-Smtp-Source: ABdhPJw0pq6Q9TDdz40u23y4kAlN5IsXSIjsqWg1o0RKqSDwlnkDY4LnRhQ6S8ZO1idPsA5lOwV6+w== X-Received: by 2002:adf:f74e:: with SMTP id z14mr10754189wrp.320.1620377729863; Fri, 07 May 2021 01:55:29 -0700 (PDT) Received: from localhost (host109-151-46-70.range109-151.btcentralplus.com. [109.151.46.70]) by smtp.gmail.com with ESMTPSA id 61sm8939499wrm.52.2021.05.07.01.55.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 May 2021 01:55:28 -0700 (PDT) Date: Fri, 7 May 2021 09:55:28 +0100 From: Andrew Burgess To: Simon Marchi Subject: Re: [PATCHv2 2/2] gdb/guile: Have gdbscm_safe_source_script return a unique_ptr Message-ID: <20210507085528.GG6612@embecosm.com> References: <87bl9pq9li.fsf@tromey.com> <17720e44850a8a0ed172812da5ce6a3919f9bb4e.1620248278.git.andrew.burgess@embecosm.com> <4d2ff439-afdf-08d1-2ec2-a07d07a0739c@polymtl.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4d2ff439-afdf-08d1-2ec2-a07d07a0739c@polymtl.ca> X-Operating-System: Linux/5.8.18-100.fc31.x86_64 (x86_64) X-Uptime: 09:54:59 up 3 days, 21:49, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" * Simon Marchi [2021-05-05 22:32:40 -0400]: > On 2021-05-05 10:28 p.m., Simon Marchi via Gdb-patches wrote: > > On 2021-05-05 5:01 p.m., Andrew Burgess wrote: > >> diff --git a/gdb/guile/scm-safe-call.c b/gdb/guile/scm-safe-call.c > >> index 5bea970239b..a475774f921 100644 > >> --- a/gdb/guile/scm-safe-call.c > >> +++ b/gdb/guile/scm-safe-call.c > >> @@ -432,7 +432,7 @@ scscm_source_scheme_script (void *data) > >> printed according to "set guile print-stack" and the result is an error > >> message allocated with malloc, caller must free. */ > >> > >> -char * > >> +gdb::unique_xmalloc_ptr > >> gdbscm_safe_source_script (const char *filename) > >> { > >> /* scm_c_primitive_load_path only looks in %load-path for files with > >> @@ -454,7 +454,7 @@ gdbscm_safe_source_script (const char *filename) > >> (void *) filename); > >> > >> if (result != NULL) > >> - return xstrdup (result); > >> + return make_unique_xstrdup (result); > >> return NULL; > > > > Hmm, result comes from gdbscm_with_guile, which states: > > > > The result if NULL if no exception occurred, otherwise it is a statically > > allocated error message (caller must *not* free). */ > > Ahh, nevermind. I noticed now that it's "make_unique_xstrdup". I first > read it as just creating a unique pointer to wrap result. > > LGTM then! Thanks. I pushed this patch independently of patch #1. Andrew