From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 0Pa/CBmYj2DuOAAAWB0awg (envelope-from ) for ; Mon, 03 May 2021 02:28:41 -0400 Received: by simark.ca (Postfix, from userid 112) id 154031F11C; Mon, 3 May 2021 02:28:41 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 458261E01F for ; Mon, 3 May 2021 02:28:36 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A9B1D3948A71; Mon, 3 May 2021 06:28:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A9B1D3948A71 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1620023315; bh=nJ+sbLkfCtxu9ApRaC22wjt2rqJ4zaV1Ugrmm1+EQjY=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Ujhx0ANt5SJqhytlHDr+2O7pY7iPbbXTEBacf7i3czI0u+YaXR8PvOLscqI8ZgFWH onc3gnqnSpC49asbSFEvA4mDsubi7TYkGNeMeE+cnMYVCxZTDhpxXwK48TUCfhcfYh zHdjtdEVMgLbX0m687WACzX+TXkjXsrHVaK19hfs= Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by sourceware.org (Postfix) with ESMTPS id 4DACF3948010; Mon, 3 May 2021 06:28:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 4DACF3948010 Received: by mail-pl1-x62d.google.com with SMTP id y1so2260719plg.11; Sun, 02 May 2021 23:28:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=nJ+sbLkfCtxu9ApRaC22wjt2rqJ4zaV1Ugrmm1+EQjY=; b=YpuQONZ1vkOTU7y4doCjqBWRfNActkJcTCCOBz9dvRQQeTQrDhzjr+7gPu74unmKYC duTx9U40rtjIQg8TSyClaGnFZahQT3S4n979zxONGQ22j0X7yL8Zr2w7pxXuxoMQ9cLQ /TegTFKuVG9jo48SSsWnko5EmmGNl+t+LfuhSmn6lFEB3vT7/MW2Z8XYQH/x8CjA1gGm 1ojPtatuGFlOHUJhlq6tbKNCsHbn+cPz96WreEyhQwcvyOThID3+/aX9hdKWK+dM0fek Fec29dJWvxXKzbyIHZe6Bsnya00IGmnSq6YFhaZ2HGybzJuAMRO5Ywjou5U3UMOb8NoD vujA== X-Gm-Message-State: AOAM530cB/vi5btvswizza2T7pKSry/33LflpLT4TY7zvOtt2Sjka4nh kNkBO5UNX9ErOxBIYyQFrKY= X-Google-Smtp-Source: ABdhPJybv3Gf/cRhaeFhJWVTf5sVFvSHWhizgobk1UfoFvIof2fGlYurLoGByYjypm8fSPJ7uDET/A== X-Received: by 2002:a17:90a:f314:: with SMTP id ca20mr19252001pjb.164.1620023310447; Sun, 02 May 2021 23:28:30 -0700 (PDT) Received: from bubble.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id f3sm18847943pjo.3.2021.05.02.23.28.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 May 2021 23:28:29 -0700 (PDT) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 2114741BAA; Mon, 3 May 2021 15:58:26 +0930 (ACST) Date: Mon, 3 May 2021 15:58:26 +0930 To: Jeff Law Subject: Re: RFC: Changing AC_PROG_CC to AC_PROG_CC_C99 in top level configure Message-ID: <20210503062825.GG22624@bubble.grove.modra.org> References: <8c1b0ed9-e6f3-9c22-45c5-c2680a2a4830@polymtl.ca> <15701c5f-5653-f0e4-990a-43094d18a702@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <15701c5f-5653-f0e4-990a-43094d18a702@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Alan Modra via Gdb-patches Reply-To: Alan Modra Cc: gdb-patches@sourceware.org, gcc-patches@gcc.gnu.org, Nick Clifton , Binutils Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On Fri, Apr 30, 2021 at 03:48:00PM -0600, Jeff Law via Gcc-patches wrote: > > On 4/30/2021 12:36 PM, Simon Marchi via Gcc-patches wrote: > > On 2021-04-26 7:32 a.m., Nick Clifton via Gdb-patches wrote:> Hi Guys, > > > Given that gcc, gdb and now binutils are all now requiring C99 as a > > > minimum version of C, are there any objections to updating > > > configure.ac to reflect this ? > > > > > > Cheers > > > Nick > > > > > > diff --git a/configure.ac b/configure.ac > > > index a721316d07b..59b4194fb24 100644 > > > --- a/configure.ac > > > +++ b/configure.ac > > > @@ -1278,7 +1278,7 @@ else > > > WINDMC_FOR_BUILD="\$(WINDMC)" > > > fi > > > > > > -AC_PROG_CC > > > +AC_PROG_CC_C99 > > > AC_PROG_CXX > > > > > > # We must set the default linker to the linker used by gcc for the correct > > Hi Nick, > > > > I think this fix is obvious enough, I encourage you to push it, that > > will fix the build failure many people get in opcodes/ppc-dis.c. We'll > > just remove the line later when we upgrade to Autoconf 2.71, as simple > > as that. For now we use 2.69. If that matters, you have my OK for the > > GDB side of things. > > That works for me.  I'd just sent Alan the trivial patch to make ppc-dis.c > compile again with C89, but if we're going to update configure.ac > appropriately, then it wouldn't be needed. Yes, I prefer the configure fix too. If we state we require C99 in binutils then we ought to be able to use C99.. Nick, does the configure.ac change also need to go in all subdirs, to support people running make in say ld/ rather than running make in the top build dir? -- Alan Modra Australia Development Lab, IBM