From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id CzhAOR0ogmB/bAAAWB0awg (envelope-from ) for ; Thu, 22 Apr 2021 21:51:25 -0400 Received: by simark.ca (Postfix, from userid 112) id DBAE41F104; Thu, 22 Apr 2021 21:51:25 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED, MAILING_LIST_MULTI,T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D04541E01F for ; Thu, 22 Apr 2021 21:51:21 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1B1B03857804; Fri, 23 Apr 2021 01:51:16 +0000 (GMT) Received: from gateway24.websitewelcome.com (gateway24.websitewelcome.com [192.185.51.56]) by sourceware.org (Postfix) with ESMTPS id 708733857804 for ; Fri, 23 Apr 2021 01:51:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 708733857804 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway24.websitewelcome.com (Postfix) with ESMTP id 08CA629D9A for ; Thu, 22 Apr 2021 20:51:12 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id ZkyNl6iVNw11MZkyNlYKiq; Thu, 22 Apr 2021 20:51:12 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject: Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Z2qvz4IZldJQmrSO3WHaYMyMYEHnXEpLBLka6OIqpRI=; b=ncElMHxMYWZSbPYO0yADAnP0Pm W6/GYZhtfzL0i1L0uV1qeTRzqO1TncdVBLOPo6x9od4tBI1rPFXDI5saoQNuFJpIMsjFvL19wA76T TpelEwp0jvKQCbkc1Yw3NEGVN; Received: from 71-211-182-15.hlrn.qwest.net ([71.211.182.15]:43600 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lZkyN-002qCp-P3; Thu, 22 Apr 2021 19:51:11 -0600 From: Tom Tromey To: gdb-patches@sourceware.org Subject: [pushed] Fix sim build failure Date: Thu, 22 Apr 2021 19:51:07 -0600 Message-Id: <20210423015107.3841223-1-tom@tromey.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.182.15 X-Source-L: No X-Exim-ID: 1lZkyN-002qCp-P3 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-182-15.hlrn.qwest.net (localhost.localdomain) [71.211.182.15]:43600 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tom Tromey Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On x86-64 Fedora 32, the sim was failing to build. sim_events_schedule was passing a 'dummy' argument to sim_events_schedule_vtracef, which caused an error because the format parameter was NULL. However, removing this dummy argument caused an error because too few arguments were being passed -- catch 22. This patch fixes the build problem by using sim_events_schedule_tracef instead. sim/common/ChangeLog 2021-04-22 Tom Tromey * sim-events.c (sim_events_schedule): Use sim_events_schedule_tracef. --- sim/common/ChangeLog | 5 +++++ sim/common/sim-events.c | 5 +---- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/sim/common/sim-events.c b/sim/common/sim-events.c index 207c8674d16..60e4c55a874 100644 --- a/sim/common/sim-events.c +++ b/sim/common/sim-events.c @@ -469,10 +469,7 @@ sim_events_schedule (SIM_DESC sd, sim_event_handler *handler, void *data) { - va_list dummy; - memset (&dummy, 0, sizeof dummy); - return sim_events_schedule_vtracef (sd, delta_time, handler, data, - NULL, dummy); + return sim_events_schedule_tracef (sd, delta_time, handler, data, NULL); } #endif -- 2.26.2