From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4If5Fp7ugWDCZwAAWB0awg (envelope-from ) for ; Thu, 22 Apr 2021 17:46:06 -0400 Received: by simark.ca (Postfix, from userid 112) id 5C1DD1F104; Thu, 22 Apr 2021 17:46:05 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C68841E54D for ; Thu, 22 Apr 2021 17:46:04 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6964539AF83E; Thu, 22 Apr 2021 21:46:04 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6964539AF83E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1619127964; bh=9rEZ1yA6H97/A6zXDtCOACCI3qw3M3R5sED5+G9lSRs=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=noI2ckeG0DKixkxoxqfywQ2FM4M1vmjlD+Gu5Gu7W+OMWMdBRXrLEfspgLVWAy3sn ceZ/8ALG4P/HbIw1jC/NZXwRieDzq0K/aCEUwHHDozrydi26LwTN0fP1Ngu002b4/g LAL3HLCxK6HL+V9hbW5L1xPeskfH1+gDQjdlfIV4= Received: from lndn.lancelotsix.com (vps-42846194.vps.ovh.net [IPv6:2001:41d0:801:2000::2400]) by sourceware.org (Postfix) with ESMTPS id B7F6D3898506 for ; Thu, 22 Apr 2021 21:45:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B7F6D3898506 Received: from Plymouth (unknown [IPv6:2a02:390:9086:0:c18e:8981:d006:7a4a]) by lndn.lancelotsix.com (Postfix) with ESMTPSA id 4ADD181C09; Thu, 22 Apr 2021 21:45:57 +0000 (UTC) Date: Thu, 22 Apr 2021 22:45:53 +0100 To: Tom Tromey Subject: Re: [PATCH] Fix ptype/o bug with "" Message-ID: <20210422214553.pkvxsgnotuftuwgt@Plymouth> References: <20210422014904.3521301-1-tom@tromey.com> <20210422093100.GM2610@embecosm.com> <87zgxq8nmr.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87zgxq8nmr.fsf@tromey.com> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.11 (lndn.lancelotsix.com [0.0.0.0]); Thu, 22 Apr 2021 21:45:57 +0000 (UTC) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Lancelot SIX via Gdb-patches Reply-To: Lancelot SIX Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On Thu, Apr 22, 2021 at 07:17:16AM -0600, Tom Tromey wrote: > >>>>> "Andrew" == Andrew Burgess writes: > > >> gdb/ChangeLog > >> 2021-04-21 Tom Tromey > >> > >> * c-typeprint.c (c_type_print_base_struct_union): Use > >> print_spaces_filtered_with_print_options. > >> > >> gdb/testsuite/ChangeLog > >> 2021-04-21 Tom Tromey > >> > >> * gdb.base/ptype-offsets.cc (struct empty_member): New. > >> (main): Use empty_member. > >> * gdb.base/ptype-offsets.exp: Add new test. > > Andrew> LGTM. > > Thanks. I think I'll hold this one until the other ptype/o patches > land. > > Tom Hi, I think you are referring to my ptype patch (https://sourceware.org/pipermail/gdb-patches/2021-April/177841.html) which still needs to be approved for the documentation part. I do not mind reworking it to take into account this patch if it lands in master first. It should only have conflicts on the tests, which will be easy to fix. Lancelot.