From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id UCW1JyRJgGAZPAAAWB0awg (envelope-from ) for ; Wed, 21 Apr 2021 11:47:48 -0400 Received: by simark.ca (Postfix, from userid 112) id 92F1F1F104; Wed, 21 Apr 2021 11:47:48 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 982971E789 for ; Wed, 21 Apr 2021 11:47:47 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 157F13838004; Wed, 21 Apr 2021 15:47:47 +0000 (GMT) Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by sourceware.org (Postfix) with ESMTPS id D10AE3838004 for ; Wed, 21 Apr 2021 15:47:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D10AE3838004 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=andrew.burgess@embecosm.com Received: by mail-wm1-x329.google.com with SMTP id n10-20020a05600c4f8ab0290130f0d3cba3so2828239wmq.1 for ; Wed, 21 Apr 2021 08:47:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=EUSWicY9tpVE6ye/CLsgzX9KSjAgBIOckHF9yH5VQxY=; b=R66Huu5G8klCAqfFIkxViFikI3gdWPUcb1jq3DAvbVzmfI2Sky/lxPkruYgLHMJg6k 2I9QZrrCSAUpVjk4TLghAdMFDS4ykjPYFcQCJWkao6kDNyI7CURU6q+G+gSaZ84SeJ8d Zo9lrLJ7TtLDrUtZ/23t7B5NIslF4mZBCInlY4WP13T+YO97mrK6DTD5iikt1MFiSKQV 3IFNCGiD0a277ImeKeomvwzPs73sJoyu/cio+JTDe+CJMrB6O27UB7QOu61ySQelje0F IRMT9TWoIiyYaOH2g2hMYVs6BxDlFyoTydW9zQcvlZmd/8HUhNkUJFsk0zlRWVXuW8kx 6k8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=EUSWicY9tpVE6ye/CLsgzX9KSjAgBIOckHF9yH5VQxY=; b=RrQRZkcKNhsBsRQC7ShYbUPOv8Z2HsqegB/FLKKgmZjSBy39KpFRkXChPejMoAWK0N veMhXl/VvmXTbfEEJ3GbAvcN0gf0I4DSKFjHxlU0YU+Pw/AL/jsQ2ip7i6OHKE07VUHq 9lJ+glEBAXlZaucKYRQwlxhA0RDEMTdTGgOG2qAV9nJ+DWeRTBp7+Cm9+Gmpp6p+XagP oUFm7aBQ//mQpEa95z9y2ta9qygniyfjRytmpmMdslJ5lxbAkX6RWWHshmErtxSpHAWM o1k5uhP87v+OmrVitvbqxnZ5LTe3JYSqF1xjfzM79iee5fZiB7eXj6VraDmkHFRCli2n h4Sg== X-Gm-Message-State: AOAM532qTP9vVFZ74+4nXeMTqmAaa6df909NNi/+UFQDGiQ/bcPjlpWt fbssQ6oAwOUa2krPvEUPOE1ne0gASfyPAA== X-Google-Smtp-Source: ABdhPJyt2IMz1HVDCEV03Rs/9Zl+xcWEEAZIKkSMXEqlPzaSKJ753aOaLEs296x5wvbD3p6vl5yzXQ== X-Received: by 2002:a7b:c4d5:: with SMTP id g21mr10252204wmk.55.1619020060962; Wed, 21 Apr 2021 08:47:40 -0700 (PDT) Received: from localhost (host109-151-46-70.range109-151.btcentralplus.com. [109.151.46.70]) by smtp.gmail.com with ESMTPSA id l14sm3499213wrv.94.2021.04.21.08.47.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Apr 2021 08:47:40 -0700 (PDT) Date: Wed, 21 Apr 2021 16:47:39 +0100 From: Andrew Burgess To: Jim Wilson Subject: Re: [PATCH 00/24] RISC-V sim: Update from riscv-gnu-toolchain. Message-ID: <20210421154739.GH2610@embecosm.com> References: <20210417175831.16413-1-jimw@sifive.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210417175831.16413-1-jimw@sifive.com> X-Operating-System: Linux/5.8.18-100.fc31.x86_64 (x86_64) X-Uptime: 16:44:26 up 11 days, 2:31, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" * Jim Wilson [2021-04-17 10:58:07 -0700]: > These are mostly patches extracted from riscv-gnu-toolchain with minor > changes to apply to current FSF GDB sim. I was careful to maintain the > original author info, and the original commit logs when reasonable. Maybe a silly question, but all of these authors do have an FSF copyright assignment in place, right? And they did all agree to pass this code over to the FSF, right? I don't think we can assume that just because an assignment is in place they choose to give this code over to FSF, it would depend upon the context in which they originally posted the code. Thanks, Andrew > There are also a few extra patches from me added in, as I noticed some > problems when reviewing the patches, and debugging issues. Note that > Kito and Monk were at Andes when they wrote these patches, and are now > at SiFive. So this is mostly Andes work, and they should get credit > for this work. I kept their original email addresses even though they > won't work anymore. We will need permission from Andes to merge the > patches into FSF GDB. Hopefully Kuan-Lin can do that for us. The patches > from Palmer and myself were written at SiFive. > > I tested this with a gcc make check using riscv-gnu-toolchain and pulling > in FSF GDB sim with my patches applied. I get 13 gcc unexpected failures > for rv32imac/ilp32 and 24 gcc unexpected failures for rv64gc/lp64d which > matches the old simulator port in riscv-gnu-toolchain. I did have one > problem with the GNUC code in mulhu function producing the wrong result, > but I think that is a bug in the Ubuntu 16.04 gcc-4.8 on my server. If > this is still broken with newer gcc versions I will take another look at > that. > > This code can probably use some cleanup. I'd like to see the extensions > in canonical arch order for instance. But dealing with this many patches > is unwieldy, and I wanted to retain the original authorship for the > patches, so I'd rather do cleanup work as follow on patches. > > Jim > > Jim Wilson (6): > RISC-V sim: Fix fence.i. > RISC-V sim: More atomic fixes. > RISC-V sim: Fix ebreak, part 2. > RISC-V sim: Fix mingw builds. > RISC-V sim: Support compressed FP instructions. > RISC-V sim: Add zicsr support. > > Kito Cheng (9): > RISC-V sim: Atomic fixes. > RISC-V sim: Fix syscall fallback. > RISC-V sim: Add csrr*i instructions. > RISC-V sim: Improve cycle and instret counts. > RISC-V sim: Check sbrk argument. > RISC-V sim: Improve branch tracing. > RISC-V sim: Improve tracing for slt* instructions. > RISC-V sim: Set brk to _end if possible. > RISC-V sim: Fix divw and remw. > > Kuan-Lin Chen (5): > RISC-V sim: Fix stack pointer alignment. > RISC-V sim: Add link syscall support. > RISC-V sim: Add brk syscall. > RISC-V sim: Add gettimeofday. > RISC-V sim: Fix tracing typo. > > Monk Chiang (3): > RISC-V: Add fp support. > RISC-V sim: Fix ebreak. > RISC-V sim: Add compressed support. > > Palmer Dabbelt (1): > RISC-V sim: Fix for jalr. > > sim/riscv/interp.c | 45 ++ > sim/riscv/sim-main.c | 1790 ++++++++++++++++++++++++++++++++++++++++++++++---- > sim/riscv/sim-main.h | 16 +- > 3 files changed, 1733 insertions(+), 118 deletions(-) > > -- > 2.7.4 >