From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id mM0TGAkie2CaOgAAWB0awg (envelope-from ) for ; Sat, 17 Apr 2021 13:59:37 -0400 Received: by simark.ca (Postfix, from userid 112) id 60DE71F106; Sat, 17 Apr 2021 13:59:37 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 156BE1EE0E for ; Sat, 17 Apr 2021 13:59:35 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A95E23898520; Sat, 17 Apr 2021 17:59:34 +0000 (GMT) Received: from mail-pf1-x429.google.com (mail-pf1-x429.google.com [IPv6:2607:f8b0:4864:20::429]) by sourceware.org (Postfix) with ESMTPS id E0670389853F for ; Sat, 17 Apr 2021 17:59:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E0670389853F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=jimw@sifive.com Received: by mail-pf1-x429.google.com with SMTP id d124so20418539pfa.13 for ; Sat, 17 Apr 2021 10:59:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=6EL/Aw98q7PiVZguZ2XC+gLdGov0r2Dn/A/uaFKrOgY=; b=gpFcNXRCNs1xZpU9WQeZuIrPZiKBre8SXc1oKofWXB9Wc5Bl0z3ekOV6UyrvBcHtW7 JNGK3dDzHRolYREUVQKZ7jIHo4O4rQAcRq4sPbVS2/D2wkqPDfDi3Mv4xqJ82Z6wsqUU dERcxbLP/S6WB1TP0qG3xj77QnF+nhzbhlc3QhJc1adZQRdBKmWEjqtXnsGHT8oIcDCw NBABPBeuxYqNkgKZgmS5Nq6Xina9ZfaMA0wHZ63H3Av9XRavbImUpDk7F+prmOrRJG7u VtZBkY2FSJD3sMbgcYPZylM9TQlwskStx94hCjzodTYt4zlGh91OW0ajRssn1W0MSNpA by1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=6EL/Aw98q7PiVZguZ2XC+gLdGov0r2Dn/A/uaFKrOgY=; b=Ovf74ZUdQYsRr53sJgKxcN0otEfCIDR+b/QY+VUkAajsvxowZ7C3Llx6RvrdMcBB8S xCeHP+NOURvskuWGdF3lYrcYNtTHP1Nmkg4f3AmPRMS1z3dcID9EEx5T27QokdXm+IHg bIwjaDrIUvZlmHKanfiD8Fzop/2gE2CspMPi1o05cA2c1y5sIUsrqCcjNdC1PrSlpUoc J2IlvT11qVkJ2KGBt8kByBqTJtfDDRKnF0wHBX4VdW7STCXJTY1At7oy+XpYKuvDyW6Y j504ldiQvYNx0ZjqB+UCw51A/4tlKEvsVl1OBlIkipG2bzZD6DYJS+0C/omlJ7ip6U9i gnlw== X-Gm-Message-State: AOAM533MfAWDwTYYUAJ/OsWu4Itj0amLckqEpl5Jmt2fqk+VBv5L2gpo ieynqJReRjaG68dvVwDHS7Ka/kV4o2ZvLQ== X-Google-Smtp-Source: ABdhPJzD8kHya1mo8vUlpfHWBUiul/wIAhs/6B4XN8WTzjsLPlGmrgoIeL28qh49SJtZehPILfcxlQ== X-Received: by 2002:a65:4c0c:: with SMTP id u12mr4276517pgq.122.1618682359796; Sat, 17 Apr 2021 10:59:19 -0700 (PDT) Received: from rohan.hsd1.ca.comcast.net ([2601:646:c180:b150:1820:3ed4:975:3fbe]) by smtp.gmail.com with ESMTPSA id u4sm5030705pfk.56.2021.04.17.10.59.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Apr 2021 10:59:19 -0700 (PDT) From: Jim Wilson To: gdb-patches@sourceware.org Subject: [PATCH 16/24] RISC-V sim: Check sbrk argument. Date: Sat, 17 Apr 2021 10:58:23 -0700 Message-Id: <20210417175831.16413-17-jimw@sifive.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210417175831.16413-1-jimw@sifive.com> References: <20210417175831.16413-1-jimw@sifive.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kito Cheng Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" From: Kito Cheng If sbrk arg greater than memory size, then fail. sim/riscv/ * sim-main.c (execute_i): In TARGET_sys_brk, when setting endbrk, add check for DEFAULT_MEM_SIZE. --- sim/riscv/sim-main.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/sim/riscv/sim-main.c b/sim/riscv/sim-main.c index 4275ee2..15d9876 100644 --- a/sim/riscv/sim-main.c +++ b/sim/riscv/sim-main.c @@ -1791,7 +1791,12 @@ execute_i (SIM_CPU *cpu, unsigned_word iw, const struct riscv_opcode *op) if (cpu->a0 == 0) cpu->a0 = cpu->endbrk; else - cpu->endbrk = cpu->a0; + { + if (cpu->a0 >= DEFAULT_MEM_SIZE) + cpu->a0 = -1; + else + cpu->endbrk = cpu->a0; + } break; } case TARGET_SYS_gettimeofday: -- 2.7.4