Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: John Baldwin <jhb@FreeBSD.org>
To: gdb-patches@sourceware.org
Subject: [PATCH 2/5] sim frv: Add a missing return value for frvbf_check_acc_range.
Date: Wed, 14 Apr 2021 16:02:56 -0700	[thread overview]
Message-ID: <20210414230259.19234-3-jhb@FreeBSD.org> (raw)
In-Reply-To: <20210414230259.19234-1-jhb@FreeBSD.org>

Claim that the accumulator indices are out of range without raising an
exception if the CPU doesn't support media instructions.

sim/frv/ChangeLog:

	* traps.c (frvbf_check_acc_range): Add missing return value.
---
 sim/frv/ChangeLog | 4 ++++
 sim/frv/traps.c   | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/sim/frv/ChangeLog b/sim/frv/ChangeLog
index 1ec05977f69..81f5621250a 100644
--- a/sim/frv/ChangeLog
+++ b/sim/frv/ChangeLog
@@ -1,3 +1,7 @@
+2021-04-14  John Baldwin  <jhb@FreeBSD.org>
+
+	* traps.c (frvbf_check_acc_range): Add missing return value.
+
 2021-04-12  Mike Frysinger  <vapier@gentoo.org>
 
 	* sim-if.c (sim_open): Delete 3rd arg to sim_cpu_alloc_all.
diff --git a/sim/frv/traps.c b/sim/frv/traps.c
index c0ed9b1c49f..5e6a4d06ef4 100644
--- a/sim/frv/traps.c
+++ b/sim/frv/traps.c
@@ -742,7 +742,7 @@ frvbf_check_acc_range (SIM_CPU *current_cpu, SI regno)
   /* Only applicable to fr550 */
   SIM_DESC sd = CPU_STATE (current_cpu);
   if (STATE_ARCHITECTURE (sd)->mach != bfd_mach_fr550)
-    return;
+    return 0;
 
   /* On the fr550, media insns in slots 0 and 2 can only access
      accumulators acc0-acc3. Insns in slots 1 and 3 can only access
-- 
2.30.1


  parent reply	other threads:[~2021-04-14 23:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-14 23:02 [PATCH 0/5] Various build fixes for sims John Baldwin
2021-04-14 23:02 ` [PATCH 1/5] sim: Add SIM_EXTRA_CFLAGS after CSEARCH John Baldwin
2021-04-14 23:56   ` Mike Frysinger via Gdb-patches
2021-04-14 23:02 ` John Baldwin [this message]
2021-04-14 23:54   ` [PATCH 2/5] sim frv: Add a missing return value for frvbf_check_acc_range Mike Frysinger via Gdb-patches
2021-11-10  9:33   ` Mike Frysinger via Gdb-patches
2021-04-14 23:02 ` [PATCH 3/5] sim lm32: Use a known-good shell with genmloop.sh John Baldwin
2021-04-14 23:55   ` Mike Frysinger via Gdb-patches
2021-04-14 23:02 ` [PATCH 4/5] sim mn10300: Fix igen generation John Baldwin
2021-04-14 23:53   ` Mike Frysinger via Gdb-patches
2021-04-14 23:02 ` [PATCH 5/5] sim erc32: Add include path for readline John Baldwin
2021-04-14 23:56   ` Mike Frysinger via Gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210414230259.19234-3-jhb@FreeBSD.org \
    --to=jhb@freebsd.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox