From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 0OhaCtgkY2AIaQAAWB0awg (envelope-from ) for ; Tue, 30 Mar 2021 09:17:12 -0400 Received: by simark.ca (Postfix, from userid 112) id 28D431EE0E; Tue, 30 Mar 2021 09:17:12 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=MAILING_LIST_MULTI, RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 82BD21E783 for ; Tue, 30 Mar 2021 09:17:09 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C9A7E3858002; Tue, 30 Mar 2021 13:17:08 +0000 (GMT) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id E39F23858002 for ; Tue, 30 Mar 2021 13:17:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E39F23858002 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tdevries@suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 16066B49F for ; Tue, 30 Mar 2021 13:17:03 +0000 (UTC) Date: Tue, 30 Mar 2021 15:17:01 +0200 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [committed][gdb/testsuite] Add missing .debug_abbrev terminator in dw2-cu-size.S Message-ID: <20210330131700.GA8241@delia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Hi, Since commit 27012aba8a6 "Remove Irix 6 workaround from DWARF abbrev reader" we have: ... (gdb) file dw2-cu-size^M Reading symbols from dw2-cu-size...^M DW_FORM_strp pointing outside of .debug_str section [in module dw2-cu-size]^M (No debugging symbols found in dw2-cu-size)^M (gdb) ptype noloc^M No symbol table is loaded. Use the "file" command.^M (gdb) FAIL: gdb.dwarf2/dw2-cu-size.exp: ptype noloc ... The problem is a missing .debug_abbrev terminator in dw2-cu-size.S, which causes the .debug_abbrev contribution to be merged with the next: ... Number TAG (0x9b) 1 DW_TAG_compile_unit [has children] DW_AT_name DW_FORM_string DW_AT_producer DW_FORM_string DW_AT_language DW_FORM_data1 DW_AT value: 0 DW_FORM value: 0 2 DW_TAG_variable [no children] DW_AT_name DW_FORM_string DW_AT_type DW_FORM_ref4 DW_AT_external DW_FORM_flag DW_AT value: 0 DW_FORM value: 0 3 DW_TAG_base_type [no children] DW_AT_name DW_FORM_string DW_AT_byte_size DW_FORM_data1 DW_AT_encoding DW_FORM_data1 DW_AT value: 0 DW_FORM value: 0 4 DW_TAG_const_type [no children] DW_AT_type DW_FORM_ref_udata DW_AT value: 0 DW_FORM value: 0 1 DW_TAG_compile_unit [has children] DW_AT_producer DW_FORM_strp DW_AT_language DW_FORM_data1 DW_AT_name DW_FORM_strp DW_AT_comp_dir DW_FORM_strp DW_AT_low_pc DW_FORM_addr DW_AT_high_pc DW_FORM_data8 DW_AT_stmt_list DW_FORM_sec_offset DW_AT value: 0 DW_FORM value: 0 ... and consequently, abbreviation code 1 no longer refers to a unique entry. The eventually causes us to access the first attribute of this DIE: ... <0><124>: Abbrev Number: 1 (DW_TAG_compile_unit) <125> DW_AT_name : file1.txt <12f> DW_AT_producer : GNU C 3.3.3 <13b> DW_AT_language : 1 (ANSI C) ... which has form DW_FORM_string, using DW_FORM_strp. Fix this by adding the missing .debug_abbrev terminator in dw2-cu-size.S. Committed to trunk. Thanks, - Tom [gdb/testsuite] Add missing .debug_abbrev terminator in dw2-cu-size.S gdb/testsuite/ChangeLog: 2021-03-30 Tom de Vries PR testsuite/27604 * gdb.dwarf2/dw2-cu-size.S: Add missing .debug_abbrev terminator. --- gdb/testsuite/gdb.dwarf2/dw2-cu-size.S | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gdb/testsuite/gdb.dwarf2/dw2-cu-size.S b/gdb/testsuite/gdb.dwarf2/dw2-cu-size.S index af951ea8777..ebbfdb29c5c 100644 --- a/gdb/testsuite/gdb.dwarf2/dw2-cu-size.S +++ b/gdb/testsuite/gdb.dwarf2/dw2-cu-size.S @@ -104,3 +104,6 @@ .byte 0x0 /* Terminator */ .byte 0x0 /* Terminator */ + + .byte 0x0 /* Terminator .debug_abbrev + section. */