Re: [PATCH 09/43] Move push_dwarf_reg_entry_value to expr.c

Simon Marchi via Gdb-patches
2021-04-27T03:57:02Z

> diff --git a/gdb/dwarf2/expr.c b/gdb/dwarf2/expr.c
> index 872de16cd70..0b7f3c90728 100644
> --- a/gdb/dwarf2/expr.c
> +++ b/gdb/dwarf2/expr.c
> @@ -268,6 +268,57 @@ dwarf_expr_context::read_mem (gdb_byte *buf, CORE_ADDR addr,
> read_memory (addr, buf, length);
> }
>
> +/* See expr.h. */
> +
> +void
> +dwarf_expr_context::push_dwarf_reg_entry_value
> + (enum call_site_parameter_kind kind,
> + union call_site_parameter_u kind_u,
> + int deref_size)

When the parameter list doesn't fit in the right of the name, we
typically to:

void
dwarf_expr_context::push_dwarf_reg_entry_value
(enum call_site_parameter_kind kind,
union call_site_parameter_u kind_u,
int deref_size)o

If we need to wrap, we might as well start completely on the left, that
leaves more space :).

Simon