From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id GGSUHKj+PGAGJAAAWB0awg (envelope-from ) for ; Mon, 01 Mar 2021 09:48:08 -0500 Received: by simark.ca (Postfix, from userid 112) id 6945E1F0BF; Mon, 1 Mar 2021 09:48:08 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B00441EF7C for ; Mon, 1 Mar 2021 09:48:02 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 32002393C037; Mon, 1 Mar 2021 14:48:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 32002393C037 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1614610081; bh=yFjB+PTtzJDN2lPhEzb7+tGcMv0HZsF+BmoqK9IKiOo=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=o8iIPfTGDKhcpdIOCeQbVxILz18XqnI8HZ66JNXeIUzRbeWh13St4KVDKGEd5EZSi mgvzo3RtbaDIdYzHuD+rPEMooPzN/IexiBF9YNz2rXtQjzKGKlOsvfM3E+CMtoC9Kq TVJ/bTjNvSsOpYwD6DgIm8z4+l7KDlSg0WEi4xFs= Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam08on2076.outbound.protection.outlook.com [40.107.102.76]) by sourceware.org (Postfix) with ESMTPS id A4806393BC27 for ; Mon, 1 Mar 2021 14:47:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A4806393BC27 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iI+gowWrhycZOOvVImYUifsyAcLX8Z5cZONbrtU2AQIKHKJ19+v4+RGF6uNjyY0MfR6CRfJL16VJWX+M/sADdtadu7Pw3DG9E2WCAhrU06MsSgKtGa6+WBhgdEv7K9ap51lczgILZQgh71JPs7tDnPjTjT4TyUrnCKjrjTMZEGtlCm29oX7AfYAlM+bSCcb3kTVuoPKw3inMvhBbHduj9dBFJ2FQmVcsmVIfQXJTy6v2Z2XoPp70nJvt92RsjhODVTU5uwXbrqEXXy34/Sb8iL2MD6ZR0wE5ZZrCa7EGONLCz8MTUm4MwLM2A+FNga9Wav08jEJEu//gO69muaKcaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yFjB+PTtzJDN2lPhEzb7+tGcMv0HZsF+BmoqK9IKiOo=; b=Va+yv2RtG+ndyoyCxnThcJIr5MG0KWyu8xpP2ECKPKSr+dS2fxquLLayRKxY+aNsKZ4H/XyzARy/qGnWd3xd9umklS0t2zmVaTN/hVIDZeM0soGrittzGOrW1A7xKPSlZhmg7qFEP0UXMFXIGWg9pkNRW6UfFoAJ1xZK+8ws0jYi40S2XOKN3QSswEh8odfOMATIdoBXkewg4Ftdfoi85y1zJaJBRxCgaSBGKsnixp7s+Eio+Io1DiPeCNlIDQEGZf+5Iw5rQ5Tkv8+Oq8rYqPkIgWtnJk/RkFoWPsfLV/BrvVLzsJD2TA0RpDWsY4nsCzLiFpJAXqkHr4F7h0MHMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from DM6PR12MB2762.namprd12.prod.outlook.com (2603:10b6:5:45::15) by DM5PR12MB2342.namprd12.prod.outlook.com (2603:10b6:4:ba::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.28; Mon, 1 Mar 2021 14:47:49 +0000 Received: from DM6PR12MB2762.namprd12.prod.outlook.com ([fe80::31d8:f503:f7b2:f44]) by DM6PR12MB2762.namprd12.prod.outlook.com ([fe80::31d8:f503:f7b2:f44%3]) with mapi id 15.20.3868.033; Mon, 1 Mar 2021 14:47:49 +0000 To: gdb-patches@sourceware.org Subject: [PATCH 38/43] Remove DWARF expression composition check Date: Mon, 1 Mar 2021 14:46:15 +0000 Message-Id: <20210301144620.103016-39-Zoran.Zaric@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210301144620.103016-1-Zoran.Zaric@amd.com> References: <20210301144620.103016-1-Zoran.Zaric@amd.com> Content-Type: text/plain X-Originating-IP: [2a00:23c7:5a85:6801:b4ed:fe7b:8064:d4d] X-ClientProxiedBy: AM0PR04CA0073.eurprd04.prod.outlook.com (2603:10a6:208:be::14) To DM6PR12MB2762.namprd12.prod.outlook.com (2603:10b6:5:45::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost.localdomain (2a00:23c7:5a85:6801:b4ed:fe7b:8064:d4d) by AM0PR04CA0073.eurprd04.prod.outlook.com (2603:10a6:208:be::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.19 via Frontend Transport; Mon, 1 Mar 2021 14:47:22 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 9fe71d8d-791e-4b46-ae64-08d8dcc0ec6d X-MS-TrafficTypeDiagnostic: DM5PR12MB2342: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Na+lmAslJviR4KdPNRkE4zPGNO+3qht+iF6rLoyEbkWmUBTYgQLQihBqa/ByT6XDi72xia+2ljVp4PZPyYyGKcumkb5EHmF0vgvFNVtUC8IOYWpQT234XQ6BIHtiSpBXixbAvvBS8gLe3pP8pKeZm2J+eo3uwcuerFgSMUcczK+njSVzLvGmtytxQKDfqNzSQRCfqw3OHf0hmcBC/X+R9aj3OeZXotmWNdET1PxWMhrjjQ4pkDl3EzF1JFeamvWq430ZKvzkSRjGIsIqC0rSrs1MRV5Eo30qaTsM2EBDsjoc5CV1hA0bT0v5CXZ4tp083mx3JjdAyM3VdDbOdeuTssvAiapd46EaQLYT3/bgi00WCHJx6/iXyYe8cjRwRNVK51WvmWjrKZbnICbUQVTUvGAozVrIWjmxjLcNW2hfC4/OLlRouVhLNrUKEtVeqLOmqC1Ij2Z+0ny/koalUfNdQ9bRIvUli8hth8MoYMrSJTeMtTNjLIC5S+n629/Iw7RNFUiq1HCPpMZ39p1/jDpYkcw5ypd266WThCJUgVIYPVsVQEVOi/pcUz5M3Us0tXypAb1uoVdutWsOvR67S5Vz1g== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2762.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(346002)(396003)(376002)(39860400002)(136003)(6486002)(66476007)(4326008)(478600001)(66556008)(2906002)(66946007)(69590400012)(316002)(52116002)(6666004)(6916009)(2616005)(86362001)(16526019)(6512007)(36756003)(8676002)(8936002)(6506007)(5660300002)(186003)(1076003)(83380400001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?rwgTiYPE0zNZfsh4rDEh9ohzPgbEshWpbhbnf6peVAh/8b9S21nrNIv+zRkH?= =?us-ascii?Q?O6xPxJHvAGWyLbFXdjxRb/21npYf+Nt8hyfIw+tc2LxIUJ0+x8Q7qZPuqmQQ?= =?us-ascii?Q?k+Z+/tYZa0uQa8oX29F98FoLMtBLvsI46iyBMAWMuIoegOOFzBW00kg9C+QV?= =?us-ascii?Q?y/Q5PJRkq/uVgon9J+QZYVjr3UGWyNB7bBPxsfpFl0u7IWPWYLyxDDqxOOF4?= =?us-ascii?Q?kiUObhglfm1KqSUi+ct1OZ2zSl9DxJ/OozWuqd/Sim0PFuvPUyb5Qh+MyaqM?= =?us-ascii?Q?oYH4CgwyfhgKN8oGWKvywYbDCVT4oR1oVv3EEGBcKANU6NmmuzFWQnq2Uxfk?= =?us-ascii?Q?xQJxyAJOJYS5ZbSlxEZbG/gyFj+13C+UGePqTF6JXGVOPouqwJYW2O/fs2+2?= =?us-ascii?Q?uCfpD2Vn8BukY6pkaTHnP7eQlgEePWxp8pjXQL2m0w874vNnmEmx+76uorHn?= =?us-ascii?Q?sxmNBhucOvgoWcxCDqVr+FFlgXt6aPObQWlTtk8oRLJW/D7bTrp1YnQzyPIk?= =?us-ascii?Q?TFluFfp20Kd5k0fMF5EfdSOG1YBzQ35xX01LwVxQGprZxuKMmxVPFwA5md0R?= =?us-ascii?Q?1ujB+QKBGAI5o1bhYxTU16KrR1ES9KZV39Z9apojjevPkSWEJ6DVNok0PWk8?= =?us-ascii?Q?VagaXwxMCJCB7WzopjFbjJ4EBeI9HlhPnnYrT4exXiaAsfV2l2/sFKRPr9Dm?= =?us-ascii?Q?Pa31RqHd7pjYzOJ6BQp9PB9x16uEhUpMTz7cjsKFzoFlEphQxuDNqArX7REb?= =?us-ascii?Q?TkNzcAJ69qb08sv8SfXUUvvlIPTiEB4Q2jV1hsVyRq09ZW+ecSwPwq2i5LW1?= =?us-ascii?Q?aSwp7bqojRVH4QWhLmJVtpXe4Q1tZg2G83UbwSO00bm76RIERrNu58+cdYN3?= =?us-ascii?Q?O9t6SsBwmTra4lrC9FxhWQgthz9ZWXBfpc+Ll+sDO/ZoYmvAncNZZtOiVtMj?= =?us-ascii?Q?tMfNKbXCboGUDMMNlBtbDE7RoUxpZsq7V9Qxavd44ICKagwReaA8HpqGYHN5?= =?us-ascii?Q?9SqQ2lJS2G70nSEItK+VXIYEC7Z5VLTYz87yQHveOHZGCNPPKMyVRBUit5Le?= =?us-ascii?Q?jd0a0v7+xWnR4vu2MLrq9AHs89j1/psfhzjkFl7pvOS5i9/kjVgVA1xmMgwo?= =?us-ascii?Q?G7NQz5cD9hq4FVvdEOuhjZwT9rWTqoHOeSlsHTUjmLVIILZR8YKIPqnbPVA1?= =?us-ascii?Q?g0ubuxK0KsgvyJb+//QomX4xhi8jRaVEHy3xRb3s9v1rdvyJ3Aw7xAOpRpDx?= =?us-ascii?Q?6+rxXXxj9Pf9c9GZMEvgYRdU8q7sZxfUz7uosrYfrL+/5zUw7MMmPSJJIKnG?= =?us-ascii?Q?ThmWJ8tLHPQdQhpr15sGaNd1NuSZTorBKvVBX4UO1B3ZHdifJ51f1N4pSsrI?= =?us-ascii?Q?9va7dtQaWxfnpW7rDc5y8aRcXkFZ?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9fe71d8d-791e-4b46-ae64-08d8dcc0ec6d X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2762.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2021 14:47:23.3886 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +nQxc0u4hs0skeNw2qJ0M8ROscXt6E180uYrv77B5RjsGHlXenad4KljlPoQBXtXAPDpLwnOW8rbatZRuFy2yg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB2342 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Zoran Zaric via Gdb-patches Reply-To: Zoran Zaric Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" The dwarf_expr_require_composition function reports an error if the last operation is not a leaf node of the DWARF expression. This was previously used to prevent location description operations to be used freely in the DWARF expression. With the new approach, all operations are treated the same and everything is composable, so there is no need for the previous restrictions in the expression evaluator. gdb/ChangeLog: * dwarf2/expr.c (dwarf_expr_context::execute_stack_op): Remove the use of dwarf_expr_require_composition. --- gdb/dwarf2/expr.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/gdb/dwarf2/expr.c b/gdb/dwarf2/expr.c index 977ac64dd68..871f52acfd8 100644 --- a/gdb/dwarf2/expr.c +++ b/gdb/dwarf2/expr.c @@ -3071,7 +3071,6 @@ dwarf_expr_context::execute_stack_op (const gdb_byte *op_ptr, case DW_OP_reg29: case DW_OP_reg30: case DW_OP_reg31: - dwarf_expr_require_composition (op_ptr, op_end, "DW_OP_reg"); ensure_have_frame (this->frame, "DW_OP_reg"); result = op - DW_OP_reg0; @@ -3081,7 +3080,6 @@ dwarf_expr_context::execute_stack_op (const gdb_byte *op_ptr, case DW_OP_regx: op_ptr = safe_read_uleb128 (op_ptr, op_end, ®); - dwarf_expr_require_composition (op_ptr, op_end, "DW_OP_regx"); ensure_have_frame (this->frame, "DW_OP_regx"); result = reg; @@ -3099,8 +3097,6 @@ dwarf_expr_context::execute_stack_op (const gdb_byte *op_ptr, = std::make_shared (this->gdbarch, op_ptr, len, BFD_ENDIAN_UNKNOWN); op_ptr += len; - dwarf_expr_require_composition (op_ptr, op_end, - "DW_OP_implicit_value"); } break; @@ -3116,9 +3112,6 @@ dwarf_expr_context::execute_stack_op (const gdb_byte *op_ptr, value->get_contents (), TYPE_LENGTH (type), type_byte_order (type)); - - dwarf_expr_require_composition (op_ptr, op_end, - "DW_OP_stack_value"); } break; @@ -3143,8 +3136,6 @@ dwarf_expr_context::execute_stack_op (const gdb_byte *op_ptr, this->per_cu, this->addr_size, die_offset, len); - dwarf_expr_require_composition (op_ptr, op_end, - "DW_OP_implicit_pointer"); } break; -- 2.17.1