From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 5a/5C1/+PGA3JAAAWB0awg (envelope-from ) for ; Mon, 01 Mar 2021 09:46:55 -0500 Received: by simark.ca (Postfix, from userid 112) id DCB771EF64; Mon, 1 Mar 2021 09:46:54 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4135D1EF64 for ; Mon, 1 Mar 2021 09:46:51 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 998603939C0C; Mon, 1 Mar 2021 14:46:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 998603939C0C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1614610010; bh=IkFi2UqReA2HCLOYrHC+YrWmbzDnSH5Re5ajjmV8fqY=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=LNKvWFEPZD0nm08Ysrcg/iK2wvUAdX31+Z242JoQnbUwefDDNlp6m3UPYBmgYgqFO NhzaS+/WzBXp/pzxtLF5BQFw/vB5xC5NwiTlmE5+8RZ1Ws75NN6PJRcXcoay4dl/MS xL1wb+Y432DQkRepn8+/69KaZAdzDCzQtWbN4Ixk= Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2040.outbound.protection.outlook.com [40.107.236.40]) by sourceware.org (Postfix) with ESMTPS id E3FCC3938396 for ; Mon, 1 Mar 2021 14:46:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E3FCC3938396 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Sat60/qyH8ew1Bx6TWCMPmAcM39/RD+StwU02eUrLABvxblX1KJigoBnZ5OIXvgNnySeVUcXni8QysMF5+jUw52KJj6Rk6d39sylXBUV+Veadzw11zl9WQUUvvH5tPB+d6lMrJO+XpodufgVLZvzl12dgXBzAg7yf7wzhXziYyn5WSdB7pxCaohxa0pMTzcsv1GJrkrFyAew2W9i4jSFOeLxy1/pHWESjfLb6OkeZepqkVycDYsFwps5pMMcwGZPjCBz7YTWQTcQbhLW21aXGuhiFnXs5LuvxsqEqgT2Iy/eE2SXUtmBAUUqjGqbCnLFhTFt5Ukbf7VK25HXL6REuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IkFi2UqReA2HCLOYrHC+YrWmbzDnSH5Re5ajjmV8fqY=; b=ULtQN/jMRUzTIP661VmXgL7oJveuO//+tVngp9f0xhBb4HP+xcXZds69KSDpUO2sPBocaPH6DMtt1zIJW/nfQT5wsxJqj/WfknnElCilt7PgoNm3bRh9zCw9eFBJpyOKTuixOhUboy1yayUQrnS3w+O6EcxKy7eAYQFi/HRJqIoNJJhX4QwO/ZCzrYpQSkDb/bmXrf9bvzmMAih3yl0QCiBKlySjo5u7vg6DL11kMqtip9TZdy+F5fGQR5FPVgWgX/fNi60KjeQNCdffJJHQSEkw1skn0bRj3WokUTogT/m/PdFQyFE0UeTPr7BX39PvpV043sZZ5ZZXhZbSnFrQtw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from DM6PR12MB2762.namprd12.prod.outlook.com (2603:10b6:5:45::15) by DM5PR1201MB0236.namprd12.prod.outlook.com (2603:10b6:4:57::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.28; Mon, 1 Mar 2021 14:46:41 +0000 Received: from DM6PR12MB2762.namprd12.prod.outlook.com ([fe80::31d8:f503:f7b2:f44]) by DM6PR12MB2762.namprd12.prod.outlook.com ([fe80::31d8:f503:f7b2:f44%3]) with mapi id 15.20.3868.033; Mon, 1 Mar 2021 14:46:40 +0000 To: gdb-patches@sourceware.org Subject: [PATCH 02/43] Cleanup of the dwarf_expr_context constructor Date: Mon, 1 Mar 2021 14:45:39 +0000 Message-Id: <20210301144620.103016-3-Zoran.Zaric@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210301144620.103016-1-Zoran.Zaric@amd.com> References: <20210301144620.103016-1-Zoran.Zaric@amd.com> Content-Type: text/plain X-Originating-IP: [2a00:23c7:5a85:6801:b4ed:fe7b:8064:d4d] X-ClientProxiedBy: AM0PR04CA0073.eurprd04.prod.outlook.com (2603:10a6:208:be::14) To DM6PR12MB2762.namprd12.prod.outlook.com (2603:10b6:5:45::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost.localdomain (2a00:23c7:5a85:6801:b4ed:fe7b:8064:d4d) by AM0PR04CA0073.eurprd04.prod.outlook.com (2603:10a6:208:be::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.19 via Frontend Transport; Mon, 1 Mar 2021 14:46:40 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 576aa457-c75b-4d54-bd4e-08d8dcc0d32a X-MS-TrafficTypeDiagnostic: DM5PR1201MB0236: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: U3T7LrmNFjL1IJLUewYQPhojNhl9X4bcKQtqSYyFD1L+/bSMG+ZvTYMWObAopcNPuCWViCTZuzPJOj+WWZT+i923pFx28npzlHSDXShuO65QIKIzN4q9mRWHabgpyicaktsbNG9vP8uoF9HiePcKLSAbnOTGtp2XUnDaNo6l/fLkZe7PvfzmX7YvEOoLZ76iKiH4GJJs0q6I31fX5O+QAHs1B6R5IqB6I1Y1nNhpWuycUCR4ghPMvp5uTzurLxQuT4AILLhI2+p2RPDGFakRim09SCExwTXpzETAEodqkN5bJr2InMb1Z9EIq1kGmUDxUSIOtFlMZDuDpMVyFIUM2Z5RaH71aP6VzgAn5YnanQrR91/HKkVRyIbAhwy1CVMrYxvbAZ9E6QM9PfvTsxjYvUGwK7aUdUai+39nlmSMHuG6Pn57pIiuefe/pnNUWYJOQ5dJLGoZE8frOC288uKVTdwkI03ULqxPd3OsmPz9sZN+5ZwAuSrOEP11WBPSDxiT0hXsIo7qQibnGOCJvzwifY8NKkeK75YYdXq87jA6ibrfk88SjWOfbr6am4T2gZwKn3lG6r8BdgDTIZYvYIsl1A== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2762.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(366004)(136003)(39860400002)(396003)(346002)(5660300002)(16526019)(1076003)(8936002)(52116002)(478600001)(83380400001)(2906002)(6486002)(66476007)(6916009)(86362001)(4326008)(2616005)(316002)(66946007)(8676002)(6506007)(36756003)(66556008)(6512007)(69590400012)(186003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?Dzl+3/VsAPszRBlp6AYieEJRT7w5QVumwgBk9vuycJFKJHTaC321JFtRU73c?= =?us-ascii?Q?jahq6OZeYtB/b6MqFiS9O/HRvN00jlyMm1892J65WQdpmazUZjn+W1OqF+h8?= =?us-ascii?Q?LsWQuavzJ4chMLfibvJgC1fvfesaddz5Vzgc6pPL2UVCcdL2mJMpLsvMYffs?= =?us-ascii?Q?BvyFDc2zmsWcj0xjHnDfOpy4HoSssEDevup1o0AOVz2UDjyj26CLdgo9hcax?= =?us-ascii?Q?ZMTBuSlkDSNTej9/GxRVJtKIVCd29a/0DUkeEg3XoVZ7Qo9mXmW+9n2ddQ4M?= =?us-ascii?Q?3/+9cMsOUoWGHcOCFViMnE+IZfhu9Kl1ezw2i8/HQ68RO05lqfqzjrKx271n?= =?us-ascii?Q?Ax4IxeG1IuZm91C9uCt4ev1zkNSzJ8HMF691q7OvydxM4banpDKYld0EJis6?= =?us-ascii?Q?sM9+3w57giAXuU39VFgJxbI/htg42r8m5n0Fiq8Yz6TqoYmhFwdFsCVyuY4o?= =?us-ascii?Q?8TcfHpVvGYGjQ3WWhaZBYEiEdqesGonxu7CtAhf0TBRAxbqkHq5ppkFqxiKQ?= =?us-ascii?Q?QnqO3LTPhU80ipGpe/vZVvlXE9y4mze12qIaCeW7SVrmkIoIJqRotrWO/irp?= =?us-ascii?Q?FfY1hDWcIcgI21Yyk2uCCUFxSYWPVpl9LEODeCmEQZDZDyFvEWMn3u2lc2kr?= =?us-ascii?Q?LWX0wAzMLzMk5JjcnWhiN7bOCcLFLH/bLkrQX5GdVkGbS+3tNPgdFo3xHzrm?= =?us-ascii?Q?LhmY/41auE6XSX8HSm51nrrFjLWgGY0SpJIyvXPoJLIXOgPLwY9w/lm+BKpg?= =?us-ascii?Q?5ORKM10cbD4YYmxk427lPlWeh4108ieu3zZy/2Xag9cY3ZUnPZ+Q80qSCf+9?= =?us-ascii?Q?E90e9FkwxrZ5rCc3vLhCY+IiqFG6J2qWAKHFIRrEf0ektro7moDKovmroo8h?= =?us-ascii?Q?uLp9+tWOYhpMwMLCZsD6fmEhxaYii50NqComujLbjm1DKjpy6B4n4HlL0egM?= =?us-ascii?Q?ByNAmy3vd8viFEX0hUvWaWVMOwmg58u9Q3yxUZOq8YZUsn1xRkEA2FHvDDgr?= =?us-ascii?Q?i2dYXMj5Mn/B1Oa6FFW5llcMeBiE57MDluczGx0VDnemnqcD+m+7K2RqGEVl?= =?us-ascii?Q?qpViVR/ZUPy0ApCKOG18PgMU+0aeOC7mTBzQP6O5auPORMSey7o6ggWKqlmf?= =?us-ascii?Q?L5lDyib0Sj3SuizScBu8m62NAKbtCXwHLqjRkZQk+uJJy5D4wFk9oQoHH5+/?= =?us-ascii?Q?66Nre4ZZQ2SrSytvsrq2xUtl/lEprCZjmmmL4KgQiotdGoSp7NRqPxTt4Zbs?= =?us-ascii?Q?xOTYHDNgaI1C8SOloBv5BDjVDtQ1lHnr6t6Qq3cyhI7D3uZnsKKoAidy0sVX?= =?us-ascii?Q?Kvl79uMiJ9nUt3fd3+VJ1Upi57OcADYNpcqnWPJWJ/aNQkRy1Quc5s5vhJnk?= =?us-ascii?Q?XM4lrTx9zWh0O0Ke/6Ee6mCeIn9I?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 576aa457-c75b-4d54-bd4e-08d8dcc0d32a X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2762.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2021 14:46:40.8809 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ViPqb3BHydIew+g2qJdt9Kr7nsc++/NpMSxCFuDNFI9fHuq2eNP3Xw8W5dNDePTn1YXBm81gDTwgL4eDrVL+3Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1201MB0236 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Zoran Zaric via Gdb-patches Reply-To: Zoran Zaric Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Move the initial values for dwarf_expr_context class data members to the class declaration in expr.h. gdb/ChangeLog: * dwarf2/expr.c (dwarf_expr_context::dwarf_expr_context): Remove initial data members values. * dwarf2/expr.h (dwarf_expr_context): Add initial values to the class data members. --- gdb/dwarf2/expr.c | 11 +---------- gdb/dwarf2/expr.h | 16 ++++++++-------- 2 files changed, 9 insertions(+), 18 deletions(-) diff --git a/gdb/dwarf2/expr.c b/gdb/dwarf2/expr.c index 107b9cdbd5d..aa166b22d9c 100644 --- a/gdb/dwarf2/expr.c +++ b/gdb/dwarf2/expr.c @@ -90,16 +90,7 @@ dwarf_expr_context::address_type () const /* Create a new context for the expression evaluator. */ dwarf_expr_context::dwarf_expr_context (dwarf2_per_objfile *per_objfile) -: gdbarch (NULL), - addr_size (0), - ref_addr_size (0), - recursion_depth (0), - max_recursion_depth (0x100), - location (DWARF_VALUE_MEMORY), - len (0), - data (NULL), - initialized (0), - per_objfile (per_objfile) +: per_objfile (per_objfile) { } diff --git a/gdb/dwarf2/expr.h b/gdb/dwarf2/expr.h index b28a0775602..fc31be31a4d 100644 --- a/gdb/dwarf2/expr.h +++ b/gdb/dwarf2/expr.h @@ -132,32 +132,32 @@ struct dwarf_expr_context std::vector stack; /* Target architecture to use for address operations. */ - struct gdbarch *gdbarch; + struct gdbarch *gdbarch = nullptr; /* Target address size in bytes. */ - int addr_size; + int addr_size = 0; /* DW_FORM_ref_addr size in bytes. If -1 DWARF is executed from a frame context and operations depending on DW_FORM_ref_addr are not allowed. */ - int ref_addr_size; + int ref_addr_size = 0; /* The current depth of dwarf expression recursion, via DW_OP_call*, DW_OP_fbreg, DW_OP_push_object_address, etc., and the maximum depth we'll tolerate before raising an error. */ - int recursion_depth, max_recursion_depth; + int recursion_depth = 0, max_recursion_depth = 0x100; /* Location of the value. */ - enum dwarf_value_location location; + enum dwarf_value_location location = DWARF_VALUE_MEMORY; /* For DWARF_VALUE_LITERAL, the current literal value's length and data. For DWARF_VALUE_IMPLICIT_POINTER, LEN is the offset of the target DIE of sect_offset kind. */ - ULONGEST len; - const gdb_byte *data; + ULONGEST len = 0; + const gdb_byte *data = nullptr; /* Initialization status of variable: Non-zero if variable has been initialized; zero otherwise. */ - int initialized; + int initialized = 0; /* A vector of pieces. -- 2.17.1