From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id aJWOKGX+PGA3JAAAWB0awg (envelope-from ) for ; Mon, 01 Mar 2021 09:47:01 -0500 Received: by simark.ca (Postfix, from userid 112) id 9F20F1EF7E; Mon, 1 Mar 2021 09:47:01 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6C90E1E590 for ; Mon, 1 Mar 2021 09:46:56 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0EAD73939C08; Mon, 1 Mar 2021 14:46:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0EAD73939C08 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1614610016; bh=TDkoqUlC0n7wmZQgxj9QXLocJzsD/XJJmjALjrflgG0=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=enA9KkSQHCQARcxLjOng0z2F730hhdg/4Qr3yeB54E1DDzIJDMUtYJFESRFcgKz6g wkbeS/9SzDEJWNawbvywinZTMX7kQ9z6uyeHFA2zV4gXmQUiypXJ2jB2PAwv65ccON BVyTRPnxCWne1AFR5OQDMT4WjUTrk8/43zdC3g9U= Received: from NAM04-BN3-obe.outbound.protection.outlook.com (mail-eopbgr680065.outbound.protection.outlook.com [40.107.68.65]) by sourceware.org (Postfix) with ESMTPS id C59D83939C22 for ; Mon, 1 Mar 2021 14:46:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C59D83939C22 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YBgd60LX06DYc2Pdwi7edRd60bfQOIl/25Km1bTkrnZJRRpEO9XyTAsB9bYq5r/WyhNRrSVGGe6Pe5cUdqvnGPEYfH42G7K1pFXfYZtFqNx+aQ3DY9LEJHdzx4xSKzHbW8gH90qAHCp8zkmVaW3z1dsZyYDfYm9CfTsjE70LWN1YdtSMLqTBfnKBpKUiZmLr3CMFCNYMb4TFIChTXZGC3HXAnNfxShJAVbW2P/TZkHrUwmTbml6TTkxr5uZuXkoK97Utl1hYvrSZmLuIJ+5BoDH1RyZaPrIQSsHmDN4bQk8GCejPiRauP5HHPwY0j8Rv8VXCy/YorP7Zke052qnudw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TDkoqUlC0n7wmZQgxj9QXLocJzsD/XJJmjALjrflgG0=; b=IasPHJJz561ipfJgy+qKonKUjz8B8utJm7Yt2T6aJExm6YX088apYA69efNt8ExyRchchnOmfS3sX7d8xu532NDzggPHiy7oCXxeU0atbCniPyGM84KnKQDsllovyn2E9JaCl4QWHfkJcCAdFJneWqHSGHbKiwjD1jvI0xe1RE9BQOzXRxICWeW+GuvudbJHHDeaDq7Tk09ofmHUCzgJ+aP0cLXBUH7DBhxP6HyRH5KCSv8SFgm/pfnJFV0QL0Q/2nMD8I+3vi2zgyEXZGpsD9Am3fsifWbkcA3F88XsaHwJsFzk0sQ8UCa35McJXUPCchW99h1NxT97Tutg1gEn/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from DM6PR12MB2762.namprd12.prod.outlook.com (2603:10b6:5:45::15) by DM5PR1201MB0041.namprd12.prod.outlook.com (2603:10b6:4:56::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.19; Mon, 1 Mar 2021 14:46:50 +0000 Received: from DM6PR12MB2762.namprd12.prod.outlook.com ([fe80::31d8:f503:f7b2:f44]) by DM6PR12MB2762.namprd12.prod.outlook.com ([fe80::31d8:f503:f7b2:f44%3]) with mapi id 15.20.3868.033; Mon, 1 Mar 2021 14:46:50 +0000 To: gdb-patches@sourceware.org Subject: [PATCH 10/43] Inline get_reg_value method of dwarf_expr_context Date: Mon, 1 Mar 2021 14:45:47 +0000 Message-Id: <20210301144620.103016-11-Zoran.Zaric@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210301144620.103016-1-Zoran.Zaric@amd.com> References: <20210301144620.103016-1-Zoran.Zaric@amd.com> Content-Type: text/plain X-Originating-IP: [2a00:23c7:5a85:6801:b4ed:fe7b:8064:d4d] X-ClientProxiedBy: AM0PR04CA0073.eurprd04.prod.outlook.com (2603:10a6:208:be::14) To DM6PR12MB2762.namprd12.prod.outlook.com (2603:10b6:5:45::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost.localdomain (2a00:23c7:5a85:6801:b4ed:fe7b:8064:d4d) by AM0PR04CA0073.eurprd04.prod.outlook.com (2603:10a6:208:be::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.19 via Frontend Transport; Mon, 1 Mar 2021 14:46:49 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: e4454ca5-7d06-40c3-7a57-08d8dcc0d8d5 X-MS-TrafficTypeDiagnostic: DM5PR1201MB0041: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wH616UaNf11Mol19Rl/IHNKhmM9mfxsCtTaMCDA0goOaMORVg8MGYFo/yLYC2Kvi9OHVKzgJnXjsdLii4vk3mjKGKrHjfBBINk5o8pzSSSMfK9ccBxSpm5+4iSWS6GsgKWd5IkKgPKOBHxMQhWSZZpW2h0rqvfMubmKboijqBEJp8VWhwEP03SSuKzQljafux/HuhOHWWh528x+XOqmdwsLv98QxbmQzxhJcrShdLwQsQkGoDr0opf8RZSTfEXdVpAZVVL0q/g2t1MUC2Czjr4ZuEXHMjXTIAerDp17jZgkOcq0jfaA0ksiKWLiiGb5+yJKCYE5YgYeuc71YdOyPCDBgEYqOITSOtfyK0CPLjEIs6XFhHFkdZQEcCvXULTNGYgpETOp0xQwYQZArZY+7N1r3qF6acbRbnLD5USwcRCimuKAO7oWGpmrfc77k269S8sUFm25AA/eG7Y7YdEORrGotDtl03En6XiXk7L0bCcNR4PYrHrsUBFXvsZkaX8zoAWtA2sTNxkyCIP+lIS67Uf90vAM9M1cekCMIXq+EOho+y3kVCvERaCbMO2wgEYBnTkG0fC+zujhcFQDPvHC3NQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2762.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(366004)(346002)(136003)(396003)(39860400002)(478600001)(83380400001)(52116002)(66476007)(66556008)(36756003)(69590400012)(6506007)(66946007)(8676002)(1076003)(5660300002)(316002)(6486002)(186003)(2906002)(8936002)(6512007)(4326008)(2616005)(16526019)(6916009)(86362001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?VJvd2gu+lWzg6C3hwyG5ZZBOJrIg1kL6QGyI9KrQfoAbTDxPjHIRLWw+ozHb?= =?us-ascii?Q?ePUTeeAY6yBVUiCJNWwlt0TXBxnnhfuYCmNh4JJ7Yg5M7o86Irs1cfRgGptB?= =?us-ascii?Q?bxR8tyj3a0cDZLkyM9BRuca1UTVG6sLU1UUH0PMp/atfY3B6QB4aWiZO+nj2?= =?us-ascii?Q?u941DMcmvEhfoouHR/Ahwj4icGPV4lzmV8wMnDQ9zIY73L+JK3zD4s+odsRk?= =?us-ascii?Q?k0DJ/ktOqRAoJ4U468PSE6W5z6f4vg89NTfLhRcqj89WfqjiMPx8hYaTERPG?= =?us-ascii?Q?bhkkFlONcxo9WvSLAwhMR/Z7hV9cWOCz6soZBjfqwIGF6krTX4BTnD7DomCo?= =?us-ascii?Q?3nc1ZAlWkhKkNmHC7XQUElkIoreQx3xc44ujyBhtwJsArfiz1/HvFjVYMn1/?= =?us-ascii?Q?juMAcWX6671hwo3VhfU+tXcRwz5fZWQ0d7hpphQCEKCpXuYFipnU0G9T32c+?= =?us-ascii?Q?2aGGOEV5EYglT6tW8bTQ+62ygZIXMk6PieMWx2+UG4R7w9yazFMmAJjnmUJf?= =?us-ascii?Q?b8DVOZoNMsHTAQxNFXjm8LPzKuzpC2qoM71/A9hQUa/oDF2Qej9OCBxQk2DL?= =?us-ascii?Q?zfiacPnhe46jV/nLlTHxFrdOtWjCZgUVJKnaLfgPAkzp7I2gREdRLNSpVG9Y?= =?us-ascii?Q?+KSHOk8ExVPCjMlu3WuRn7ARDjOoUslte/i9SqTYbBOJwGVgiP9DWxeLMJA0?= =?us-ascii?Q?mJWjZU1EIa7Rq2KLxjS7+nNeUWawA0Kr2LyFBl4nalQKhiqv26ffKOsmiMrY?= =?us-ascii?Q?xb1BQ9JHdpnNFB2jPG5V1LLMrSNc2yBWtDSLj8aGXeOfCpxdj4ldfHVjZrjB?= =?us-ascii?Q?GRvvY1wlT+MnOUF6clA7idh7acN17egoAWbJGYw14k69iYcyZghmebhgHLLG?= =?us-ascii?Q?hOMkq/f/YUo4kMB7ffdcow7XcQNizbAtanCakXiQrSP8+6lxhxwR+M4LZANe?= =?us-ascii?Q?THa/oOR4pwuHJiUHnQ1DHXyEw/L2+qqBsK+kbevHYUgCOVIeA0kJArkZaHt8?= =?us-ascii?Q?u/OMcM0socj0pvgaaKGML3f8uu72zGLvOf8sls5TBvfP+1FLLhM90eHzL8oh?= =?us-ascii?Q?/M8WPc6oxgMJHZOhc+c31GnGiZ49DLbqPdXNRUyF4YoFsHqJn8fJXX58r5y9?= =?us-ascii?Q?ycD7FP+zjjHC/cekmO1POGEHc1A1tEY25FCngPJSLFxzkOoHjnaTVZDSGucW?= =?us-ascii?Q?HmNqmkQqLtpClIo68bEhGi+bEalCnahAwM2ugXtATBoAoYCAoEouirlsq5Fk?= =?us-ascii?Q?75aezh/I6g9+FAp+IOl7WOUc7JP00lX7EAJxDn08OfjuCPeEsx12g4I1hcbm?= =?us-ascii?Q?EbX/0qTUWwQV5q2hIAPFaHRBJu3XJ+dgC45e2dPiWD+qRC5BqUQ51tQJX+3C?= =?us-ascii?Q?cGeq25QOaDx2qxJeDW7CMB7AGC6n?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: e4454ca5-7d06-40c3-7a57-08d8dcc0d8d5 X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2762.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2021 14:46:50.4714 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PZ4TeXU4Uu/m4GwaI5ioHdRalfGtbNppY0UPjrRCPYlnF0Sj0Ig/Yxp6JLXPc8DGhPLN45YWO5Q26CDa4THD0w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1201MB0041 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Zoran Zaric via Gdb-patches Reply-To: Zoran Zaric Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" The get_reg_value method is a small function that is only called once, so it can be inlined to simplify the dwarf_expr_context class. gdb/ChangeLog: * dwarf2/expr.c (dwarf_expr_context::get_reg_value): Remove method. (dwarf_expr_context::execute_stack_op): Inline get_reg_value method. * dwarf2/expr.h (dwarf_expr_context::get_reg_value): Remove method. --- gdb/dwarf2/expr.c | 24 +++++++----------------- gdb/dwarf2/expr.h | 6 ------ 2 files changed, 7 insertions(+), 23 deletions(-) diff --git a/gdb/dwarf2/expr.c b/gdb/dwarf2/expr.c index 0b7f3c90728..1212be9c984 100644 --- a/gdb/dwarf2/expr.c +++ b/gdb/dwarf2/expr.c @@ -176,19 +176,6 @@ dwarf_expr_context::fetch (int n) /* See expr.h. */ -struct value * -dwarf_expr_context::get_reg_value (struct type *type, int reg) -{ - ensure_have_frame (frame, "DW_OP_regval_type"); - - struct gdbarch *gdbarch = get_frame_arch (frame); - int regnum = dwarf_reg_to_regnum_or_error (gdbarch, reg); - - return value_from_register (type, regnum, frame); -} - -/* See expr.h. */ - void dwarf_expr_context::get_frame_base (const gdb_byte **start, size_t * length) @@ -1539,14 +1526,17 @@ dwarf_expr_context::execute_stack_op (const gdb_byte *op_ptr, case DW_OP_regval_type: case DW_OP_GNU_regval_type: { - struct type *type; - op_ptr = safe_read_uleb128 (op_ptr, op_end, ®); op_ptr = safe_read_uleb128 (op_ptr, op_end, &uoffset); cu_offset type_die_cu_off = (cu_offset) uoffset; - type = get_base_type (type_die_cu_off, 0); - result_val = this->get_reg_value (type, reg); + ensure_have_frame (this->frame, "DW_OP_regval_type"); + + struct type *type = get_base_type (type_die_cu_off, 0); + int regnum + = dwarf_reg_to_regnum_or_error (get_frame_arch (this->frame), + reg); + result_val = value_from_register (type, regnum, this->frame); } break; diff --git a/gdb/dwarf2/expr.h b/gdb/dwarf2/expr.h index 09fec0b871e..3faedebfb83 100644 --- a/gdb/dwarf2/expr.h +++ b/gdb/dwarf2/expr.h @@ -215,12 +215,6 @@ struct dwarf_expr_context void execute_stack_op (const gdb_byte *op_ptr, const gdb_byte *op_end); void pop (); - /* Return a value of type TYPE, stored in register number REGNUM - of the frame associated to the given BATON. - - REGNUM is a DWARF register number. */ - struct value *get_reg_value (struct type *type, int regnum); - /* Return the location expression for the frame base attribute, in START and LENGTH. The result must be live until the current expression evaluation is complete. */ -- 2.17.1