From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id +n14EXkpOGC+QAAAWB0awg (envelope-from ) for ; Thu, 25 Feb 2021 17:49:29 -0500 Received: by simark.ca (Postfix, from userid 112) id 38D411EF78; Thu, 25 Feb 2021 17:49:29 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_NONE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 71B971E590 for ; Thu, 25 Feb 2021 17:49:28 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AB4493857C61; Thu, 25 Feb 2021 22:49:27 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AB4493857C61 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1614293367; bh=Qz3R2kkZ43HeCsVgijEJU6bmv0C4yRFA+fl9yfMt2g8=; h=Date:To:Subject:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=dq778ORY+YS2gVgAxkN6Ti9xwpxtHwM65YDD2r+WV2KW/sduSRAigvPFfu+dFa2u1 0rDBc8u6bX5Uki6PzXKb+cyGbPDMNypjf47+2eN3QIpc6THTVmLpqrJAXjg5Btv1cB CuWWpX9+noVWCVn1x1fDFQeEfCupsuyyje0yNHLk= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id 191E83857C61 for ; Thu, 25 Feb 2021 22:49:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 191E83857C61 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-550-LRmG1ZWjNxyASUrOVfW9Eg-1; Thu, 25 Feb 2021 17:49:18 -0500 X-MC-Unique: LRmG1ZWjNxyASUrOVfW9Eg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A0C991856A83; Thu, 25 Feb 2021 22:49:17 +0000 (UTC) Received: from f33-m1.lan (ovpn-112-216.phx2.redhat.com [10.3.112.216]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6B8A210016F8; Thu, 25 Feb 2021 22:49:17 +0000 (UTC) Date: Thu, 25 Feb 2021 15:49:16 -0700 To: gdb-patches@sourceware.org Subject: Re: [pushed] Fix aarch64-linux-hw-point.c build problem Message-ID: <20210225154916.74a020e5@f33-m1.lan> In-Reply-To: References: <20210224195945.2135883-1-kevinb@redhat.com> <87ft1lyyrz.fsf@tromey.com> <20210224145223.6052f41d@f33-m1.lan> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Kevin Buettner via Gdb-patches Reply-To: Kevin Buettner Cc: Tom Tromey Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On Thu, 25 Feb 2021 00:22:52 +0100 Christian Biesinger wrote: > Since you said nat/aarch64-sve-linux-ptrace.h also includes these headers, > maybe add the comment there as well? Done... Add comment regarding include order of and I added the same comment for nat/aarch64-linux-hw-point.c yesterday. Christian suggested adding the comment for the other file that I had identified as including both and . I searched the sources in gdb/, but found no other files which include both of these headers. If possible, I would prefer to see us use when possible, however, from past experience, I've found that this file does not always contain all of the constants, etc. required by the particular source file. gdb/ChangeLog: * nat/aarch64-sve-linux-ptrace.h: Add comment regarding include order for and . diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 842dc0a1374..7e0b00cc7c6 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2021-02-24 Kevin Buettner + + * nat/aarch64-sve-linux-ptrace.h: Add comment regarding + include order for and . + 2021-02-25 Simon Marchi PR gdb/26861 diff --git a/gdb/nat/aarch64-sve-linux-ptrace.h b/gdb/nat/aarch64-sve-linux-ptrace.h index 06684023f5d..be00f306137 100644 --- a/gdb/nat/aarch64-sve-linux-ptrace.h +++ b/gdb/nat/aarch64-sve-linux-ptrace.h @@ -22,6 +22,12 @@ #include #include + +/* The order in which and are included + can be important. often declares various PTRACE_* + enums. often defines preprocessor constants for + these very same symbols. When that's the case, build errors will + result when is included before . */ #include #include