From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id a0mAEqDKNmAyIgAAWB0awg (envelope-from ) for ; Wed, 24 Feb 2021 16:52:32 -0500 Received: by simark.ca (Postfix, from userid 112) id 39BD31EF78; Wed, 24 Feb 2021 16:52:32 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_NONE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id DBB9C1EE0E for ; Wed, 24 Feb 2021 16:52:31 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 254E53835408; Wed, 24 Feb 2021 21:52:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 254E53835408 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1614203551; bh=1Ud8enPLA8L2zPVeQtFmWFBL+JTTCfhRTg6PxxADXbM=; h=Date:To:Subject:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=v1WqmyrmgqcaCUddqaB9YtK62FjEL9XBuJ7Dm1e1C3V5II5z4tF/BNYukDUvH8wFE rz9BPr9k3+OdGDN1Okudncj00CmTwNUE1612+Q5fS62FyiRIMS+kxYHxXdP6h6kCUc urwEMjG8wnQ29HNj+LdkCm0bFQtlU3wCC7qCrFy8= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id 4142B3835408 for ; Wed, 24 Feb 2021 21:52:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 4142B3835408 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-342-gj0252iHM_ahopFkjVcirQ-1; Wed, 24 Feb 2021 16:52:26 -0500 X-MC-Unique: gj0252iHM_ahopFkjVcirQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2EAB5814261; Wed, 24 Feb 2021 21:52:25 +0000 (UTC) Received: from f33-m1.lan (ovpn-112-216.phx2.redhat.com [10.3.112.216]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0D8CC63632; Wed, 24 Feb 2021 21:52:24 +0000 (UTC) Date: Wed, 24 Feb 2021 14:52:23 -0700 To: gdb-patches@sourceware.org Subject: Re: [pushed] Fix aarch64-linux-hw-point.c build problem Message-ID: <20210224145223.6052f41d@f33-m1.lan> In-Reply-To: <87ft1lyyrz.fsf@tromey.com> References: <20210224195945.2135883-1-kevinb@redhat.com> <87ft1lyyrz.fsf@tromey.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Kevin Buettner via Gdb-patches Reply-To: Kevin Buettner Cc: Tom Tromey Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On Wed, 24 Feb 2021 13:52:00 -0700 Tom Tromey wrote: > >>>>> "Kevin" == Kevin Buettner via Gdb-patches writes: > > Kevin> gdb/ChangeLog: > > Kevin> * nat/aarch64-linux-hw-point.c: Include after > Kevin> . > > This seems reasonable, but a comment saying that the order matters might > be helpful later on. Agreed. I've pushed the following (along with a suitable ChangeLog entry)... diff --git a/gdb/nat/aarch64-linux-hw-point.c b/gdb/nat/aarch64-linux-hw-point.c index 0278ac2bb28..af2cc4254e2 100644 --- a/gdb/nat/aarch64-linux-hw-point.c +++ b/gdb/nat/aarch64-linux-hw-point.c @@ -23,8 +23,15 @@ #include "aarch64-linux-hw-point.h" #include + +/* The order in which and are included + can be important. often declares various PTRACE_* + enums. often defines preprocessor constants for + these very same symbols. When that's the case, build errors will + result when is included before . */ #include #include + #include /* Number of hardware breakpoints/watchpoints the target supports.