From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4JIZEv+4I2CGAwAAWB0awg (envelope-from ) for ; Wed, 10 Feb 2021 05:44:15 -0500 Received: by simark.ca (Postfix, from userid 112) id 3C43C1EF4F; Wed, 10 Feb 2021 05:44:15 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.3 required=5.0 tests=MAILING_LIST_MULTI,RDNS_NONE, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D58D01E4A3 for ; Wed, 10 Feb 2021 05:44:14 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1C736389680B; Wed, 10 Feb 2021 10:44:14 +0000 (GMT) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id 36683389680B for ; Wed, 10 Feb 2021 10:44:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 36683389680B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tdevries@suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 5A4F5AD57 for ; Wed, 10 Feb 2021 10:44:11 +0000 (UTC) Date: Wed, 10 Feb 2021 11:44:09 +0100 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [committed][gdb/testsuite] Fix tcl ERROR in gdb_load_no_complaints Message-ID: <20210210104408.GA7223@delia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Hi, In commit cf2b2075299 "[gdb/symtab] Fix element type modification in read_array_type" I factored out new proc with_complaints out of proc gdb_load_no_complaints, but when fixing a rebase conflict pre-commit I made a mistake in gdb_load_no_complaints that is now causing: ... ERROR: tcl error sourcing dw2-ranges-psym.exp. ERROR: can't read "save": no such variable while executing "gdb_test_no_output "set complaints $save" """ (procedure "gdb_load_no_complaints" line 14) invoked from within "gdb_load_no_complaints $binfile" ... Fix this by removing the offending line. Tested on x86_64-linux. Committed to trunk. Thanks, - Tom [gdb/testsuite] Fix tcl ERROR in gdb_load_no_complaints gdb/testsuite/ChangeLog: 2021-02-10 Tom de Vries * lib/gdb.exp (gdb_load_no_complaints): Remove unnecessary "Restore saved setting of complaints". --- gdb/testsuite/lib/gdb.exp | 3 --- 1 file changed, 3 deletions(-) diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index 1406b917151..016c678237c 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -5149,9 +5149,6 @@ proc gdb_load_no_complaints { arg } { # Verify that there were no complaints. set re "^Reading symbols from \[^\r\n\]*\r\n$gdb_prompt $" gdb_assert {[regexp $re $gdb_file_cmd_msg]} "No complaints" - - # Restore saved setting of complaints. - gdb_test_no_output "set complaints $save" "" } # gdb_reload -- load a file into the target. Called before "running",