Re: new gdb build failures on MacOS X (... fallout from libintl fixups, see users/nalcock/included-gettext)

[Andrew Burgess <andrew.burgess@embecosm.com>]

* Nick Alcock <nick.alcock@oracle.com> [2021-02-04 20:35:23 +0000]:

> [gcc-patches Cc:ed for the elfcore failure, not so much for the iconv
>  stuff yet, since I'm revamping a lot of that stuff in bfd/opcodes/etc
>  and that should probably get looked at before the gdb side, I guess.
>  See the git branch referenced below.]
> 
> On 4 Feb 2021, Stephen Casner told this:
> 
> > On Thu, 4 Feb 2021, Nick Alcock wrote:
> >
> >> I've updated the users/nalcock/included-gettext branch on
> >> binutils-gdb.git with a new approach which is rather less gross than the
> >> horrible stuff I was doing before.
> >>
> >> It still seems to work for me: could you check to see if it still works
> >> for you?
> >
> > This version introduces two new undefined symbols in the gdb link:
> 
> Oh dammit.
> 
> > Undefined symbols for architecture x86_64:
> >   "_elfcore_write_prstatus", referenced from:
> >       gcore_collect_regset_section_cb(char const*, int, int, regset const*, char const*, void*) in gcore.o
> >   "_elfcore_write_register_note", referenced from:
> >       gcore_collect_regset_section_cb(char const*, int, int, regset const*, char const*, void*) in gcore.o
> 
> I think this may not be my fault but rather is unrelated fallout from
> commit 82a1fd3a4935fe665cf08bc6820942c4a091184c, which just landed.
> As of this commit, elfcore_write_register_note et al are unconditionally
> cited from gdb/gcore.c, but obviously these are only going to exist for
> ELF platforms, which MacOS X is not.

Sorry for causing this breakage.

I've now reverted commit 82a1fd3a4935 while I think of a better way to
make this change.

One thing that would be helpful is, do you know if there's a non-elf
targeting triple that I could configure GDB for that would allow me to
make sure I don't break this again?

Thanks,
Andrew