From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Z8FKKnTQImB/ZQAAWB0awg (envelope-from ) for ; Tue, 09 Feb 2021 13:12:04 -0500 Received: by simark.ca (Postfix, from userid 112) id 9B7291EF4F; Tue, 9 Feb 2021 13:12:04 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5EB8A1E54D for ; Tue, 9 Feb 2021 13:12:03 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8D7D2385800D; Tue, 9 Feb 2021 18:12:02 +0000 (GMT) Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153]) by sourceware.org (Postfix) with ESMTPS id 231CD385800D for ; Tue, 9 Feb 2021 18:12:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 231CD385800D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=abid_qadeer@mentor.com IronPort-SDR: OFaGKmyuN8+zYdx6TJFJ0IO7Nhyma4obaSvXSgzMP5oWHONwhBETpfO7mNAEhhuCeBQnVA675d 5Cv4866EUazmsiovggjHGSViAlSXIsKoAEmKCze0iydLZnzvrzzJzEvyuRX+gP7y3hz/sMQx3f bx1dEnlVMTIKm/QSC3JBkDy8hKWeC62b5W4Hsd5HEtM3riSBoWGBSAwMIVmBVY/X3ZkXMI/gs7 ynzkRdcYgFOngFSbC5GlM+eDiQ2ceYfuO1T0WQfe26Xq87Li2zufaiIHDOQrNnCN4tFS2yT+w9 Zrs= X-IronPort-AV: E=Sophos;i="5.81,165,1610438400"; d="scan'208";a="60237046" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa1.mentor.iphmx.com with ESMTP; 09 Feb 2021 10:11:58 -0800 IronPort-SDR: JdelrOSp3OKSDdk2b0bcqbmY347zsig8ODpwlU7ya1bD8S9bkeF6cUr8h1vrihtfpmXWFi3R1E rcLTPf8BvN1GuTqBvW2mcH05OJGY61CZ8NdkH+pVnj4q8Q4dn7JYtOOEhiH++0vTwKIGqErHEy JU0mSg2l63tAKFI4dtcMx9KQmu9cf4zzWditoHcro1lSEkbtQx9DFDDFvptpJ4gvsUCpew/CEK sV1w7C37Xo21jbM8TPtZK/zvtIHb6dDKqlB24Z41cwKQchgbAIh4PwqSgYEiqbCLaqktJwckM6 RAQ= From: Hafiz Abid Qadeer To: Subject: [PATCH] [testsuite] Don't use 'testfile' before 'standard_testfile'. Date: Tue, 9 Feb 2021 18:11:48 +0000 Message-ID: <20210209181148.2714175-1-abidh@codesourcery.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-08.mgc.mentorg.com (139.181.222.8) To SVR-IES-MBX-03.mgc.mentorg.com (139.181.222.3) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" While running tests on arm-none-eabi, I noticed following errors in some gdb.threads tests. ERROR: can't read "testfile": no such variable These were being caused by ${testfile} being used before 'standard_testfile' which sets it. This patch just moves standard_testfile before the use. 2021-02-09 Abid Qadeer gdb/testsuite/ChangeLog: * gdb.threads/signal-command-handle-nopass.exp: Call 'standard_testfile' before using 'testfile'. * gdb.threads/signal-command-multiple-signals-pending.exp: Likewise. * gdb.threads/signal-delivered-right-thread.exp: Likewise * gdb.threads/signal-sigtrap.exp: Likewise --- gdb/testsuite/gdb.threads/signal-command-handle-nopass.exp | 4 ++-- .../gdb.threads/signal-command-multiple-signals-pending.exp | 4 ++-- gdb/testsuite/gdb.threads/signal-delivered-right-thread.exp | 4 ++-- gdb/testsuite/gdb.threads/signal-sigtrap.exp | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/gdb/testsuite/gdb.threads/signal-command-handle-nopass.exp b/gdb/testsuite/gdb.threads/signal-command-handle-nopass.exp index d0ef5256a84..bef125c8ab4 100644 --- a/gdb/testsuite/gdb.threads/signal-command-handle-nopass.exp +++ b/gdb/testsuite/gdb.threads/signal-command-handle-nopass.exp @@ -18,13 +18,13 @@ # delivered to the right thread, even if GDB has to step over a # breakpoint in some other thread first. +standard_testfile + if [target_info exists gdb,nosignals] { verbose "Skipping ${testfile}.exp because of nosignals." return -1 } -standard_testfile - if {[gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" \ executable { debug }] != "" } { return -1 diff --git a/gdb/testsuite/gdb.threads/signal-command-multiple-signals-pending.exp b/gdb/testsuite/gdb.threads/signal-command-multiple-signals-pending.exp index d8f6f946e0e..2d4417c6506 100644 --- a/gdb/testsuite/gdb.threads/signal-command-multiple-signals-pending.exp +++ b/gdb/testsuite/gdb.threads/signal-command-multiple-signals-pending.exp @@ -16,13 +16,13 @@ # Test that "signal FOO" behaves correctly when we have multiple # threads that have stopped for a signal. +standard_testfile + if [target_info exists gdb,nosignals] { verbose "Skipping ${testfile}.exp because of nosignals." return -1 } -standard_testfile - if {[gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" \ executable { debug }] != "" } { return -1 diff --git a/gdb/testsuite/gdb.threads/signal-delivered-right-thread.exp b/gdb/testsuite/gdb.threads/signal-delivered-right-thread.exp index 6ee899b34eb..c635facca2d 100644 --- a/gdb/testsuite/gdb.threads/signal-delivered-right-thread.exp +++ b/gdb/testsuite/gdb.threads/signal-delivered-right-thread.exp @@ -13,13 +13,13 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see . */ +standard_testfile + if [target_info exists gdb,nosignals] { verbose "Skipping ${testfile}.exp because of nosignals." return -1 } -standard_testfile - if {[gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" \ executable { debug }] != "" } { return -1 diff --git a/gdb/testsuite/gdb.threads/signal-sigtrap.exp b/gdb/testsuite/gdb.threads/signal-sigtrap.exp index 458bf8acd90..92488a50ac1 100644 --- a/gdb/testsuite/gdb.threads/signal-sigtrap.exp +++ b/gdb/testsuite/gdb.threads/signal-sigtrap.exp @@ -16,13 +16,13 @@ # Check that GDB doesn't forget to pass SIGTRAP to the program when # the user explicitly passes it with the signal command. +standard_testfile + if [target_info exists gdb,nosignals] { verbose "Skipping ${testfile}.exp because of nosignals." return -1 } -standard_testfile - if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug pthreads}]} { return -1 } -- 2.25.1