From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id aLMxDcgTGGAeCgAAWB0awg (envelope-from ) for ; Mon, 01 Feb 2021 09:44:24 -0500 Received: by simark.ca (Postfix, from userid 112) id 330411EF80; Mon, 1 Feb 2021 09:44:24 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.4 required=5.0 tests=DKIM_SIGNED,MAILING_LIST_MULTI, RDNS_NONE,T_DKIM_INVALID,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A80B71E939 for ; Mon, 1 Feb 2021 09:44:23 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5767C3875411; Mon, 1 Feb 2021 14:44:23 +0000 (GMT) Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by sourceware.org (Postfix) with ESMTPS id B4E4E386188D for ; Mon, 1 Feb 2021 14:44:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B4E4E386188D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=andrew.burgess@embecosm.com Received: by mail-wr1-x42f.google.com with SMTP id a1so16865541wrq.6 for ; Mon, 01 Feb 2021 06:44:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=yRMUG68+3aNJMt5bdKNEvg8rLOFEtBp6Ib1npE+lw4c=; b=YvDQ88AzGhNooRVdmutLaoB33i97rNsHQVbi02VXn4p1dxmrsLvGEQhze2jWZTRaFp 1aSt9cOsUA/f/mYTz29c1dhkkCG01tuCkRfqzcqxKV/xSypFdA1jdU955+6T1ev+At2X JSzluB8GhzTj6wGI3fesgm1bKP3A0cDv8SrZ654Op0WIyq3NApaZij9Jbt/r9emkiU5M h3AlR31ggp5NgYMZNWU/J134ovDuH3+kDSxPuGdTNb9O6nMB5qoUf+gzeFrjH3I14BMH 6yUf/8ASJKn9hwVIF1mzYWNLowtBB7pNzDUnP2defBPVFVfuoYrMhXcBwBeGk37V2YlR jrxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=yRMUG68+3aNJMt5bdKNEvg8rLOFEtBp6Ib1npE+lw4c=; b=S5Z6SRwu7MoklIyAyzJZO5+jcnOiRxDpa1x3/pMGS3uT0JR5yGQYtujuXLFNxjJO6V yxJUcjBSZ2yejbqo3yVU4b62bYHY815hMt2T56EuiGlMWYt7rf2KlTgo3HtdcHIEXv1T fBg/M+1g/AmweVoYeRGTSuGwQeIe9JvGX0ggn7hDblIkKkSnca0a7H8spBUkYGds+Cof szJCQzYNooHiF+brCAjFD5xZsJ9jYawBlRY2pYZaHX4cP7F1Qbo9Lo/xKSVWVTSMt/4r EnHZ87Van0EJAvAxoBQzWXC0fO5jOW+EvsC5ehRkTtoEcYbWKesZG88wVBQtCkatpYDF /vOg== X-Gm-Message-State: AOAM530afK5FWKdQ9j9xfVTvxz1HPoprwMXwu/gmDn1NDWyZISala0HI T846GshpjcKLk/3yo2ulyJCAe+4xZec1Ew== X-Google-Smtp-Source: ABdhPJy+/Zr3sWOtXBYWA03OqUVqMr16bXTsdSPoDI6yji2NQCrxu3EvVfghPXMFzWuI+05UbTlBlQ== X-Received: by 2002:adf:f8c8:: with SMTP id f8mr18757247wrq.132.1612190658947; Mon, 01 Feb 2021 06:44:18 -0800 (PST) Received: from localhost (host86-191-239-31.range86-191.btcentralplus.com. [86.191.239.31]) by smtp.gmail.com with ESMTPSA id m18sm81794wmq.1.2021.02.01.06.44.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Feb 2021 06:44:18 -0800 (PST) Date: Mon, 1 Feb 2021 14:44:17 +0000 From: Andrew Burgess To: Luis Machado Subject: Re: [PATCHv2 4/9] bfd/riscv: prepare to handle bare metal core dump creation Message-ID: <20210201144417.GW265215@embecosm.com> References: <9379a3e1af978103cfa47e869594f0df91d807ea.1611172468.git.andrew.burgess@embecosm.com> <39d197ae-ecdb-976c-c7ae-40628fa61e12@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <39d197ae-ecdb-976c-c7ae-40628fa61e12@linaro.org> X-Operating-System: Linux/5.8.13-100.fc31.x86_64 (x86_64) X-Uptime: 14:43:01 up 54 days, 19:27, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fredrik Hederstierna , binutils@sourceware.org, gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" * Luis Machado [2021-02-01 10:48:15 -0300]: > On 1/20/21 5:23 PM, Andrew Burgess wrote: > > When creating a core file GDB will call the function > > elfcore_write_prstatus to write out the general purpose registers > > along with the pid/tid for the thread. > > > > However, for a bare metal RISC-V tool chain the prstatus*_t types are > > not defined so the elfcore_write_prstatus function will return NULL, > > preventing core file creation. > > > > This commit provides the `elf_backend_write_core_note' hook and uses > > the provided function to write out the ptstatus information. > > ptstatus -> prstatus? Thanks for spotting this. On re-reading the commit message I realised it was actually lagging behind the patch a little, the patch now handles prstatus_t and prpsinfo_t. I fixed the typo you spotted, and updated the commit message. Thanks, Andrew --- commit 72e2e1f0e914c7018b7db41f0beb3736b3c37beb Author: Andrew Burgess Date: Mon Nov 30 12:14:38 2020 +0000 bfd/riscv: prepare to handle bare metal core dump creation When creating a core file GDB will call the function elfcore_write_prstatus to write out the general purpose registers along with the pid/tid for the thread (into a prstatus structure) and the executable name and arguments (into a prpsinfo_t structure). However, for a bare metal RISC-V tool chain the prstatus_t and prpsinfo_t types are not defined so the elfcore_write_prstatus function will return NULL, preventing core file creation. This commit provides the `elf_backend_write_core_note' hook and uses the provided function to write out the required information. In order to keep changes in the non bare metal tools to a minimum, the provided backend function will itself return NULL when the prstatus_t or pspsinfo_t types are available, the consequence of this is that the generic code in elfcore_write_prstatus will be used just as before. But, when prstatus_t or prpsinfo_t is not available, the new backend function will write out the information using predefined offsets. This new functionality will be used by a later GDB commit that will add bare metal core dumps for RISC-V. bfd/ChangeLog: * elfnn-riscv.c (riscv_write_core_note): New function. (elf_backend_write_core_note): Define. diff --git a/bfd/elfnn-riscv.c b/bfd/elfnn-riscv.c index b2ec6a29fbf..70a683b45a3 100644 --- a/bfd/elfnn-riscv.c +++ b/bfd/elfnn-riscv.c @@ -4886,6 +4886,77 @@ _bfd_riscv_relax_section (bfd *abfd, asection *sec, # define PRPSINFO_OFFSET_PR_PSARGS 56 #endif +/* Write PRSTATUS and PRPSINFO note into core file. This will be called + before the generic code in elf.c. By checking the compiler defines we + only perform any action here if the generic code would otherwise not be + able to help us. The intention is that bare metal core dumps (where the + prstatus_t and/or prpsinfo_t might not be available) will use this code, + while non bare metal tools will use the generic elf code. */ + +static char * +riscv_write_core_note (bfd *abfd ATTRIBUTE_UNUSED, + char *buf ATTRIBUTE_UNUSED, + int *bufsiz ATTRIBUTE_UNUSED, + int note_type ATTRIBUTE_UNUSED, ...) +{ + switch (note_type) + { + default: + return NULL; + +#if !defined (HAVE_PRPSINFO_T) + case NT_PRPSINFO: + { + char data[PRPSINFO_SIZE] ATTRIBUTE_NONSTRING; + va_list ap; + + va_start (ap, note_type); + memset (data, 0, sizeof (data)); + strncpy (data + PRPSINFO_OFFSET_PR_FNAME, va_arg (ap, const char *), 16); +#if GCC_VERSION == 8000 || GCC_VERSION == 8001 + DIAGNOSTIC_PUSH; + /* GCC 8.0 and 8.1 warn about 80 equals destination size with + -Wstringop-truncation: + https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85643 + */ + DIAGNOSTIC_IGNORE_STRINGOP_TRUNCATION; +#endif + strncpy (data + PRPSINFO_OFFSET_PR_PSARGS, va_arg (ap, const char *), 80); +#if GCC_VERSION == 8000 || GCC_VERSION == 8001 + DIAGNOSTIC_POP; +#endif + va_end (ap); + return elfcore_write_note (abfd, buf, bufsiz, + "CORE", note_type, data, sizeof (data)); + } +#endif /* !HAVE_PRPSINFO_T */ + +#if !defined (HAVE_PRSTATUS_T) + case NT_PRSTATUS: + { + char data[PRSTATUS_SIZE]; + va_list ap; + long pid; + int cursig; + const void *greg; + + va_start (ap, note_type); + memset (data, 0, sizeof(data)); + pid = va_arg (ap, long); + bfd_put_32 (abfd, pid, data + PRSTATUS_OFFSET_PR_PID); + cursig = va_arg (ap, int); + bfd_put_16 (abfd, cursig, data + PRSTATUS_OFFSET_PR_CURSIG); + greg = va_arg (ap, const void *); + memcpy (data + PRSTATUS_OFFSET_PR_REG, greg, + PRSTATUS_SIZE - PRSTATUS_OFFSET_PR_REG - ARCH_SIZE / 8); + va_end (ap); + return elfcore_write_note (abfd, buf, bufsiz, + "CORE", note_type, data, sizeof (data)); + } +#endif /* !HAVE_PRSTATUS_T */ + } +} + /* Support for core dump NOTE sections. */ static bfd_boolean @@ -5000,6 +5071,7 @@ riscv_elf_obj_attrs_arg_type (int tag) #define elf_backend_grok_prstatus riscv_elf_grok_prstatus #define elf_backend_grok_psinfo riscv_elf_grok_psinfo #define elf_backend_object_p riscv_elf_object_p +#define elf_backend_write_core_note riscv_write_core_note #define elf_info_to_howto_rel NULL #define elf_info_to_howto riscv_info_to_howto_rela #define bfd_elfNN_bfd_relax_section _bfd_riscv_relax_section