From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 3JksB5DuF2ClBQAAWB0awg (envelope-from ) for ; Mon, 01 Feb 2021 07:05:36 -0500 Received: by simark.ca (Postfix, from userid 112) id 10D421EF80; Mon, 1 Feb 2021 07:05:36 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_NONE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A3D661E590 for ; Mon, 1 Feb 2021 07:05:34 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0C8D03836C09; Mon, 1 Feb 2021 12:05:34 +0000 (GMT) Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by sourceware.org (Postfix) with ESMTPS id 254D13836C5F for ; Mon, 1 Feb 2021 12:05:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 254D13836C5F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=andrew.burgess@embecosm.com Received: by mail-wr1-x431.google.com with SMTP id d16so16254123wro.11 for ; Mon, 01 Feb 2021 04:05:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=H1iei71+19ATKPn2nbrSvDgGITmg2khgRM2CCLM2pPY=; b=Kz8L2+5Lmcjm2VJ3md2zpfmQQq9LP2o5tBIuafjYiQvE51bYpqroyWZ7yoWwO9vSqa mKMmdftpWGxd4+KzFXu+nqJjQwXN9HG+TWJ5oFXP5Tm5Vj5zZ1poDpNgmHinqw8dVqxK jwD2TcZ9MjvuW50+IMwHvOS5lpcgQFKF+2m+YucGUSXFZm6wsUwNp3Rm+FdGtZa/xsnZ xJcJkhZFmr/9clBJdzsNZPRGDe8aap7JF8iJLi8DoOrcIPs7WKV4A/tLzXg0/xGx8GwZ G6h4QQfVY8P+nqzoa8hMbn8Lw2wJ96yTetPcbiWGRY43PM+ARjym48Dg+sxkNH6A6bvn rK4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=H1iei71+19ATKPn2nbrSvDgGITmg2khgRM2CCLM2pPY=; b=Kh8EKdVMhrIbsQQYoQO60zZG/wVBCOo2Pt4SWKIkBJmF42mO8NFX7ODHPzpakzpIb6 SEKk9+yQDPYqCu3XmbAhk6znAekkNoVSon9qzYQOWv0i19HQD+Imy/3n2Z23YDOWSJcB FGJNwHy+bW7rI9GMcwF4hr64jWfxTiNzYfOXX6HDpS9lm/+N3jtnYXDpvPlvUCAFrfFR xHRnziRArAKN0+joCHChB49jTklkrcoEUasxpBPCvHcu0T78k/Mp1peMrSfNz8s1+A/0 OKu8zlTS7xNA98blM5lYUs8c8ml4Q2uymM7atmzg/19YL6wd33BjxFC7JKw4hlubZS/J DKcg== X-Gm-Message-State: AOAM5301gwMwOA6BGvROMgKFiuVlMExFLSXsChWCZ1E+AQ3yPJxYcJNc XuaycU0oS66Zps5wHmil3mfvQlT2bIJKLw== X-Google-Smtp-Source: ABdhPJyB3wXjTyeXbm3ZTqf6YUjDciTuWiDYWMk7Ej6yaMCS5CkW/xnhnBzA7Y60o9FjZEXlEb496A== X-Received: by 2002:adf:f905:: with SMTP id b5mr17239456wrr.129.1612181123069; Mon, 01 Feb 2021 04:05:23 -0800 (PST) Received: from localhost (host86-191-239-31.range86-191.btcentralplus.com. [86.191.239.31]) by smtp.gmail.com with ESMTPSA id w4sm6928851wrt.69.2021.02.01.04.05.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Feb 2021 04:05:22 -0800 (PST) Date: Mon, 1 Feb 2021 12:05:21 +0000 From: Andrew Burgess To: gdb-patches@sourceware.org, binutils@sourceware.org Subject: PING: Re: [PATCHv2 2/9] bfd/binutils: support for gdb target descriptions in the core file Message-ID: <20210201120521.GV265215@embecosm.com> References: <5a9bb029efd1737d81d1e9ff0e82f359d4267113.1611172468.git.andrew.burgess@embecosm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5a9bb029efd1737d81d1e9ff0e82f359d4267113.1611172468.git.andrew.burgess@embecosm.com> X-Operating-System: Linux/5.8.13-100.fc31.x86_64 (x86_64) X-Uptime: 12:03:40 up 54 days, 16:48, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fredrik Hederstierna Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Ping! This patch needs a review from the binutils side please. I believe the conversation with Mihails was resolved and he is happy with this patch as it is. Thanks, Andrew * Andrew Burgess [2021-01-20 20:23:08 +0000]: > This commit lays the ground work for allowing GDB to write its target > description into a generated core file. > > The goal of this work is to allow a user to connect to a remote > target, capture a core file from within GDB, then pass the executable > and core file to another user and have the user be able to examine the > state of the machine without needing to connect to a running target. > > Different remote targets can have different register sets and this > information is communicated from the target to GDB in the target > description. > > It is possible for a user to extract the target description from GDB > and pass this along with the core file so that when the core file is > used the target description can be fed back into GDB, however this is > not a great user experience. > > It would be nicer, I think, if GDB could write the target description > directly into the core file, and then make use of this description > when loading a core file. > > This commit performs the binutils/bfd side of this task, adding the > boiler plate functions to access the target description from within a > core file note, and reserving a new number for a note containing the > target description. > > Later commits will extend GDB to make use of this. > > bfd/ChangeLog: > > * elf-bfd.h (elfcore_write_gdb_tdesc): Declare new function. > * elf.c (elfcore_grok_gdb_tdesc): New function. > (elfcore_grok_note): Handle NT_GDB_TDESC. > (elfcore_write_gdb_tdesc): New function. > (elfcore_write_register_note): Handle NT_GDB_TDESC. > > binutils/ChangeLog: > > * readelf.c (get_note_type): Handle NT_GDB_TDESC. > > include/ChangeLog: > > * elf/common.h (NT_GDB_TDESC): Define. > --- > bfd/ChangeLog | 9 +++++++++ > bfd/elf-bfd.h | 2 ++ > bfd/elf.c | 23 +++++++++++++++++++++++ > binutils/ChangeLog | 5 +++++ > binutils/readelf.c | 2 ++ > include/ChangeLog | 5 +++++ > include/elf/common.h | 4 ++++ > 7 files changed, 50 insertions(+) > > diff --git a/bfd/elf-bfd.h b/bfd/elf-bfd.h > index 15206b4e876..4dce8114c0f 100644 > --- a/bfd/elf-bfd.h > +++ b/bfd/elf-bfd.h > @@ -2797,6 +2797,8 @@ extern char *elfcore_write_aarch_pauth > (bfd *, char *, int *, const void *, int); > extern char *elfcore_write_arc_v2 > (bfd *, char *, int *, const void *, int); > +extern char *elfcore_write_gdb_tdesc > + (bfd *, char *, int *, const void *, int); > extern char *elfcore_write_lwpstatus > (bfd *, char *, int *, long, int, const void *); > extern char *elfcore_write_register_note > diff --git a/bfd/elf.c b/bfd/elf.c > index 84a5d942817..9892ffa9faf 100644 > --- a/bfd/elf.c > +++ b/bfd/elf.c > @@ -9912,6 +9912,12 @@ elfcore_grok_arc_v2 (bfd *abfd, Elf_Internal_Note *note) > return elfcore_make_note_pseudosection (abfd, ".reg-arc-v2", note); > } > > +static bfd_boolean > +elfcore_grok_gdb_tdesc (bfd *abfd, Elf_Internal_Note *note) > +{ > + return elfcore_make_note_pseudosection (abfd, ".gdb-tdesc", note); > +} > + > #if defined (HAVE_PRPSINFO_T) > typedef prpsinfo_t elfcore_psinfo_t; > #if defined (HAVE_PRPSINFO32_T) /* Sparc64 cross Sparc32 */ > @@ -10570,6 +10576,9 @@ elfcore_grok_note (bfd *abfd, Elf_Internal_Note *note) > else > return TRUE; > > + case NT_GDB_TDESC: > + return elfcore_grok_gdb_tdesc (abfd, note); > + > case NT_PRPSINFO: > case NT_PSINFO: > if (bed->elf_backend_grok_psinfo) > @@ -11951,6 +11960,18 @@ elfcore_write_arc_v2 (bfd *abfd, > note_name, NT_ARC_V2, arc_v2, size); > } > > +char * > +elfcore_write_gdb_tdesc (bfd *abfd, > + char *buf, > + int *bufsiz, > + const void *tdesc, > + int size) > +{ > + const char *note_name = "CORE"; > + return elfcore_write_note (abfd, buf, bufsiz, > + note_name, NT_GDB_TDESC, tdesc, size); > +} > + > char * > elfcore_write_register_note (bfd *abfd, > char *buf, > @@ -12035,6 +12056,8 @@ elfcore_write_register_note (bfd *abfd, > return elfcore_write_aarch_pauth (abfd, buf, bufsiz, data, size); > if (strcmp (section, ".reg-arc-v2") == 0) > return elfcore_write_arc_v2 (abfd, buf, bufsiz, data, size); > + if (strcmp (section, ".gdb-tdesc") == 0) > + return elfcore_write_gdb_tdesc (abfd, buf, bufsiz, data, size); > return NULL; > } > > diff --git a/binutils/readelf.c b/binutils/readelf.c > index 5df51086226..feb458877c8 100644 > --- a/binutils/readelf.c > +++ b/binutils/readelf.c > @@ -18296,6 +18296,8 @@ get_note_type (Filedata * filedata, unsigned e_type) > return _("NT_PRPSINFO (prpsinfo structure)"); > case NT_TASKSTRUCT: > return _("NT_TASKSTRUCT (task structure)"); > + case NT_GDB_TDESC: > + return _("NT_GDB_TDESC (GDB XML target description)"); > case NT_PRXFPREG: > return _("NT_PRXFPREG (user_xfpregs structure)"); > case NT_PPC_VMX: > diff --git a/include/elf/common.h b/include/elf/common.h > index e7d55ae0782..e6e9c278faa 100644 > --- a/include/elf/common.h > +++ b/include/elf/common.h > @@ -677,6 +677,10 @@ > #define NT_SIGINFO 0x53494749 /* Fields of siginfo_t. */ > #define NT_FILE 0x46494c45 /* Description of mapped files. */ > > +/* The range 0xff000000 to 0xffffffff is set aside for notes that don't > + originate from any particular operating system. */ > +#define NT_GDB_TDESC 0xff000000 /* Contains copy of GDB's target description XML. */ > + > /* Note segments for core files on dir-style procfs systems. */ > > #define NT_PSTATUS 10 /* Has a struct pstatus */ > -- > 2.25.4 >