From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: [PATCH][gdb/testsuite] Fix gdb.opt/solib-intra-step.exp with -m32 and gcc-10
Date: Tue, 26 Jan 2021 19:03:14 +0100 [thread overview]
Message-ID: <20210126180312.GA7860@delia> (raw)
Hi,
When running test-case gdb.opt/solib-intra-step.exp with target board
unix/-m32 and gcc-10, I run into:
...
(gdb) step^M
__x86.get_pc_thunk.bx () at ../sysdeps/i386/crti.S:68^M
68 ../sysdeps/i386/crti.S: No such file or directory.^M
(gdb) step^M
shlib_second (dummy=0) at solib-intra-step-lib.c:23^M
23 abort (); /* second-hit */^M
(gdb) FAIL: gdb.opt/solib-intra-step.exp: second-hit
...
The problem is that the test-case expects to step past the retry line,
which is optional.
Fix this by make the retry line step optional, both for shlib_first and
shlib_second.
Any comments?
Thanks,
- Tom
[gdb/testsuite] Fix gdb.opt/solib-intra-step.exp with -m32 and gcc-10
gdb/testsuite/ChangeLog:
2021-01-26 Tom de Vries <tdevries@suse.de>
* gdb.opt/solib-intra-step.exp: Make step into retry line optional.
---
gdb/testsuite/gdb.opt/solib-intra-step.exp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gdb/testsuite/gdb.opt/solib-intra-step.exp b/gdb/testsuite/gdb.opt/solib-intra-step.exp
index ad19895d890..13e0cf04c7a 100644
--- a/gdb/testsuite/gdb.opt/solib-intra-step.exp
+++ b/gdb/testsuite/gdb.opt/solib-intra-step.exp
@@ -63,7 +63,7 @@ gdb_test_multiple "step" $test {
exp_continue
}
-re -wrap "get_pc_thunk.*" {
- if { $state != 1 } {
+ if { $state != 0 && $state != 1 } {
set state -1
} else {
set state 2
@@ -89,7 +89,7 @@ gdb_test_multiple "step" $test {
exp_continue
}
-re -wrap "get_pc_thunk.*" {
- if { $state != 1 } {
+ if { $state != 0 && $state != 1 } {
set state -1
} else {
set state 2
next reply other threads:[~2021-01-26 18:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 18:03 Tom de Vries [this message]
2021-01-28 15:03 ` Simon Marchi via Gdb-patches
2021-01-28 17:50 ` Tom de Vries
2021-01-28 18:04 ` Simon Marchi via Gdb-patches
2021-01-28 18:15 ` Tom de Vries
2021-01-28 18:20 ` Simon Marchi via Gdb-patches
2021-01-29 10:44 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210126180312.GA7860@delia \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox