From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: [PATCH][gdb/testsuite] Fix ERROR in gdb.dwarf2/dw2-out-of-range-end-of-seq.exp
Date: Tue, 26 Jan 2021 19:02:59 +0100 [thread overview]
Message-ID: <20210126180258.GA7826@delia> (raw)
Hi,
When running test-case gdb.dwarf2/dw2-out-of-range-end-of-seq.exp on a
system with debug packages installed, I run into:
...
(gdb) maint info line-table^M
... <lots of output> ...
ERROR: internal buffer is full.
UNRESOLVED: gdb.dwarf2/dw2-out-of-range-end-of-seq.exp: \
END with address 1 eliminated
...
Fix this by limiting the output of the command using a regexp.
I also noticed that when making the regexp match nothing, meaning
the command has no output, the test didn't FAIL. Fixed this by adding a
PASS pattern.
I also noticed that the FAIL pattern didn't work with -m32, fixed that as
well.
Tested on x86_64-linux.
Any comments?
Thanks,
- Tom
[gdb/testsuite] Fix ERROR in gdb.dwarf2/dw2-out-of-range-end-of-seq.exp
gdb/testsuite/ChangeLog:
2021-01-26 Tom de Vries <tdevries@suse.de>
* gdb.dwarf2/dw2-out-of-range-end-of-seq.exp: Add regexp to
"maint info line-table". Make PASS pattern more specific. Make
FAIL pattern work for -m32.
---
gdb/testsuite/gdb.dwarf2/dw2-out-of-range-end-of-seq.exp | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/gdb/testsuite/gdb.dwarf2/dw2-out-of-range-end-of-seq.exp b/gdb/testsuite/gdb.dwarf2/dw2-out-of-range-end-of-seq.exp
index 7a32a01389c..42cfd0b61ec 100644
--- a/gdb/testsuite/gdb.dwarf2/dw2-out-of-range-end-of-seq.exp
+++ b/gdb/testsuite/gdb.dwarf2/dw2-out-of-range-end-of-seq.exp
@@ -84,11 +84,12 @@ if ![runto_main] {
return -1
}
-gdb_test_multiple "maint info line-table" "END with address 1 eliminated" {
- -re -wrap "END *0x0*1 Y \r\n.*" {
+set test "END with address 1 eliminated"
+gdb_test_multiple "maint info line-table $srcfile$" $test {
+ -re -wrap "END *0x0*1 *Y \r\n.*" {
fail $gdb_test_name
}
- -re -wrap "" {
+ -re -wrap "END *$hex *Y " {
pass $gdb_test_name
}
}
next reply other threads:[~2021-01-26 18:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 18:02 Tom de Vries [this message]
2021-01-27 20:39 ` Tom Tromey
2021-01-27 20:51 ` tdevries
2021-01-27 21:51 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210126180258.GA7826@delia \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox