From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id POdIMbaECWAyCAAAWB0awg (envelope-from ) for ; Thu, 21 Jan 2021 08:42:14 -0500 Received: by simark.ca (Postfix, from userid 112) id BB7811EF80; Thu, 21 Jan 2021 08:42:14 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_NONE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 61F5F1E940 for ; Thu, 21 Jan 2021 08:42:14 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 89B393836C0C; Thu, 21 Jan 2021 13:42:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 89B393836C0C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1611236533; bh=myXmaApkfUGfmSRjTTKFekZbDRd2bnPl8SDyrsmXexU=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=w6Ec4r8SqTGvU635sBjjMhs40e2ikpxOhCfcS/z73gsTMVQgaFyUkqAKGc0pgBAaM bBgW68zGu64IZVMYizOLxbc560Rul6L+82h83zC0d8aSOGzajEhcDbOFFIaeBDAZKc NXZeDvCetCLbt5Nvlnro0SCW9027r/L6DXn4wD8M= Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [IPv6:2607:f8b0:4864:20::730]) by sourceware.org (Postfix) with ESMTPS id 839A338438BA for ; Thu, 21 Jan 2021 13:42:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 839A338438BA Received: by mail-qk1-x730.google.com with SMTP id q9so1252361qkn.2 for ; Thu, 21 Jan 2021 05:42:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=myXmaApkfUGfmSRjTTKFekZbDRd2bnPl8SDyrsmXexU=; b=PYMWLKleyGQWOxNO+YXij2YgdQ0n2LZIDHc4hQwSZkqPwbIERqAYow8yI7a0TJ9A7l PnlCnQv7PwlTC7Y+Y5uqakIkU2fzzyQDTxxM8lgLXE2hbfq7Sd459EEkX3X0XpiDdME3 Xs9/RtZy2XG4fizDZThiSKDKTyfMVA3u92jp24rAsLWf1oDUTkWitfQgAMpHXD60gUqo je2Fsj4KaxhXoKy4Re3R4w1YiewwcY8U1W/6tT2RIjvRZtX7M9CR+kKrs8tTLU5WYuik iPMtPmldcPQrAMoDcAhVZWkpYv0sKVNI1F0wtiV8Vk3uEyQaEOMO6LQzGVTyfwR1gP+E LEKg== X-Gm-Message-State: AOAM532o0fgENmzihZvdYHEx5CSdO2PNkdGB3PeQ0hddObRiJwymQGvi PW85dQzY4eembo10QQ48CdqMVs6VowklkA== X-Google-Smtp-Source: ABdhPJzmHhI+34x6iRonBq2nJY9MPe7yV21vCWv2ppMCpNBfYADM6jnmKQLWm4MLKQ4V5nihYKCaTg== X-Received: by 2002:a37:68c2:: with SMTP id d185mr14365244qkc.45.1611236531001; Thu, 21 Jan 2021 05:42:11 -0800 (PST) Received: from localhost.localdomain ([2804:7f0:8284:874d:e915:28f7:ae02:6439]) by smtp.gmail.com with ESMTPSA id u26sm3636868qkm.69.2021.01.21.05.42.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Jan 2021 05:42:10 -0800 (PST) To: gdb-patches@sourceware.org Subject: [PATCH] Fix build errors for armhf Date: Thu, 21 Jan 2021 10:41:41 -0300 Message-Id: <20210121134141.2032528-1-luis.machado@linaro.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Luis Machado via Gdb-patches Reply-To: Luis Machado Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" When building for 32-bit ARM, I ran into a couple build failures. The first one seems to be caused by recent changes to warning switches, leading to the following error: -- In file included from gdb/coffread.c:35:0: gdb/coffread.c: In function ‘void enter_linenos(file_ptr, int, int, objfile*)’: gdb/complaints.h:40:40: error: format ‘%ld’ expects argument of type ‘long int’, but argument 2 has type ‘file_ptr {aka long long int}’ [-Werror=format=] complaint_internal (FMT, ##__VA_ARGS__); \ ^ gdb/coffread.c:1413:7: note: in expansion of macro ‘complaint’ complaint (_("Line number pointer %ld lower than start of line numbers"), ^~~~~~~~~ -- The other one is due to a narrowing conversion in valops.c: -- gdb/valops.c: In function ‘value* value_assign(value*, value*)’: gdb/gdbtypes.h:1798:43: error: narrowing conversion of ‘type->type::length’ from ‘ULONGEST {aka long long unsigned int}’ to ‘size_t {aka unsigned int}’ inside { } [-Werror=narrowing] #define TYPE_LENGTH(thistype) (thistype)->length ~~~~~~~~~~~~^ gdb/valops.c:1252:9: note: in expansion of macro ‘TYPE_LENGTH’ TYPE_LENGTH (type)}); -- Fix both with the following patch. Validated with --enable-targets=all on Ubuntu 18.04/20.04. gdb/ChangeLog: YYYY-MM-DD Luis Machado * coffread.c (enter_linenos): Passing string to complaint. * valops.c (value_assign): Make array view. --- gdb/coffread.c | 4 ++-- gdb/valops.c | 6 ++++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/gdb/coffread.c b/gdb/coffread.c index 3b59ba9c922..296cc90d902 100644 --- a/gdb/coffread.c +++ b/gdb/coffread.c @@ -1410,8 +1410,8 @@ enter_linenos (file_ptr file_offset, int first_line, return; if (file_offset < linetab_offset) { - complaint (_("Line number pointer %ld lower than start of line numbers"), - file_offset); + complaint (_("Line number pointer %s lower than start of line numbers"), + phex_nz (file_offset, sizeof (file_offset))); if (file_offset > linetab_size) /* Too big to be an offset? */ return; file_offset += linetab_offset; /* Try reading at that linetab diff --git a/gdb/valops.c b/gdb/valops.c index 882f6e7f0c2..d0d5628d11b 100644 --- a/gdb/valops.c +++ b/gdb/valops.c @@ -1246,10 +1246,12 @@ value_assign (struct value *toval, struct value *fromval) } else { + gdb::array_view contents + = gdb::make_array_view (value_contents (fromval), + TYPE_LENGTH (type)); put_frame_register_bytes (frame, value_reg, value_offset (toval), - {value_contents (fromval), - TYPE_LENGTH (type)}); + contents); } } -- 2.25.1