From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 0MUvJfNHCWC8AgAAWB0awg (envelope-from ) for ; Thu, 21 Jan 2021 04:22:59 -0500 Received: by simark.ca (Postfix, from userid 112) id 889441EF80; Thu, 21 Jan 2021 04:22:59 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id AAAC81E939 for ; Thu, 21 Jan 2021 04:22:58 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 06EE63840C35; Thu, 21 Jan 2021 09:22:58 +0000 (GMT) Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by sourceware.org (Postfix) with ESMTPS id D2E4B3842427 for ; Thu, 21 Jan 2021 09:22:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D2E4B3842427 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=andrew.burgess@embecosm.com Received: by mail-wr1-x433.google.com with SMTP id 6so1000504wri.3 for ; Thu, 21 Jan 2021 01:22:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Wf9GmtVfEvW04UQzGZNNbLxEt+N5dTPhZaPNS7wTog0=; b=GFK8PTmQ75bbT382uc6TouF+cf5zfn7qcwAN8ohB1bF+it063WsmIWCkqLNRWqB741 Q7Jdc2UhZJSBYbG9ZxrS0/9zUeNlAPCKgpI8L1mIQ127WDZpjbG3le/al7mPx9Ei4J7G HSXfV/2tGpi7Qcl/wr8Ct62eeyuaaWKd8E8vPTbodeHHpvXd0jHqBtSSawwmVYVriHKG bXoDFbBKwV+N9DgwUOwMKxUUxAVdEdpnigcOB+h6ibNhs35dJRrTzUyXCmWdCKidY8dP nwbH2kqimGno7o4zp02FmaNz7fIBtMT+1NcoAeqz3OCbwgEarxwQEg+k5ATgC796xQ6+ 0oMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Wf9GmtVfEvW04UQzGZNNbLxEt+N5dTPhZaPNS7wTog0=; b=RKBqtZV1HrOGe9ARZyMI915py7Dd2TAJQ6KvxO7TGilaSAxmYPA2d3NM03Q0pxxe6i AXDRxvZfH2HD5uBnXEmCPvMQuNeWEIa12XUDFADzq06AAmOlVFP3+JEjcbFte/vjyFDu 8iAmwVEu+UMhCzrNcobK3KAWsjCa+fM4fKywLP3epbdTCpBzUOzbVVQukR2obAxIrmhI ztqTkt/gd0okt2+f068TZlSQrBP2ziilmr0B61ByKqanZkCDFzr+WIrlpwyOmpT3jadd WQFkknD7EcUaAnL+8wxfOMUo00il/poFYOD9R90JFUoc7aeQi0F/odH5sNXU3BZGH/p4 Qzow== X-Gm-Message-State: AOAM531PaZCaHcr/dPhFPsldHacg8NqtKnULjtjE6DkycKrtuiUTuEDi YS3BbLEivAGrfLwFVk6hGK6gGhJf/mNqIA== X-Google-Smtp-Source: ABdhPJyI/JG1L6/V00c1EezeJSCGkEvpzzw+Oh/lvn5CV9MVLRF4yYUcca3pEEr43DHZM9z+dR1oDQ== X-Received: by 2002:adf:d20b:: with SMTP id j11mr12903291wrh.318.1611220974738; Thu, 21 Jan 2021 01:22:54 -0800 (PST) Received: from localhost (host109-154-20-185.range109-154.btcentralplus.com. [109.154.20.185]) by smtp.gmail.com with ESMTPSA id p18sm7391892wmc.31.2021.01.21.01.22.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Jan 2021 01:22:54 -0800 (PST) Date: Thu, 21 Jan 2021 09:22:53 +0000 From: Andrew Burgess To: gdb-patches@sourceware.org Subject: Re: [PATCH] sim: testsuite: push $arch out to targets Message-ID: <20210121092253.GW265215@embecosm.com> References: <20210117160945.1362-1-vapier@gentoo.org> <20210118095201.GN265215@embecosm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux/5.8.13-100.fc31.x86_64 (x86_64) X-Uptime: 09:18:26 up 43 days, 14:02, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" * Mike Frysinger [2021-01-18 13:01:53 -0500]: > On 18 Jan 2021 09:52, Andrew Burgess wrote: > > * Mike Frysinger via Gdb-patches [2021-01-17 11:09:45 -0500]: > > > This is needed to move to automake & its dejagnu-provided logic, > > > and eventually by the unified sim logic. > > > > I looked through this patch and I didn't understand what's going on > > here. > > > > Why do you need to set the global arch in some, but not all tests? > > it is being done in all tests. which ones do you think i skipped ? That's my bad, I hadn't realised just how few *.exp files there are in the sim testsuite tree. > > > If this needs doing at all, could it not be done in some global location? > > the sim ports use a unique subdir for their `run` program. the tests > need to find that path. this $arch value is what binds the specific > subdir to the test. I don't understand that paragraph I'm afraid. I guess my question is each *.exp file gets invoked by dejagnu, but there are other hooks that dejagnu calls, like the ${tool}_init proc. Could we not use that to set these things instead? It seems like there's a 1:1 mapping between [istarget ????] patterns and the values pushed into both arch and all_machs. > > as we do multibuilds, we'll have multiple ports active, so a single > variable won't cut it. moving it here and out of autotols enables > that. as we do multitarget, this will help smooth the transition as > we won't have to juggle each arch as it migrates. Again, I don't understand this, or how it relates to this discussion. Sorry. Thanks, Andrew