From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id WQYeLGljBWBwGQAAWB0awg (envelope-from ) for ; Mon, 18 Jan 2021 05:31:05 -0500 Received: by simark.ca (Postfix, from userid 112) id A528F1EF80; Mon, 18 Jan 2021 05:31:05 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED, MAILING_LIST_MULTI,T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 934FC1E945 for ; Mon, 18 Jan 2021 05:31:04 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EB869384BC21; Mon, 18 Jan 2021 10:31:03 +0000 (GMT) Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by sourceware.org (Postfix) with ESMTPS id 087D538460A3 for ; Mon, 18 Jan 2021 10:31:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 087D538460A3 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=andrew.burgess@embecosm.com Received: by mail-wm1-x335.google.com with SMTP id h17so12911123wmq.1 for ; Mon, 18 Jan 2021 02:31:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=87JzYceHiugZkiJonVu5581prYgUtAqSrZMwvEwCW+w=; b=Ix8uYxlTM/ycmHjGlLbaupE2MwKz3oSHGucPZcsVMetluDC+jjpVZ9mW/amfflXxW2 p9dmetsjUfn+H26mAN8VrgqLCIB0chT24+3fySIasjjA/Q+UmHOVswEhFOAzj0eoJQTe DPMggVuBPlx3PoZ43E9NqPBtYaXq5qF5k9W6hBjjtecr19f3g0pDhKVetyetkLwarGIY GyGYV6YcjeS4kl0JGEHwRzJ8/KMCsOAcom+XSc9CfYAjM6kgxaHbyu9foDzeANiQIxo9 Jp3ZfVbHnFpqZX55a1oORiWdZrqMxAN1khufiRw4dWcUpAmR/pVE2VTsgNL8G6ZnASAP roOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=87JzYceHiugZkiJonVu5581prYgUtAqSrZMwvEwCW+w=; b=pYQSLG+wsOSlERoV9ECauNHhqUl0YU4R4O8FovKzhB6oC7bop9/tL0yr3WXXpcc5QV U4dGcoU/aLfjuyqYkP1A4UfX8f4tmu3Y/hAKfG5oZofy5dy+Y+ITtQ7b49lC/q7e2S8q +Xejma0bc88xnR2a9V3f08Mn+1XrOWM0iv5VzXFr9h8yZr3BASdjfAQI6UpEtsEdFqfL enM8gmCNVL7/b4Z0PZLVt+ebFGkTiWZZmzq2TC7yx5ZU0ga9acGXc1t6C92wmDlmjQfh /QEmQd/KHGJPNDgb/Qfb4vPUWxbaECmVtB1CZTDzaY+JaQv75PlKfRdPE0Fvu/LbL4bV jTLg== X-Gm-Message-State: AOAM533CxjeeTelkuLD1klWjeivZW9lHNTpy5idxy7rua/j0do0RGPCt bfbtCbxYMQUg+9ZB+NhJzx17sQ== X-Google-Smtp-Source: ABdhPJyiurK34Gc3MJlvKfBKfjyHTfh04mPlUqNk6m78onztFGXwHW5z1HBCLO/GMqLQDTUNZKmgfg== X-Received: by 2002:a1c:7f83:: with SMTP id a125mr20323534wmd.86.1610965859700; Mon, 18 Jan 2021 02:30:59 -0800 (PST) Received: from localhost (host86-166-129-230.range86-166.btcentralplus.com. [86.166.129.230]) by smtp.gmail.com with ESMTPSA id a184sm13450366wme.35.2021.01.18.02.30.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Jan 2021 02:30:59 -0800 (PST) Date: Mon, 18 Jan 2021 10:30:58 +0000 From: Andrew Burgess To: Hannes Domani Subject: Re: [PATCH 2/4] Return true in TuiWindow.is_valid only if TUI is enabled Message-ID: <20210118103058.GR265215@embecosm.com> References: <20201229170227.821-1-ssbssa@yahoo.de> <20201229170227.821-2-ssbssa@yahoo.de> <20210115164811.GK265215@embecosm.com> <20210117113102.GM265215@embecosm.com> <2060671008.4946685.1610889581434@mail.yahoo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <2060671008.4946685.1610889581434@mail.yahoo.com> X-Operating-System: Linux/5.8.13-100.fc31.x86_64 (x86_64) X-Uptime: 10:26:48 up 40 days, 15:11, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tom Tromey , "gdb-patches@sourceware.org" Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" * Hannes Domani [2021-01-17 13:19:41 +0000]: > Am Sonntag, 17. Januar 2021, 12:31:05 MEZ hat Andrew Burgess Folgendes geschrieben: >=20 > > After further though I think there's an even better solution for this > > issue.=A0 See the patch below. >=20 > This version crashes for me when I disable and then re-enable TUI, because > tui_windows and tui_win_list are empty, not filled again in tui_enable, a= nd the > tui_update_gdb_sizes call at the end of tui_enable dereferences > TUI_CMD_WIN. That's annoying. I would have sworn I'd tested that. Guess not. I'll take a look at this later today. I guess something that's currently conditional will need to become unconditional so that the windows are recreated when the tui is enabled. >=20 > Also, and I think your previous patch behaves the same, but I can no long= er use > the TuiWindows variables width/height/title inside my Window.close functi= on, > because at this point tui_active=3D=3Dfalse, so the assertion inside is_v= alid > fails. OK, I think this one should be easy enough to fix. Out of interest, what do you do with the width/height/title in the close method? Given the window is about to vanish I'd have thought all you'd be doing at this point is internal object clean up? > This can be worked around by saving the values in some Window class membe= rs, > but it is more inconvenient. I think my fix will mean you don't need to do this. Thanks, Andrew