Re: [PATCH] sim: common: modernize gennltvals.sh

Simon Marchi via Gdb-patches
2021-01-18T17:19:17Z

On 2021-01-18 12:13 p.m., Mike Frysinger wrote:
> i had run shellcheck and the only warnings (about unquoted expansion)
> i didn't think we worth fixing because of the limited scope of the
> script. the variable in question isn't accepting user input, it's
> operating on fixed inputs, and if we restrict ourselves to POSIX
> shell (which i think we do), then our options are limited, and imo
> the alternatives make it harder to read/understand.

Even considering this, I think it's worth just quoting the variables
and getting rid the warnings. It's trivial, and it would make any
future (more important) warning more apparent.

Anyway, it's just a suggestion, it's up to you :).

Simon