Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Burgess <andrew.burgess@embecosm.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] sim: call SIM_AC_OPTION_WARNINGS(no) in remaining ports
Date: Mon, 11 Jan 2021 11:37:10 +0000	[thread overview]
Message-ID: <20210111113710.GF1175365@embecosm.com> (raw)
In-Reply-To: <20210109194708.12437-1-vapier@gentoo.org>

* Mike Frysinger via Gdb-patches <gdb-patches@sourceware.org> [2021-01-09 14:47:08 -0500]:

> We want all ports to opt into extra warnings as the default compiler
> settings lets a lot slide.  Opt all the ports that haven't already in
> to the warning system.  None of them build with -Werror, so disable
> that by default.  Hopefully someone finds these important enough to
> start fixing at some point.
> ---
>  sim/bpf/ChangeLog       |   4 ++
>  sim/bpf/configure       | 109 +++++++++++++++++++++++++++++++++++++++-
>  sim/bpf/configure.ac    |   1 +
>  sim/erc32/ChangeLog     |   4 ++
>  sim/erc32/configure     | 109 +++++++++++++++++++++++++++++++++++++++-
>  sim/erc32/configure.ac  |   1 +
>  sim/frv/ChangeLog       |   4 ++
>  sim/frv/configure       | 109 +++++++++++++++++++++++++++++++++++++++-
>  sim/frv/configure.ac    |   1 +
>  sim/h8300/ChangeLog     |   4 ++
>  sim/h8300/configure     | 109 +++++++++++++++++++++++++++++++++++++++-
>  sim/h8300/configure.ac  |   1 +
>  sim/iq2000/ChangeLog    |   4 ++
>  sim/iq2000/configure    | 109 +++++++++++++++++++++++++++++++++++++++-
>  sim/iq2000/configure.ac |   1 +
>  sim/lm32/ChangeLog      |   4 ++
>  sim/lm32/configure      | 109 +++++++++++++++++++++++++++++++++++++++-
>  sim/lm32/configure.ac   |   1 +
>  sim/m32r/ChangeLog      |   4 ++
>  sim/m32r/configure      | 109 +++++++++++++++++++++++++++++++++++++++-
>  sim/m32r/configure.ac   |   1 +
>  sim/or1k/ChangeLog      |   4 ++
>  sim/or1k/configure      | 109 +++++++++++++++++++++++++++++++++++++++-
>  sim/or1k/configure.ac   |   1 +
>  sim/rl78/ChangeLog      |   4 ++
>  sim/rl78/configure      | 109 +++++++++++++++++++++++++++++++++++++++-
>  sim/rl78/configure.ac   |   1 +
>  sim/rx/ChangeLog        |   4 ++
>  sim/rx/configure        | 109 +++++++++++++++++++++++++++++++++++++++-
>  sim/rx/configure.ac     |   1 +
>  30 files changed, 1120 insertions(+), 20 deletions(-)
> 
> diff --git a/sim/bpf/ChangeLog b/sim/bpf/ChangeLog
> index cefe16b8ac3f..f8973ba3f98f 100644
> --- a/sim/bpf/ChangeLog
> +++ b/sim/bpf/ChangeLog
> @@ -1,3 +1,7 @@
> +2021-01-09  Mike Frysinger  <vapier@gentoo.org>
> +
> +	* configure, configure.ac: Regenerate.

Surely:

	* configure.ac: Add SIM_AC_OPTION_WARNINGS.
        * configure: Regenerate.

Otherwise, LGTM.

Thanks,
Andrew


> +
>  2021-01-09  Mike Frysinger  <vapier@gentoo.org>
>  
>  	* config.in, configure: Regenerate.
> diff --git a/sim/bpf/configure.ac b/sim/bpf/configure.ac
> index e7cd72a1c670..e9df51ab1ed5 100644
> --- a/sim/bpf/configure.ac
> +++ b/sim/bpf/configure.ac
> @@ -9,6 +9,7 @@ SIM_AC_OPTION_ENDIAN([], [LITTLE])
>  SIM_AC_OPTION_ALIGNMENT(NONSTRICT_ALIGNMENT)
>  SIM_AC_OPTION_SCACHE(16384)
>  SIM_AC_OPTION_DEFAULT_MODEL([bpf-def])
> +SIM_AC_OPTION_WARNINGS(no)
>  SIM_AC_OPTION_CGEN_MAINT
>  
>  SIM_AC_OUTPUT
> diff --git a/sim/erc32/ChangeLog b/sim/erc32/ChangeLog
> index bf108f5a1d61..d9cfec0d92be 100644
> --- a/sim/erc32/ChangeLog
> +++ b/sim/erc32/ChangeLog
> @@ -1,3 +1,7 @@
> +2021-01-09  Mike Frysinger  <vapier@gentoo.org>
> +
> +	* configure, configure.ac: Regenerate.
> +
>  2021-01-09  Mike Frysinger  <vapier@gentoo.org>
>  
>  	* config.in, configure: Regenerate.
> diff --git a/sim/erc32/configure.ac b/sim/erc32/configure.ac
> index 2317d47ac49d..2c81b846a828 100644
> --- a/sim/erc32/configure.ac
> +++ b/sim/erc32/configure.ac
> @@ -18,6 +18,7 @@ AC_INIT(Makefile.in)
>  sinclude(../common/acinclude.m4)
>  
>  SIM_AC_COMMON
> +SIM_AC_OPTION_WARNINGS(no)
>  
>  # In the Cygwin environment, we need some additional flags.
>  AC_CACHE_CHECK([for cygwin], sim_cv_os_cygwin,
> diff --git a/sim/frv/ChangeLog b/sim/frv/ChangeLog
> index e13917e1c882..c390bc709ddb 100644
> --- a/sim/frv/ChangeLog
> +++ b/sim/frv/ChangeLog
> @@ -1,3 +1,7 @@
> +2021-01-09  Mike Frysinger  <vapier@gentoo.org>
> +
> +	* configure, configure.ac: Regenerate.
> +
>  2021-01-09  Mike Frysinger  <vapier@gentoo.org>
>  
>  	* config.in, configure: Regenerate.
> diff --git a/sim/frv/configure.ac b/sim/frv/configure.ac
> index cb3cc14eb13f..5588533a5d61 100644
> --- a/sim/frv/configure.ac
> +++ b/sim/frv/configure.ac
> @@ -8,6 +8,7 @@ SIM_AC_OPTION_ENDIAN(BIG)
>  SIM_AC_OPTION_ALIGNMENT(STRICT_ALIGNMENT)
>  SIM_AC_OPTION_SCACHE(16384)
>  SIM_AC_OPTION_DEFAULT_MODEL(fr500)
> +SIM_AC_OPTION_WARNINGS(no)
>  SIM_AC_OPTION_CGEN_MAINT
>  
>  #
> diff --git a/sim/h8300/ChangeLog b/sim/h8300/ChangeLog
> index 8ee601e1371d..060213c10bf2 100644
> --- a/sim/h8300/ChangeLog
> +++ b/sim/h8300/ChangeLog
> @@ -1,3 +1,7 @@
> +2021-01-09  Mike Frysinger  <vapier@gentoo.org>
> +
> +	* configure, configure.ac: Regenerate.
> +
>  2021-01-09  Mike Frysinger  <vapier@gentoo.org>
>  
>  	* config.in, configure: Regenerate.
> diff --git a/sim/h8300/configure.ac b/sim/h8300/configure.ac
> index d2ee9266351e..8caacadd662d 100644
> --- a/sim/h8300/configure.ac
> +++ b/sim/h8300/configure.ac
> @@ -6,6 +6,7 @@ SIM_AC_COMMON
>  
>  SIM_AC_OPTION_ENDIAN(BIG)
>  SIM_AC_OPTION_ALIGNMENT(NONSTRICT_ALIGNMENT)
> +SIM_AC_OPTION_WARNINGS(no)
>  
>  AC_CHECK_HEADERS(sys/param.h)
>  
> diff --git a/sim/iq2000/ChangeLog b/sim/iq2000/ChangeLog
> index 64fbd474e87b..8c04d2c31c35 100644
> --- a/sim/iq2000/ChangeLog
> +++ b/sim/iq2000/ChangeLog
> @@ -1,3 +1,7 @@
> +2021-01-09  Mike Frysinger  <vapier@gentoo.org>
> +
> +	* configure, configure.ac: Regenerate.
> +
>  2021-01-09  Mike Frysinger  <vapier@gentoo.org>
>  
>  	* config.in, configure: Regenerate.
> diff --git a/sim/iq2000/configure.ac b/sim/iq2000/configure.ac
> index 6b9f3637a094..4a1b28baa235 100644
> --- a/sim/iq2000/configure.ac
> +++ b/sim/iq2000/configure.ac
> @@ -8,6 +8,7 @@ SIM_AC_OPTION_ENDIAN(BIG)
>  SIM_AC_OPTION_ALIGNMENT(STRICT_ALIGNMENT)
>  SIM_AC_OPTION_SCACHE(16384)
>  SIM_AC_OPTION_DEFAULT_MODEL(iq2000)
> +SIM_AC_OPTION_WARNINGS(no)
>  SIM_AC_OPTION_CGEN_MAINT
>  
>  SIM_AC_OPTION_HARDWARE(yes,"","")
> diff --git a/sim/lm32/ChangeLog b/sim/lm32/ChangeLog
> index f1bc6679fc9f..34ad62347014 100644
> --- a/sim/lm32/ChangeLog
> +++ b/sim/lm32/ChangeLog
> @@ -1,3 +1,7 @@
> +2021-01-09  Mike Frysinger  <vapier@gentoo.org>
> +
> +	* configure, configure.ac: Regenerate.
> +
>  2021-01-09  Mike Frysinger  <vapier@gentoo.org>
>  
>  	* config.in, configure: Regenerate.
> diff --git a/sim/lm32/configure.ac b/sim/lm32/configure.ac
> index 82240ff327f5..7da76d989fe4 100644
> --- a/sim/lm32/configure.ac
> +++ b/sim/lm32/configure.ac
> @@ -8,6 +8,7 @@ SIM_AC_OPTION_ENDIAN(BIG)
>  SIM_AC_OPTION_ALIGNMENT(STRICT_ALIGNMENT,STRICT_ALIGNMENT)
>  SIM_AC_OPTION_SCACHE(16384)
>  SIM_AC_OPTION_DEFAULT_MODEL(lm32)
> +SIM_AC_OPTION_WARNINGS(no)
>  SIM_AC_OPTION_CGEN_MAINT
>  SIM_AC_OPTION_HARDWARE(yes,,lm32cpu lm32timer lm32uart)
>  
> diff --git a/sim/m32r/ChangeLog b/sim/m32r/ChangeLog
> index dcc2f4785597..ed945143d794 100644
> --- a/sim/m32r/ChangeLog
> +++ b/sim/m32r/ChangeLog
> @@ -1,3 +1,7 @@
> +2021-01-09  Mike Frysinger  <vapier@gentoo.org>
> +
> +	* configure, configure.ac: Regenerate.
> +
>  2021-01-09  Mike Frysinger  <vapier@gentoo.org>
>  
>  	* config.in, configure: Regenerate.
> diff --git a/sim/m32r/configure.ac b/sim/m32r/configure.ac
> index 6020a5c89c3f..e74a8a57bed8 100644
> --- a/sim/m32r/configure.ac
> +++ b/sim/m32r/configure.ac
> @@ -8,6 +8,7 @@ SIM_AC_OPTION_ENDIAN(BIG)
>  SIM_AC_OPTION_ALIGNMENT(STRICT_ALIGNMENT)
>  SIM_AC_OPTION_SCACHE(16384)
>  SIM_AC_OPTION_DEFAULT_MODEL(m32r/d)
> +SIM_AC_OPTION_WARNINGS(no)
>  SIM_AC_OPTION_CGEN_MAINT
>  
>    case "${target_alias}" in
> diff --git a/sim/or1k/ChangeLog b/sim/or1k/ChangeLog
> index 7c255f0522b4..fe79f9fc4ff3 100644
> --- a/sim/or1k/ChangeLog
> +++ b/sim/or1k/ChangeLog
> @@ -1,3 +1,7 @@
> +2021-01-09  Mike Frysinger  <vapier@gentoo.org>
> +
> +	* configure, configure.ac: Regenerate.
> +
>  2021-01-09  Mike Frysinger  <vapier@gentoo.org>
>  
>  	* config.in, configure: Regenerate.
> diff --git a/sim/or1k/configure.ac b/sim/or1k/configure.ac
> index aa7c4004fe53..19a1da319bc0 100644
> --- a/sim/or1k/configure.ac
> +++ b/sim/or1k/configure.ac
> @@ -9,6 +9,7 @@ SIM_AC_OPTION_ALIGNMENT(STRICT_ALIGNMENT)
>  SIM_AC_OPTION_BITSIZE([32], [31], [32])
>  SIM_AC_OPTION_SCACHE(16384)
>  SIM_AC_OPTION_DEFAULT_MODEL([or1200])
> +SIM_AC_OPTION_WARNINGS(no)
>  SIM_AC_OPTION_ENVIRONMENT
>  SIM_AC_OPTION_INLINE()
>  SIM_AC_OPTION_CGEN_MAINT
> diff --git a/sim/rl78/ChangeLog b/sim/rl78/ChangeLog
> index 2d52d4b08988..f7bc7b6b1505 100644
> --- a/sim/rl78/ChangeLog
> +++ b/sim/rl78/ChangeLog
> @@ -1,3 +1,7 @@
> +2021-01-09  Mike Frysinger  <vapier@gentoo.org>
> +
> +	* configure, configure.ac: Regenerate.
> +
>  2021-01-09  Mike Frysinger  <vapier@gentoo.org>
>  
>  	* config.in, configure: Regenerate.
> diff --git a/sim/rl78/configure.ac b/sim/rl78/configure.ac
> index b44d1dabb2b3..65bb40766f59 100644
> --- a/sim/rl78/configure.ac
> +++ b/sim/rl78/configure.ac
> @@ -22,6 +22,7 @@ AC_INIT(Makefile.in)
>  sinclude(../common/acinclude.m4)
>  
>  SIM_AC_COMMON
> +SIM_AC_OPTION_WARNINGS(no)
>  
>  AC_CHECK_HEADERS(getopt.h)
>  
> diff --git a/sim/rx/ChangeLog b/sim/rx/ChangeLog
> index 23d3a4afeedb..87d9e1c72496 100644
> --- a/sim/rx/ChangeLog
> +++ b/sim/rx/ChangeLog
> @@ -1,3 +1,7 @@
> +2021-01-09  Mike Frysinger  <vapier@gentoo.org>
> +
> +	* configure, configure.ac: Regenerate.
> +
>  2021-01-09  Mike Frysinger  <vapier@gentoo.org>
>  
>  	* config.in, configure: Regenerate.
> diff --git a/sim/rx/configure.ac b/sim/rx/configure.ac
> index 1bdb5abc2773..6c14434f4af2 100644
> --- a/sim/rx/configure.ac
> +++ b/sim/rx/configure.ac
> @@ -22,6 +22,7 @@ AC_INIT(Makefile.in)
>  sinclude(../common/acinclude.m4)
>  
>  SIM_AC_COMMON
> +SIM_AC_OPTION_WARNINGS(no)
>  
>  AC_CHECK_HEADERS(getopt.h)
>  
> -- 
> 2.28.0
> 

  reply	other threads:[~2021-01-11 11:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-09 19:47 Mike Frysinger via Gdb-patches
2021-01-11 11:37 ` Andrew Burgess [this message]
2021-01-11 14:04   ` Mike Frysinger via Gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210111113710.GF1175365@embecosm.com \
    --to=andrew.burgess@embecosm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox