From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id YAlRGGI2/F+GFQAAWB0awg (envelope-from ) for ; Mon, 11 Jan 2021 06:28:34 -0500 Received: by simark.ca (Postfix, from userid 112) id 5B6FC1EEEF; Mon, 11 Jan 2021 06:28:34 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_NONE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id F239F1E4F4 for ; Mon, 11 Jan 2021 06:28:33 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B82423843856; Mon, 11 Jan 2021 11:28:33 +0000 (GMT) Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by sourceware.org (Postfix) with ESMTPS id BB5783843856 for ; Mon, 11 Jan 2021 11:28:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org BB5783843856 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=andrew.burgess@embecosm.com Received: by mail-wr1-x42a.google.com with SMTP id d13so15962556wrc.13 for ; Mon, 11 Jan 2021 03:28:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=l6DFhwQHwj86ivPaK//sFj3L1qVC7vJI7oRAOCmKIrY=; b=PxUM7/bPeZLZYsip1mwsUrMIz0tP+EQxkJHr/+qevgZ31GRTfmusb5yBtFvXchv98z oLIRxZ4fqwPotwqzqAAzS839vidxvQ9DzgjTl0b2nkgznEyQDe+nTy8R19Ow8aZ6EUK8 PderiglVyw2BzvKjZ565CUgBcRLG280eIeXliJZGCN0ziQdupOSfuadheItQgGlRmVvw SKVYUcaPIf3GzwCe1b58F2vxAqjP0NUMrRWMvohCmZlMsAb/vZo7I9RCgK3A5JIRbUzi w0+eYnSGTkY0sc1QD6vviFZ8GEux8lN+uYPat8YT3gpHVgcwOlxGxYxmppR/3WNfVK+d aF/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=l6DFhwQHwj86ivPaK//sFj3L1qVC7vJI7oRAOCmKIrY=; b=lAt7zpMAdOd8gvDtr9RP9t09b/7WqJGyQDKkaT842H7bkyh9TGnq4cu+EYUcRvYUvD Lo/Eeapit4sYuhyN5QQQNOr6HZGdZwqLoMg4JAU+Kc93nI8YznOqhHpM5CjFbbdehkLp kNsfgH0Vldpx73B0AQ3trkVFJCkh/uvGznyONw5lKQtNAxKLB/m3g/KtlKRP5lWP7YNT xSj0Q5NWYiYYB9xF4Zj+v1fP4DI96N9Cy/bK+L5IFTbvuMclAEE2nBWJ9xa3AVvgsUDY uRq6Ev8N2YxW0JFC2HcgObwry9oT0rcUQL7YR8iIBIqRWej23LqSRuqFUTk/IrfBQzIF 9chQ== X-Gm-Message-State: AOAM531ZDTYkFzU6veSRu+32mfN3qToa1up8f1p1HTm7rsiqSlz3GFvn 3N1mFq8Jxf1EP/fD9+5pG+yOFe6hTLBVnw== X-Google-Smtp-Source: ABdhPJyJwX8GcczyawcA7OxwbYYw1NhZxOQ6nCqmyzNnkk0rIwrWYART0+riKo7s7dKOOGyZaJVPTQ== X-Received: by 2002:adf:c449:: with SMTP id a9mr15819900wrg.281.1610364510947; Mon, 11 Jan 2021 03:28:30 -0800 (PST) Received: from localhost (host86-166-129-230.range86-166.btcentralplus.com. [86.166.129.230]) by smtp.gmail.com with ESMTPSA id c190sm20996888wme.19.2021.01.11.03.28.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jan 2021 03:28:30 -0800 (PST) Date: Mon, 11 Jan 2021 11:28:29 +0000 From: Andrew Burgess To: Mike Frysinger Subject: Re: [PATCH] sim: rl78: move storage out of header Message-ID: <20210111112829.GC1175365@embecosm.com> References: <20210109151936.9041-1-vapier@gentoo.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210109151936.9041-1-vapier@gentoo.org> X-Operating-System: Linux/5.8.13-100.fc31.x86_64 (x86_64) X-Uptime: 11:27:36 up 33 days, 16:12, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" * Mike Frysinger via Gdb-patches [2021-01-09 10:19:36 -0500]: > This port declares its pc variable in a header and then includes > it times. This causes linker errors with newer gcc due to the Missing work 'it times' ? Missing ChangeLog. Otherwise, LGTM. Thanks, Andrew > change in -fno-common behavior. Move the storage to a C file so > we only have one instance of it in the final program. > --- > sim/rl78/cpu.c | 2 ++ > sim/rl78/cpu.h | 2 +- > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/sim/rl78/cpu.c b/sim/rl78/cpu.c > index a1b85435001e..a38d6f688aee 100644 > --- a/sim/rl78/cpu.c > +++ b/sim/rl78/cpu.c > @@ -36,6 +36,8 @@ int rl78_g10_mode = 0; > int g13_multiply = 0; > int g14_multiply = 0; > > +SI pc; > + > #define REGISTER_ADDRESS 0xffee0 > > typedef struct { > diff --git a/sim/rl78/cpu.h b/sim/rl78/cpu.h > index 4629e0b69b05..a21de326731f 100644 > --- a/sim/rl78/cpu.h > +++ b/sim/rl78/cpu.h > @@ -39,7 +39,7 @@ extern int rl78_in_gdb; > SI get_reg (RL78_Register); > SI set_reg (RL78_Register, SI); > > -SI pc; > +extern SI pc; > > > extern const char * const reg_names[]; > -- > 2.28.0 >