From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id GFrxDIrh9l+cBQAAWB0awg (envelope-from ) for ; Thu, 07 Jan 2021 05:25:14 -0500 Received: by simark.ca (Postfix, from userid 112) id 280CC1E965; Thu, 7 Jan 2021 05:25:14 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED, MAILING_LIST_MULTI,T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2C3071E590 for ; Thu, 7 Jan 2021 05:25:13 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9F2963851C03; Thu, 7 Jan 2021 10:25:12 +0000 (GMT) Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by sourceware.org (Postfix) with ESMTPS id 5F5533851C03 for ; Thu, 7 Jan 2021 10:25:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5F5533851C03 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=andrew.burgess@embecosm.com Received: by mail-wr1-x430.google.com with SMTP id r3so5112086wrt.2 for ; Thu, 07 Jan 2021 02:25:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=0aYTKAdDGEoYukegLNmGUo8/+E/YiUB2Kdfc6qrK/TI=; b=FZQLJIBwwsvU2mLsl/ZPplYvkJ8jW1fE0ocRmbFou3qsx+YYM9zSMj2kl59C8x9ORQ w9B5WFsqwYKsMbObRFQHZydqVjXcyWJFnpJ3fa3J/MFfaq79uOsv7xWhQZzQ2pkAvMs5 CgBDkVw7DVMHpeNm9F+a5X23lR7DExy48gF+O+r8ltzoM9kbXnPvX1OWZJThT39y5Pwp NC20tVhhvPURdo71Qp9IVL0mbhQf675xSk7i8Ls93M4YRCHJ1MmptDW5ZJX+RxfTmBxK Vy8ofSIjqteR43fGBrtdlwS0EbZrhJwFLS/lq0tLHrtHe6InTeqgH1wb/ZuARQw1vzJ9 akDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=0aYTKAdDGEoYukegLNmGUo8/+E/YiUB2Kdfc6qrK/TI=; b=LJ4CeJbJHGBNimNg8xaty36idb4zA29os/feivoVHc+2OMusGAYyWU5mWZedfcjwzn Z6e4prlWdX0GVsWgAKmeAwAH0Q7e5vzR2tGYOXVSHEM6dPe0gXy5XYgZYLlGbaniHE4V ddSo+pA9idhoe0NGrCeNv1QRY1MC9L0hzFObP9KV09AbhisQ3rIl6eBLpDB/DvWPPI7F ZZ8f1PjidF759ls6LwW1atJgZreWHHUFJoFiFFCL3bfgpdfPKVTdVMo2KYUz+EE9V6n0 ekmmVpIQEg743BkaOLadiNB9aj77rL2NKZNHr0jBGmxdRiS2ZCC+mXX2yhQhdguG/0TL SlAg== X-Gm-Message-State: AOAM531t8fNCtv+26Ka+NUFQ/cq6Jg8DNad1GAKMq3ul/jgwxrb7RTpX ohFwP9aQlXKRRNRTr697mxesRw7LSGiQLA== X-Google-Smtp-Source: ABdhPJzCyUmriiv85gVTXsAz7YRO8gsH/c1cCF2M0EuQJzg9FrgUguOhQcHGD7C2xR2GYSH7/Cm6Gg== X-Received: by 2002:adf:f6cc:: with SMTP id y12mr8255114wrp.35.1610015108280; Thu, 07 Jan 2021 02:25:08 -0800 (PST) Received: from localhost (host86-166-129-230.range86-166.btcentralplus.com. [86.166.129.230]) by smtp.gmail.com with ESMTPSA id w4sm6828562wmc.13.2021.01.07.02.25.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Jan 2021 02:25:07 -0800 (PST) Date: Thu, 7 Jan 2021 10:25:06 +0000 From: Andrew Burgess To: gdb-patches@sourceware.org Subject: Re: [PATCHv6 0/2] Restore thread and frame patches Message-ID: <20210107102506.GP2945@embecosm.com> References: <20201112115914.3702451-1-andrew.burgess@embecosm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux/5.8.13-100.fc31.x86_64 (x86_64) X-Uptime: 10:11:39 up 29 days, 14:56, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Ping! I'd like to ask if anyone has any objections to these patches being merged? My original attempt to merge at least part of this series[1] back in March last year did get some positive feedback, and I was about to merge until Pedro objected. I do honestly believe that I have now addressed Pedro's objections which I interpreted as: 1. Changing existing default behaviour might be confusing: - This feature is off by default now. 2. Restoring "some" bits of state without restoring "all" bits of state (examples given were fibers, coroutines, etc) would be confusing. - Again, by having this off by default a user has to opt in to restore those features that we support restoring. As a result it should not (I think) be confusing. That is, if a user turns on "restore thread" then of course only threads will be restored. They might then complain that there's no "restore coroutine" or "restore fiber" flag, but I'd be OK with that. 3. Pedro expressed that he finds the current behaviour more intuitive. - I respectively disagree, but again, by being off be default I think anyone who prefers the current behaviour will not be put out. I've not heard back from Pedro since I posted the latest version of this series in Sep last year, but I would like to hear if anyone has either new concerns about this change, or if anyone feels that Pedro's original concerns have not been addressed. Thanks for your time, Andrew [1] https://sourceware.org/pipermail/gdb-patches/2020-March/167061.html * Andrew Burgess [2020-12-10 11:39:03 +0000]: > Compared to v5: > > + Minor tweak to one comment in patch #2 (added a comma). > + Rebased onto current master. > > Still hoping for Pedro to review this series in comparison to the > original patches he objected to. > > Thanks, > Andrew > > > --- > > Andrew Burgess (2): > gdb: Restore previously selected thread when switching inferior > gdb: Track the current frame for each thread > > gdb/ChangeLog | 34 ++ > gdb/NEWS | 20 ++ > gdb/doc/ChangeLog | 14 + > gdb/doc/gdb.texinfo | 42 ++- > gdb/frame.c | 26 ++ > gdb/gdbthread.h | 13 +- > gdb/inferior.c | 58 ++- > gdb/inferior.h | 9 + > gdb/testsuite/ChangeLog | 10 + > .../gdb.threads/restore-selected-frame.c | 85 +++++ > .../gdb.threads/restore-selected-frame.exp | 336 ++++++++++++++++++ > gdb/testsuite/gdb.threads/restore-thread.c | 248 +++++++++++++ > gdb/testsuite/gdb.threads/restore-thread.exp | 219 ++++++++++++ > gdb/thread.c | 61 +++- > 14 files changed, 1160 insertions(+), 15 deletions(-) > create mode 100644 gdb/testsuite/gdb.threads/restore-selected-frame.c > create mode 100644 gdb/testsuite/gdb.threads/restore-selected-frame.exp > create mode 100644 gdb/testsuite/gdb.threads/restore-thread.c > create mode 100644 gdb/testsuite/gdb.threads/restore-thread.exp > > -- > 2.25.4 >