From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id yFZfBJmY718DTQAAWB0awg (envelope-from ) for ; Fri, 01 Jan 2021 16:48:09 -0500 Received: by simark.ca (Postfix, from userid 112) id 0A7741F0AA; Fri, 1 Jan 2021 16:48:09 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED, MAILING_LIST_MULTI,T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E87571F0B7 for ; Fri, 1 Jan 2021 16:48:07 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9AF733890422; Fri, 1 Jan 2021 21:47:58 +0000 (GMT) Received: from gateway33.websitewelcome.com (gateway33.websitewelcome.com [192.185.146.130]) by sourceware.org (Postfix) with ESMTPS id EAEBD389041B for ; Fri, 1 Jan 2021 21:47:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org EAEBD389041B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway33.websitewelcome.com (Postfix) with ESMTP id 8C6D2B9EB49 for ; Fri, 1 Jan 2021 15:47:53 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id vSH3kzaueDT64vSH3k78yX; Fri, 01 Jan 2021 15:47:53 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=syiZHxmn52B2E7TSOtEQZVTYFHS1eZ0oLob3sbaqpyY=; b=MRxBS/FFF9ThjN/eGzi39hzE3r oKNWRtvxtKfUNREiVOem2wdshKWulI7RrxE9jcaMkHxlC7mwgpWpvqPFO146/Usft/aSE2nbyExce CH36wyJf1q+u5z7NiBJXg6+bA; Received: from 97-122-81-39.hlrn.qwest.net ([97.122.81.39]:60386 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1kvSH3-0029HC-Bn for gdb-patches@sourceware.org; Fri, 01 Jan 2021 14:47:53 -0700 From: Tom Tromey To: gdb-patches@sourceware.org Subject: [PATCH 062/203] Split out ada_abs Date: Fri, 1 Jan 2021 14:45:02 -0700 Message-Id: <20210101214723.1784144-63-tom@tromey.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210101214723.1784144-1-tom@tromey.com> References: <20210101214723.1784144-1-tom@tromey.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.81.39 X-Source-L: No X-Exim-ID: 1kvSH3-0029HC-Bn X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-81-39.hlrn.qwest.net (localhost.localdomain) [97.122.81.39]:60386 X-Source-Auth: tom+tromey.com X-Email-Count: 63 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" This splits UNOP_ABS into a new function for future use. gdb/ChangeLog 2021-01-01 Tom Tromey * ada-lang.c (ada_abs): New function. (ada_evaluate_subexp): Use it. --- gdb/ChangeLog | 5 +++++ gdb/ada-lang.c | 21 ++++++++++++++++----- 2 files changed, 21 insertions(+), 5 deletions(-) diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c index 203648ade02..a1468b81e05 100644 --- a/gdb/ada-lang.c +++ b/gdb/ada-lang.c @@ -10201,6 +10201,21 @@ ada_atr_size (struct type *expect_type, TARGET_CHAR_BIT * TYPE_LENGTH (type)); } +/* A helper function for UNOP_ABS. */ + +static value * +ada_abs (struct type *expect_type, + struct expression *exp, + enum noside noside, enum exp_opcode op, + struct value *arg1) +{ + unop_promote (exp->language_defn, exp->gdbarch, &arg1); + if (value_less (arg1, value_zero (value_type (arg1), not_lval))) + return value_neg (arg1); + else + return arg1; +} + /* Implement the evaluate_exp routine in the exp_descriptor structure for the Ada language. */ @@ -11025,11 +11040,7 @@ ada_evaluate_subexp (struct type *expect_type, struct expression *exp, arg1 = evaluate_subexp (nullptr, exp, pos, noside); if (noside == EVAL_SKIP) goto nosideret; - unop_promote (exp->language_defn, exp->gdbarch, &arg1); - if (value_less (arg1, value_zero (value_type (arg1), not_lval))) - return value_neg (arg1); - else - return arg1; + return ada_abs (expect_type, exp, noside, op, arg1); case UNOP_IND: preeval_pos = *pos; -- 2.26.2