Re: [PATCH 003/203] Split out eval_op_var_msym_value

Tom Tromey
2021-02-13T19:37:27Z

>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:

>>
>> +static struct value *
>> +eval_op_var_msym_value (struct type *expect_type, struct expression *exp,
>> + enum noside noside,
>> + minimal_symbol *msymbol, struct objfile *objfile)

Andrew> The first couple of patches included a header comment for these new
Andrew> helper functions. Starting from this patch these header comments are
Andrew> hit and miss.

Andrew> Maybe these should be added? I haven't commented on each patch where
Andrew> this is an issue, that didn't feel very helpful.

I went through the "Split" patches and I've added comments where they
were missing.

Tom