Re: [PATCH 073/203] Introduce class operation

Tom Tromey
2021-02-10T00:57:47Z

>>> +typedef std::unique_ptr<operation> operation_up;

>> FWIW, the connection between "up" and the rest of the declaration
>> wasn't immediately obvious to me. I think this is because "up"
>> is an english word, and spelled like that, all in lowercase,
>> that's really what my brain keeps analyzing it as first. It takes
>> an effort to adjust my thinking against this bias.

Lancelot> I am fairly new to this codebase, but as far as I can say, this sort
Lancelot> of naming convention (the _up suffix for a typedefed std::unique_ptr)
Lancelot> is already used here and there:

Lancelot> $ git grep 'typedef std::unique_ptr.*_up;'|wc -l
Lancelot> 33

Lancelot> I have to admin that the first time I came across it it was not
Lancelot> obvious to me either, but it would make sense to keep it this way for
Lancelot> consistency (I guess).

Yeah, IIRC the "_up" suffix (for "unique pointer") was introduced a
while back by Pedro; this is just following the existing naming
convention.

Tom