Re: [PATCH 151/203] Split out some Ada type resolution code

Tom Tromey
2021-02-13T19:48:03Z

>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:

Joel> Hi Tom,
Joel> On Fri, Jan 01, 2021 at 02:46:31PM -0700, Tom Tromey wrote:
>> This splits some Ada type resolution code out of resolve_subexp into
>> new functions that can be reused.
>>
>> gdb/ChangeLog
>> 2021-01-01 Tom Tromey <tom@tromey.com>
>>
>> * ada-lang.h (ada_find_operator_symbol, ada_resolve_funcall)
>> (ada_resolve_variable): Declare.
>> * ada-lang.c (ada_find_operator_symbol, ada_resolve_funcall)
>> (ada_resolve_variable): New functions.
>> (resolve_subexp): Update.

Joel> Could this patch go in early, and independently of this patch series
Joel> (or perhaps right after the first third of the patches splitting
Joel> the various eval routines go in)?

It could but it's simpler for me to keep the series as-is.

Joel> As far as I can tell, all it needs is documentation of the new routines
Joel> in ada-lang.h. Other than that, this patch looks like a nice little
Joel> improvement of the code's organization.

I've added some comments.

Tom