Re: [PATCH 009/203] what is this code for

Tom Tromey
2021-02-11T02:25:43Z

>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:

Simon> In addition to this good explanation: I tried removing the `|| pc == 0`
Simon> from the code (based on current master) and got these failures:

Simon> +FAIL: gdb.base/nodebug.exp: p sizeof(dataglobal + 1)
Simon> +FAIL: gdb.base/nodebug.exp: ptype *dataglobal
Simon> +FAIL: gdb.base/nodebug.exp: ptype dataglobal + 1
Simon> +FAIL: gdb.base/nodebug.exp: ptype sizeof(dataglobal + 1)
Simon> +FAIL: gdb.base/nodebug.exp: whatis *dataglobal
Simon> +FAIL: gdb.base/nodebug.exp: whatis dataglobal + 1
Simon> +FAIL: gdb.base/nodebug.exp: whatis sizeof(dataglobal + 1)

Simon> So it's already covered. Tom, are these cases correctly handled with
Simon> this series applied?

It wasn't, which I don't understand, since I regression tested this.
I wonder if the comparison script I am using is buggy.

Anyway, I have reimplemented this feature in the new version of the
series, these tests work now. There's one more failure in nodebug.exp
that I have yet to track down - in one case, the error message has
changed.

Tom