Re: [PATCH 000/203] Refactor expressions

Tom Tromey
2021-02-13T19:54:35Z

>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:

Joel> For me, I've gone through the patches, more or less carefully
Joel> based on a random sample, and they look good. I paused a bit
Joel> about the Ada ones, were you excluded the hanlding of noside ==
Joel> EVAL_SKIP. I'm not entirely sure why that is, perhaps because
Joel> the block consists in a goto nosideret? Looking at what that
Joel> nosideret does, it's just...

Joel> | nosideret:
Joel> | return eval_skip_value (exp);

Joel> ... so we could inline this in the new functions.

There's no need for EVAL_SKIP in the new code. This was just an
artifact of how the expression objects were laid out in memory.

It's possible that this series has intermediate states that fail in some
way. I didn't test every patch in isolation. I suppose I should do
that, I have just been avoiding it since on my home machine, a test run
is ~15 minutes, which works out to 50 hours for this series.

I'm ready to send v2 of the series. I think I'll save the individual
regression test and fixes for v3.

Tom