From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4BmDCoqY718DTQAAWB0awg (envelope-from ) for ; Fri, 01 Jan 2021 16:47:54 -0500 Received: by simark.ca (Postfix, from userid 112) id 490641F0BC; Fri, 1 Jan 2021 16:47:52 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.4 required=5.0 tests=DKIM_SIGNED,MAILING_LIST_MULTI, RDNS_NONE,T_DKIM_INVALID,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 854B21E590 for ; Fri, 1 Jan 2021 16:47:51 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 32FBC3842438; Fri, 1 Jan 2021 21:47:47 +0000 (GMT) Received: from gateway36.websitewelcome.com (gateway36.websitewelcome.com [192.185.187.5]) by sourceware.org (Postfix) with ESMTPS id 7CD3F3842402 for ; Fri, 1 Jan 2021 21:47:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7CD3F3842402 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 28445400C8ADB for ; Fri, 1 Jan 2021 15:47:44 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id vSGukyO0lsvw9vSGukLu1y; Fri, 01 Jan 2021 15:47:44 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Jayi1VwZ0S9tOaAkNBulco3dPhhDujwVMflA4/+cETI=; b=pDBCAf3cuhpf29/6G5ImrZJjV+ fIEt9Q/fxBhXVW3mXaGGHrDA3itL8SZ7OQS0q8l7KLiEhHkf8LlenURhvfXC/DfvskouhBcpQfvKt x7avHdf5s/SIA0iYWC2HfZXeh; Received: from 97-122-81-39.hlrn.qwest.net ([97.122.81.39]:60382 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1kvSGt-0029BJ-VH for gdb-patches@sourceware.org; Fri, 01 Jan 2021 14:47:44 -0700 From: Tom Tromey To: gdb-patches@sourceware.org Subject: [PATCH 037/203] Split out eval_op_f_abs Date: Fri, 1 Jan 2021 14:44:37 -0700 Message-Id: <20210101214723.1784144-38-tom@tromey.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210101214723.1784144-1-tom@tromey.com> References: <20210101214723.1784144-1-tom@tromey.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.81.39 X-Source-L: No X-Exim-ID: 1kvSGt-0029BJ-VH X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-81-39.hlrn.qwest.net (localhost.localdomain) [97.122.81.39]:60382 X-Source-Auth: tom+tromey.com X-Email-Count: 38 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" This splits UNOP_ABS into a new function for future use. gdb/ChangeLog 2021-01-01 Tom Tromey * f-lang.c (eval_op_f_abs): New function. (evaluate_subexp_f): Use it. --- gdb/ChangeLog | 5 +++++ gdb/f-lang.c | 50 ++++++++++++++++++++++++++++++-------------------- 2 files changed, 35 insertions(+), 20 deletions(-) diff --git a/gdb/f-lang.c b/gdb/f-lang.c index da66ba8361f..2098a89e133 100644 --- a/gdb/f-lang.c +++ b/gdb/f-lang.c @@ -702,6 +702,35 @@ fortran_value_subarray (struct value *array, struct expression *exp, return array; } +/* A helper function for UNOP_ABS. */ + +static struct value * +eval_op_f_abs (struct type *expect_type, struct expression *exp, + enum noside noside, + struct value *arg1) +{ + if (noside == EVAL_SKIP) + return eval_skip_value (exp); + struct type *type = value_type (arg1); + switch (type->code ()) + { + case TYPE_CODE_FLT: + { + double d + = fabs (target_float_to_host_double (value_contents (arg1), + value_type (arg1))); + return value_from_host_double (type, d); + } + case TYPE_CODE_INT: + { + LONGEST l = value_as_long (arg1); + l = llabs (l); + return value_from_longest (type, l); + } + } + error (_("ABS of type %s not supported"), TYPE_SAFE_NAME (type)); +} + /* Special expression evaluation cases for Fortran. */ static struct value * @@ -725,26 +754,7 @@ evaluate_subexp_f (struct type *expect_type, struct expression *exp, case UNOP_ABS: arg1 = evaluate_subexp (nullptr, exp, pos, noside); - if (noside == EVAL_SKIP) - return eval_skip_value (exp); - type = value_type (arg1); - switch (type->code ()) - { - case TYPE_CODE_FLT: - { - double d - = fabs (target_float_to_host_double (value_contents (arg1), - value_type (arg1))); - return value_from_host_double (type, d); - } - case TYPE_CODE_INT: - { - LONGEST l = value_as_long (arg1); - l = llabs (l); - return value_from_longest (type, l); - } - } - error (_("ABS of type %s not supported"), TYPE_SAFE_NAME (type)); + return eval_op_f_abs (expect_type, exp, noside, arg1); case BINOP_MOD: arg1 = evaluate_subexp (nullptr, exp, pos, noside); -- 2.26.2