From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id CKIUMgaZ71/2TAAAWB0awg (envelope-from ) for ; Fri, 01 Jan 2021 16:49:58 -0500 Received: by simark.ca (Postfix, from userid 112) id 982B91F0AA; Fri, 1 Jan 2021 16:49:56 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.4 required=5.0 tests=DKIM_SIGNED,MAILING_LIST_MULTI, RDNS_NONE,T_DKIM_INVALID,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4307E1F0CC for ; Fri, 1 Jan 2021 16:49:47 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6A5A8384402D; Fri, 1 Jan 2021 21:49:14 +0000 (GMT) Received: from gateway30.websitewelcome.com (gateway30.websitewelcome.com [192.185.152.11]) by sourceware.org (Postfix) with ESMTPS id 92D2D393BC10 for ; Fri, 1 Jan 2021 21:49:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 92D2D393BC10 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway30.websitewelcome.com (Postfix) with ESMTP id 3E29C46F3 for ; Fri, 1 Jan 2021 15:49:07 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id vSIFkJB1JuDoAvSIFkccwP; Fri, 01 Jan 2021 15:49:07 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=LE8isTL5NLHc6msg/Z6oDuddYOgLLm1lmDZekU3jJfM=; b=OzmEA6AFluvUoqqrL7gmNBEvX5 KdLfYJXMUZXL0J5z/Deb76sipLU10Mg3RKubrYQLWuD3Sc7+s/tEsR92manljgMipLmb+nvNtmsDR SU3yohYLOqyT/B+nsNDEYRwfR; Received: from 97-122-81-39.hlrn.qwest.net ([97.122.81.39]:60430 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1kvSIF-002A5T-1Z for gdb-patches@sourceware.org; Fri, 01 Jan 2021 14:49:07 -0700 From: Tom Tromey To: gdb-patches@sourceware.org Subject: [PATCH 203/203] Remove some null checks Date: Fri, 1 Jan 2021 14:47:23 -0700 Message-Id: <20210101214723.1784144-204-tom@tromey.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210101214723.1784144-1-tom@tromey.com> References: <20210101214723.1784144-1-tom@tromey.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.81.39 X-Source-L: No X-Exim-ID: 1kvSIF-002A5T-1Z X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-81-39.hlrn.qwest.net (localhost.localdomain) [97.122.81.39]:60430 X-Source-Auth: tom+tromey.com X-Email-Count: 204 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" When not parsing for completion, parse_expression ensures that the resulting expression has operations. This patch removes a couple of unnecessary checks for this situation. gdb/ChangeLog 2021-01-01 Tom Tromey * printcmd.c (set_command): Remove null check. * value.c (init_if_undefined_command): Remove null check. --- gdb/ChangeLog | 5 +++++ gdb/printcmd.c | 29 ++++++++++++++--------------- gdb/value.c | 2 +- 3 files changed, 20 insertions(+), 16 deletions(-) diff --git a/gdb/printcmd.c b/gdb/printcmd.c index 484a2dbf228..c3e75de0bce 100644 --- a/gdb/printcmd.c +++ b/gdb/printcmd.c @@ -1373,21 +1373,20 @@ set_command (const char *exp, int from_tty) { expression_up expr = parse_expression (exp); - if (expr->op != nullptr) - switch (expr->op->opcode ()) - { - case UNOP_PREINCREMENT: - case UNOP_POSTINCREMENT: - case UNOP_PREDECREMENT: - case UNOP_POSTDECREMENT: - case BINOP_ASSIGN: - case BINOP_ASSIGN_MODIFY: - case BINOP_COMMA: - break; - default: - warning - (_("Expression is not an assignment (and might have no effect)")); - } + switch (expr->op->opcode ()) + { + case UNOP_PREINCREMENT: + case UNOP_POSTINCREMENT: + case UNOP_PREDECREMENT: + case UNOP_POSTDECREMENT: + case BINOP_ASSIGN: + case BINOP_ASSIGN_MODIFY: + case BINOP_COMMA: + break; + default: + warning + (_("Expression is not an assignment (and might have no effect)")); + } evaluate_expression (expr.get ()); } diff --git a/gdb/value.c b/gdb/value.c index 7a9128df642..1bd43a53db6 100644 --- a/gdb/value.c +++ b/gdb/value.c @@ -1982,7 +1982,7 @@ init_if_undefined_command (const char* args, int from_tty) /* Validate the expression. Was the expression an assignment? Or even an expression at all? */ - if (expr->op == nullptr || expr->first_opcode () != BINOP_ASSIGN) + if (expr->first_opcode () != BINOP_ASSIGN) error (_("Init-if-undefined requires an assignment expression.")); /* Extract the variable from the parsed expression. */ -- 2.26.2