From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id QK+HJHSY718DTQAAWB0awg (envelope-from ) for ; Fri, 01 Jan 2021 16:47:32 -0500 Received: by simark.ca (Postfix, from userid 112) id 798F31F0BC; Fri, 1 Jan 2021 16:47:32 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED, MAILING_LIST_MULTI,T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 993D61F071 for ; Fri, 1 Jan 2021 16:47:30 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CD25A3846034; Fri, 1 Jan 2021 21:47:29 +0000 (GMT) Received: from gateway31.websitewelcome.com (gateway31.websitewelcome.com [192.185.143.47]) by sourceware.org (Postfix) with ESMTPS id 98153384640D for ; Fri, 1 Jan 2021 21:47:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 98153384640D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 129C22903A for ; Fri, 1 Jan 2021 15:47:26 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id vSGbk10URiQiZvSGbki7gH; Fri, 01 Jan 2021 15:47:26 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ca34hRmaND7N1uQfrFZ3da4rqBXxu3nojQX/UNd3wS8=; b=rE17Z0pP4wT1T3vHLPwwD93Mq6 2y8BmYkrPv/oraQrZWnh9AlH4VldA6DFr5y0crhHvLBzBG4ZqWavBoIGL/oA+29Q8L8dT/+P6J8/S xCmXYeTXunCV4rLch+gRyVH97; Received: from 97-122-81-39.hlrn.qwest.net ([97.122.81.39]:60372 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1kvSGb-0028yz-Px for gdb-patches@sourceware.org; Fri, 01 Jan 2021 14:47:25 -0700 From: Tom Tromey To: gdb-patches@sourceware.org Subject: [PATCH 001/203] Split out eval_op_scope Date: Fri, 1 Jan 2021 14:44:01 -0700 Message-Id: <20210101214723.1784144-2-tom@tromey.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210101214723.1784144-1-tom@tromey.com> References: <20210101214723.1784144-1-tom@tromey.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.81.39 X-Source-L: No X-Exim-ID: 1kvSGb-0028yz-Px X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-81-39.hlrn.qwest.net (localhost.localdomain) [97.122.81.39]:60372 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" This splits OP_SCOPE into a new function for future use. gdb/ChangeLog 2021-01-01 Tom Tromey * eval.c (eval_op_scope): New function. (evaluate_subexp_standard): Use it. --- gdb/ChangeLog | 5 +++++ gdb/eval.c | 27 +++++++++++++++++++-------- 2 files changed, 24 insertions(+), 8 deletions(-) diff --git a/gdb/eval.c b/gdb/eval.c index e63511b7005..74123b0d13f 100644 --- a/gdb/eval.c +++ b/gdb/eval.c @@ -1179,6 +1179,22 @@ is_integral_or_integral_reference (struct type *type) && is_integral_type (TYPE_TARGET_TYPE (type))); } +/* Helper function that implements the body of OP_SCOPE. */ + +static struct value * +eval_op_scope (struct type *expect_type, struct expression *exp, + enum noside noside, + struct type *type, const char *string) +{ + if (noside == EVAL_SKIP) + return eval_skip_value (exp); + struct value *arg1 = value_aggregate_elt (type, string, expect_type, + 0, noside); + if (arg1 == NULL) + error (_("There is no field named %s"), string); + return arg1; +} + struct value * evaluate_subexp_standard (struct type *expect_type, struct expression *exp, int *pos, @@ -1205,14 +1221,9 @@ evaluate_subexp_standard (struct type *expect_type, case OP_SCOPE: tem = longest_to_int (exp->elts[pc + 2].longconst); (*pos) += 4 + BYTES_TO_EXP_ELEM (tem + 1); - if (noside == EVAL_SKIP) - return eval_skip_value (exp); - arg1 = value_aggregate_elt (exp->elts[pc + 1].type, - &exp->elts[pc + 3].string, - expect_type, 0, noside); - if (arg1 == NULL) - error (_("There is no field named %s"), &exp->elts[pc + 3].string); - return arg1; + return eval_op_scope (expect_type, exp, noside, + exp->elts[pc + 1].type, + &exp->elts[pc + 3].string); case OP_LONG: (*pos) += 3; -- 2.26.2