From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4FsGHQaZ71/2TAAAWB0awg (envelope-from ) for ; Fri, 01 Jan 2021 16:49:58 -0500 Received: by simark.ca (Postfix, from userid 112) id 4765B1E590; Fri, 1 Jan 2021 16:49:53 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.4 required=5.0 tests=DKIM_SIGNED,MAILING_LIST_MULTI, RDNS_NONE,T_DKIM_INVALID,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 479291F0AA for ; Fri, 1 Jan 2021 16:49:45 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1619E393BC25; Fri, 1 Jan 2021 21:49:11 +0000 (GMT) Received: from gateway33.websitewelcome.com (gateway33.websitewelcome.com [192.185.146.130]) by sourceware.org (Postfix) with ESMTPS id 3A1743939C2A for ; Fri, 1 Jan 2021 21:49:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3A1743939C2A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway33.websitewelcome.com (Postfix) with ESMTP id B374A352C for ; Fri, 1 Jan 2021 15:49:03 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id vSIBkzbXeDT64vSIBk79b2; Fri, 01 Jan 2021 15:49:03 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=x7b7XdWMIKZvBd3XdtxVXyZvg0TsEFISDJYZloInojI=; b=aUsTd3V9DyuUweCDlhDLNWKDZ+ AQEGAXNzyIVuZZ+Crsu/mFcpDPDZwSGoW+ntwq6WZn4IsQ+9udoY6zVYy8UA7/j1vg0JqDmaekowb 0zL9mimW1/t/np5E6FaJWANYj; Received: from 97-122-81-39.hlrn.qwest.net ([97.122.81.39]:60428 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1kvSIB-002A3B-Hg for gdb-patches@sourceware.org; Fri, 01 Jan 2021 14:49:03 -0700 From: Tom Tromey To: gdb-patches@sourceware.org Subject: [PATCH 197/203] Inline expression constructor Date: Fri, 1 Jan 2021 14:47:17 -0700 Message-Id: <20210101214723.1784144-198-tom@tromey.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210101214723.1784144-1-tom@tromey.com> References: <20210101214723.1784144-1-tom@tromey.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.81.39 X-Source-L: No X-Exim-ID: 1kvSIB-002A3B-Hg X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-81-39.hlrn.qwest.net (localhost.localdomain) [97.122.81.39]:60428 X-Source-Auth: tom+tromey.com X-Email-Count: 198 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" The struct expression constructor no longer does any real work, so this inlines it. The default destructor can also be used now as well. gdb/ChangeLog 2021-01-01 Tom Tromey * parse.c (expression::expression, expression::~expression): Remove. * expression.h (struct expression): Inline constructor. Remove destructor. --- gdb/ChangeLog | 7 +++++++ gdb/expression.h | 8 ++++++-- gdb/parse.c | 10 ---------- 3 files changed, 13 insertions(+), 12 deletions(-) diff --git a/gdb/expression.h b/gdb/expression.h index 3f0ab4ec38b..83bfe753d84 100644 --- a/gdb/expression.h +++ b/gdb/expression.h @@ -181,8 +181,12 @@ make_operation (Arg... args) struct expression { - expression (const struct language_defn *, struct gdbarch *); - ~expression (); + expression (const struct language_defn *lang, struct gdbarch *arch) + : language_defn (lang), + gdbarch (arch) + { + } + DISABLE_COPY_AND_ASSIGN (expression); /* Return the opcode for the outermost sub-expression of this diff --git a/gdb/parse.c b/gdb/parse.c index 637a9f3d246..0c4a2c6fa01 100644 --- a/gdb/parse.c +++ b/gdb/parse.c @@ -105,16 +105,6 @@ expr_builder::release () return std::move (expout); } -expression::expression (const struct language_defn *lang, struct gdbarch *arch) - : language_defn (lang), - gdbarch (arch) -{ -} - -expression::~expression () -{ -} - /* Return the type of MSYMBOL, a minimal symbol of OBJFILE. If ADDRESS_P is not NULL, set it to the MSYMBOL's resolved address. */ -- 2.26.2