From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 2EXAJraY718DTQAAWB0awg (envelope-from ) for ; Fri, 01 Jan 2021 16:48:38 -0500 Received: by simark.ca (Postfix, from userid 112) id 83C951F071; Fri, 1 Jan 2021 16:48:36 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: * X-Spam-Status: No, score=1.6 required=5.0 tests=DKIM_SIGNED,MAILING_LIST_MULTI, RCVD_IN_BL_SPAMCOP_NET,RDNS_NONE,T_DKIM_INVALID,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A74111E590 for ; Fri, 1 Jan 2021 16:48:35 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3DE41381DCCD; Fri, 1 Jan 2021 21:48:17 +0000 (GMT) Received: from gateway33.websitewelcome.com (gateway33.websitewelcome.com [192.185.146.130]) by sourceware.org (Postfix) with ESMTPS id B16B53893646 for ; Fri, 1 Jan 2021 21:48:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B16B53893646 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway33.websitewelcome.com (Postfix) with ESMTP id 599ABEEF2DC for ; Fri, 1 Jan 2021 15:48:14 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id vSHOkZEnUoE4DvSHOkuHCv; Fri, 01 Jan 2021 15:48:14 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=WREPxUkj/1OP1PLHQa+bKHr+Ha6CYz33p/B/Ccn/oZU=; b=a0L8pGjGg+mg4wb9Z0hy1Wzlvp cQvHSq6aLAQDW/cYYgmLRvHM2bqzS3e8o/Ag64gXqO+GArqMfx1SbY3sCwKCcq7SvjdA+PI4MZ2Tv 86CwZdjexieCzlO7i8m0uaGMv; Received: from 97-122-81-39.hlrn.qwest.net ([97.122.81.39]:60400 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1kvSHO-0029XH-2R for gdb-patches@sourceware.org; Fri, 01 Jan 2021 14:48:14 -0700 From: Tom Tromey To: gdb-patches@sourceware.org Subject: [PATCH 101/203] Implement binary comparison operations Date: Fri, 1 Jan 2021 14:45:41 -0700 Message-Id: <20210101214723.1784144-102-tom@tromey.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210101214723.1784144-1-tom@tromey.com> References: <20210101214723.1784144-1-tom@tromey.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.81.39 X-Source-L: No X-Exim-ID: 1kvSHO-0029XH-2R X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-81-39.hlrn.qwest.net (localhost.localdomain) [97.122.81.39]:60400 X-Source-Auth: tom+tromey.com X-Email-Count: 102 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" This implements the binary comparison operations via a template class. gdb/ChangeLog 2021-01-01 Tom Tromey * expop.h (class comparison_operation): New. (equal_operation, notequal_operation, less_operation) (gtr_operation, geq_operation, leq_operation): New typedefs. * eval.c (eval_op_equal, eval_op_notequal, eval_op_less) (eval_op_gtr, eval_op_geq, eval_op_leq): No longer static. --- gdb/ChangeLog | 8 +++++++ gdb/eval.c | 12 +++++------ gdb/expop.h | 60 +++++++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 74 insertions(+), 6 deletions(-) diff --git a/gdb/eval.c b/gdb/eval.c index e67842dea57..e9c4a1fffd0 100644 --- a/gdb/eval.c +++ b/gdb/eval.c @@ -1579,7 +1579,7 @@ eval_op_subscript (struct type *expect_type, struct expression *exp, /* A helper function for BINOP_EQUAL. */ -static struct value * +struct value * eval_op_equal (struct type *expect_type, struct expression *exp, enum noside noside, enum exp_opcode op, struct value *arg1, struct value *arg2) @@ -1602,7 +1602,7 @@ eval_op_equal (struct type *expect_type, struct expression *exp, /* A helper function for BINOP_NOTEQUAL. */ -static struct value * +struct value * eval_op_notequal (struct type *expect_type, struct expression *exp, enum noside noside, enum exp_opcode op, struct value *arg1, struct value *arg2) @@ -1625,7 +1625,7 @@ eval_op_notequal (struct type *expect_type, struct expression *exp, /* A helper function for BINOP_LESS. */ -static struct value * +struct value * eval_op_less (struct type *expect_type, struct expression *exp, enum noside noside, enum exp_opcode op, struct value *arg1, struct value *arg2) @@ -1648,7 +1648,7 @@ eval_op_less (struct type *expect_type, struct expression *exp, /* A helper function for BINOP_GTR. */ -static struct value * +struct value * eval_op_gtr (struct type *expect_type, struct expression *exp, enum noside noside, enum exp_opcode op, struct value *arg1, struct value *arg2) @@ -1671,7 +1671,7 @@ eval_op_gtr (struct type *expect_type, struct expression *exp, /* A helper function for BINOP_GEQ. */ -static struct value * +struct value * eval_op_geq (struct type *expect_type, struct expression *exp, enum noside noside, enum exp_opcode op, struct value *arg1, struct value *arg2) @@ -1694,7 +1694,7 @@ eval_op_geq (struct type *expect_type, struct expression *exp, /* A helper function for BINOP_LEQ. */ -static struct value * +struct value * eval_op_leq (struct type *expect_type, struct expression *exp, enum noside noside, enum exp_opcode op, struct value *arg1, struct value *arg2) diff --git a/gdb/expop.h b/gdb/expop.h index 556ceaa1e87..27264562a4e 100644 --- a/gdb/expop.h +++ b/gdb/expop.h @@ -104,6 +104,36 @@ extern struct value *eval_op_subscript (struct type *expect_type, enum noside noside, enum exp_opcode op, struct value *arg1, struct value *arg2); +extern struct value *eval_op_equal (struct type *expect_type, + struct expression *exp, + enum noside noside, enum exp_opcode op, + struct value *arg1, + struct value *arg2); +extern struct value *eval_op_notequal (struct type *expect_type, + struct expression *exp, + enum noside noside, enum exp_opcode op, + struct value *arg1, + struct value *arg2); +extern struct value *eval_op_less (struct type *expect_type, + struct expression *exp, + enum noside noside, enum exp_opcode op, + struct value *arg1, + struct value *arg2); +extern struct value *eval_op_gtr (struct type *expect_type, + struct expression *exp, + enum noside noside, enum exp_opcode op, + struct value *arg1, + struct value *arg2); +extern struct value *eval_op_geq (struct type *expect_type, + struct expression *exp, + enum noside noside, enum exp_opcode op, + struct value *arg1, + struct value *arg2); +extern struct value *eval_op_leq (struct type *expect_type, + struct expression *exp, + enum noside noside, enum exp_opcode op, + struct value *arg1, + struct value *arg2); namespace expr { @@ -1117,6 +1147,36 @@ class subscript_operation enum noside noside) override; }; +/* Implementation of comparison operations. */ +template +class comparison_operation + : public usual_ax_binop_operation +{ +public: + + using usual_ax_binop_operation::usual_ax_binop_operation; + + value *evaluate (struct type *expect_type, + struct expression *exp, + enum noside noside) override + { + value *lhs + = std::get<0> (this->m_storage)->evaluate (nullptr, exp, noside); + value *rhs + = std::get<1> (this->m_storage)->evaluate (value_type (lhs), exp, + noside); + return FUNC (expect_type, exp, noside, OP, lhs, rhs); + } +}; + +using equal_operation = comparison_operation; +using notequal_operation + = comparison_operation; +using less_operation = comparison_operation; +using gtr_operation = comparison_operation; +using geq_operation = comparison_operation; +using leq_operation = comparison_operation; + } /* namespace expr */ #endif /* EXPOP_H */ -- 2.26.2