From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id +M84Ozyf7F8ACwAAWB0awg (envelope-from ) for ; Wed, 30 Dec 2020 10:39:40 -0500 Received: by simark.ca (Postfix, from userid 112) id E95CC1F0BA; Wed, 30 Dec 2020 10:39:40 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_NONE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9D3321F0B7 for ; Wed, 30 Dec 2020 10:39:38 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E1C4E388C037; Wed, 30 Dec 2020 15:39:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E1C4E388C037 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1609342777; bh=e0YR5fNI0f7n8DG7JdPBNLJD+KPqc98VoAp280kVtv0=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Y5rmRWdSr3bcK5gNx6fYpGCk44lpxiIs/JDDMnnj4sniYj+bUP2fJmfcEVt+J+0uA k2NHJl0DKs+1jSWbH1pRzgTrupnq5oWrr66nI07O82Y2qzqbMW3FBjpycy2hWvouxW uqPS+WYXcCCHVGDwofzagQgzF+gTxgzJ9F9yArbE= Received: from mail-qt1-x82e.google.com (mail-qt1-x82e.google.com [IPv6:2607:f8b0:4864:20::82e]) by sourceware.org (Postfix) with ESMTPS id 4363F388C029 for ; Wed, 30 Dec 2020 15:39:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 4363F388C029 Received: by mail-qt1-x82e.google.com with SMTP id h19so11107114qtq.13 for ; Wed, 30 Dec 2020 07:39:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=e0YR5fNI0f7n8DG7JdPBNLJD+KPqc98VoAp280kVtv0=; b=hka2f2J2gGGBYAOjIxSrEGlnxjIZJ6RSisnOPrcts4IqkeaOwdLoewW+9j7cB9Jmh4 22F8GPechY7owryloL2WKsyM/LbPamCK0DQoAOswxY0l5qhiHqjs07hEFcE4tWXBFCXu a1HJqIT3dNWcQb+wC5+qSCcWboWsA+hWuYMwc7XA7yGPTgz6jQdYK+TJZd+aRB0K5i+Q U6yR9FV2s0uxd8BLPYeQTlo/ALNrudTpEQPKTQW7/OUmVq1bKf3qn2CgGOBk1cc5rCva jDkYOM0jFpDyb7NREFlhgzh1h6SArJOwyU9HmdcX+UcvuVwK4MxochxwyrnbUdnpHWbR rPJA== X-Gm-Message-State: AOAM533FwFq3LcjZcbD17UVGKWPrKpeySW8N3f7eP27Ul1bQGu3Q07g+ SFosVEE8m1kb9YrVtLjGGOp6LTKYnBAGUw== X-Google-Smtp-Source: ABdhPJynnKJKFcDNploJjRi+wBuKU+B1zQnSZ1HRs3CBSJMwULjq4wdPK4SP334oa1DpUr3W1lY0gw== X-Received: by 2002:a05:622a:208:: with SMTP id b8mr54442305qtx.124.1609342774713; Wed, 30 Dec 2020 07:39:34 -0800 (PST) Received: from localhost.localdomain ([2804:7f0:8284:370e:c9ba:c4ec:737b:57da]) by smtp.gmail.com with ESMTPSA id f6sm28589336qkh.2.2020.12.30.07.39.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Dec 2020 07:39:34 -0800 (PST) To: gdb-patches@sourceware.org Subject: [PATCH v4 06/25] Unit tests for gdbserver memory tagging remote packets Date: Wed, 30 Dec 2020 12:38:57 -0300 Message-Id: <20201230153916.1586725-7-luis.machado@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201230153916.1586725-1-luis.machado@linaro.org> References: <20201230153916.1586725-1-luis.machado@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Luis Machado via Gdb-patches Reply-To: Luis Machado Cc: david.spickett@linaro.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Updates on v4: - Assert on invalid packet request instead of just returning an error code. Updates on v2: - Update unit tests to cope with additional tag type field in the remote packets. -- Add some unit testing to exercise the functions handling the qMemTags and QMemTags packets as well as feature support. gdbserver/ChangeLog: YYYY-MM-DD Luis Machado * server.cc (test_memory_tagging_functions): New function. (captured_main): Register test_memory_tagging_functions. --- gdbserver/server.cc | 78 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 78 insertions(+) diff --git a/gdbserver/server.cc b/gdbserver/server.cc index 87b18b819c..9368613c58 100644 --- a/gdbserver/server.cc +++ b/gdbserver/server.cc @@ -3644,6 +3644,81 @@ detach_or_kill_for_exit_cleanup () } } +#if GDB_SELF_TEST + +namespace selftests { + +static void +test_memory_tagging_functions (void) +{ + /* Setup testing. */ + gdb::char_vector packet; + gdb::byte_vector tags, bv; + std::string expected; + packet.resize (32000); + CORE_ADDR addr; + size_t len; + int type; + + /* Test parsing a qMemTags request. */ + + /* Valid request, addr, len and type updated. */ + addr = 0xff; + len = 255; + type = 255; + strcpy (packet.data (), "qMemTags:0,0:0"); + parse_fetch_memtags_request (packet.data (), &addr, &len, &type); + SELF_CHECK (addr == 0 && len == 0 && type == 0); + + /* Valid request, addr, len and type updated. */ + addr = 0; + len = 0; + type = 0; + strcpy (packet.data (), "qMemTags:deadbeef,ff:5"); + parse_fetch_memtags_request (packet.data (), &addr, &len, &type); + SELF_CHECK (addr == 0xdeadbeef && len == 255 && type == 5); + + /* Test creating a qMemTags reply. */ + + /* Non-empty tag data. */ + bv.resize (0); + + for (int i = 0; i < 5; i++) + bv.push_back (i); + + expected = "m0001020304"; + SELF_CHECK (create_fetch_memtags_reply (packet.data (), bv) == true); + SELF_CHECK (strcmp (packet.data (), expected.c_str ()) == 0); + + /* Test parsing a QMemTags request. */ + + /* Valid request and empty tag data: addr, len, type and tags updated. */ + addr = 0xff; + len = 255; + type = 255; + tags.resize (5); + strcpy (packet.data (), "QMemTags:0,0:0:"); + SELF_CHECK (parse_store_memtags_request (packet.data (), + &addr, &len, tags, &type) == true); + SELF_CHECK (addr == 0 && len == 0 && type == 0 && tags.size () == 0); + + /* Valid request and non-empty tag data: addr, len, type + and tags updated. */ + addr = 0; + len = 0; + type = 0; + tags.resize (0); + strcpy (packet.data (), + "QMemTags:deadbeef,ff:5:0001020304"); + SELF_CHECK (parse_store_memtags_request (packet.data (), &addr, &len, tags, + &type) == true); + SELF_CHECK (addr == 0xdeadbeef && len == 255 && type == 5 + && tags.size () == 5); +} + +} // namespace selftests +#endif /* GDB_SELF_TEST */ + /* Main function. This is called by the real "main" function, wrapped in a TRY_CATCH that handles any uncaught exceptions. */ @@ -3661,6 +3736,9 @@ captured_main (int argc, char *argv[]) bool selftest = false; #if GDB_SELF_TEST std::vector selftest_filters; + + selftests::register_test ("remote_memory_tagging", + selftests::test_memory_tagging_functions); #endif current_directory = getcwd (NULL, 0); -- 2.25.1