From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id OcrTHDaf7F8ACwAAWB0awg (envelope-from ) for ; Wed, 30 Dec 2020 10:39:34 -0500 Received: by simark.ca (Postfix, from userid 112) id 685EF1F0AA; Wed, 30 Dec 2020 10:39:34 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_NONE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D7ABC1F075 for ; Wed, 30 Dec 2020 10:39:32 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 69094388C024; Wed, 30 Dec 2020 15:39:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 69094388C024 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1609342772; bh=Y7tMnViMWvfDQ5gL66VMU4wW1gR3MXtR01+GIS3FOhE=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=TVXJ8iIq8/UMTaoTKgG8yWk6yxmq6D93BT/f1/UY+9KkQ0rCIsuICLIpEjFRB8jbR FqMJllebLnBBxQb1PJkGYR1HSqNhCgu/gRVK99TCtoCaKSv2LTlIQrtgiAsnEWSwFn mbiaCUmaKIQIxEE/4EXZDq9Spp0RV0vB4Ote4INU= Received: from mail-qk1-x72d.google.com (mail-qk1-x72d.google.com [IPv6:2607:f8b0:4864:20::72d]) by sourceware.org (Postfix) with ESMTPS id 2B729388C013 for ; Wed, 30 Dec 2020 15:39:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2B729388C013 Received: by mail-qk1-x72d.google.com with SMTP id 19so14151029qkm.8 for ; Wed, 30 Dec 2020 07:39:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Y7tMnViMWvfDQ5gL66VMU4wW1gR3MXtR01+GIS3FOhE=; b=BIUuMjdlJI5EyEzacOc0VnJ7sw+vOxq5LqusEg6wyJJf4VC380zWFbvcsBbg1W6jFX t+7psmlCbp9GugydiuOEi3NCBNcLeZ1/JsitoJGy3m5g1hOwmmwGkglbgZsgMpL+jV53 KXhSFGo5YdIuF3PhrlvhBOHreUsO9egMalFbVB6jL65DL6zzrWg+t/e6iqHC2MSsVk2J 9CEIcxEYMl9jdI+cM/psLO8bbPZQoZeVsmlHa5PIPDGFDsDuGH3Sx6XnCkqzeQWBw7R/ Z4rNnOme9C6nuhL6B6HosWkSmQasS5MOGIeMH+ZjgiSF9OTVhh13o+39rZMANkrSN5o3 9DTg== X-Gm-Message-State: AOAM531/ubDHPbC3ITFwYiUNVcZ8upWshR+Nl7BanVS7BIJYbMvY7dkC GqNRZ+EjTWQd4ryQREt/zcmdST8fkWZwSg== X-Google-Smtp-Source: ABdhPJzbsOQJXaz8Of1MR9VkpwldEuszVAWo94P0jXLRcb8c3/B05J9U0TMgmpAKT+96EqP/mT6rJQ== X-Received: by 2002:a37:9d96:: with SMTP id g144mr51599539qke.441.1609342768501; Wed, 30 Dec 2020 07:39:28 -0800 (PST) Received: from localhost.localdomain ([2804:7f0:8284:370e:c9ba:c4ec:737b:57da]) by smtp.gmail.com with ESMTPSA id f6sm28589336qkh.2.2020.12.30.07.39.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Dec 2020 07:39:28 -0800 (PST) To: gdb-patches@sourceware.org Subject: [PATCH v4 03/25] Add GDB-side remote target support for memory tagging Date: Wed, 30 Dec 2020 12:38:54 -0300 Message-Id: <20201230153916.1586725-4-luis.machado@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201230153916.1586725-1-luis.machado@linaro.org> References: <20201230153916.1586725-1-luis.machado@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Luis Machado via Gdb-patches Reply-To: Luis Machado Cc: david.spickett@linaro.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Updates for v4: - Rename RSP helper functions. - Fixup parameter and return types. Updates for v2: - Add type field to target hooks. - Add type data to qMemTags and QMemTags. The packets now look like this: qMemTags:
,: QMemTags:
,:: -- This patch adds memory tagging support to GDB's remote side, with packet string checks, new packet support and an implementation of the two new tags methods fetch_atags and store_atags. GDBserver needs to know how to read/write allocation tags, since that is done via ptrace. It doesn't need to know about logical tags. The new packets are: qMemTags:
,: -- Reads tags of the specified type from the address range [
,
) QMemTags:
,:: -- Writes the tags of specified type represented by the uninterpreted bytes to the address range [
,
). The interpretation of what to do with the tag bytes is up to the arch-specific code. Note that these new packets consider the case of packet size overflow as an error, given the common use case is to read/write only a few memory tags at a time. Having to use a couple new packets for multi-part transfers wouldn't make sense for the little use it would have. gdb/ChangeLog: YYYY-MM-DD Luis Machado * remote.c (PACKET_memory_tagging_feature): New enum. (remote_memory_tagging_p): New function. (remote_protocol_features): New "memory-tagging" entry. (remote_target::remote_query_supported): Handle memory tagging support. (remote_target::supports_memory_tagging): Implement. (create_fetch_memtags_request, parse_fetch_memtags_reply) (create_store_memtags_request): New functions. (remote_target::fetch_memtags): Implement. (remote_target::store_memtags): Implement. (_initialize_remote): Add new "memory-tagging-feature" config command. --- gdb/remote.c | 106 +++++++++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 103 insertions(+), 3 deletions(-) diff --git a/gdb/remote.c b/gdb/remote.c index c7f09c4269..77e3ecca86 100644 --- a/gdb/remote.c +++ b/gdb/remote.c @@ -2102,6 +2102,10 @@ enum { /* Support TARGET_WAITKIND_NO_RESUMED. */ PACKET_no_resumed, + /* Support for memory tagging, allocation tag fetch/store + packets and the tag violation stop replies. */ + PACKET_memory_tagging_feature, + PACKET_MAX }; @@ -2243,6 +2247,14 @@ remote_exec_event_p (struct remote_state *rs) return packet_support (PACKET_exec_event_feature) == PACKET_ENABLE; } +/* Returns true if memory tagging is supported. */ + +static bool +remote_memory_tagging_p (void) +{ + return packet_support (PACKET_memory_tagging_feature) == PACKET_ENABLE; +} + /* Insert fork catchpoint target routine. If fork events are enabled then return success, nothing more to do. */ @@ -5245,6 +5257,8 @@ static const struct protocol_feature remote_protocol_features[] = { { "vContSupported", PACKET_DISABLE, remote_supported_packet, PACKET_vContSupported }, { "QThreadEvents", PACKET_DISABLE, remote_supported_packet, PACKET_QThreadEvents }, { "no-resumed", PACKET_DISABLE, remote_supported_packet, PACKET_no_resumed }, + { "memory-tagging", PACKET_DISABLE, remote_supported_packet, + PACKET_memory_tagging_feature }, }; static char *remote_support_xml; @@ -5339,6 +5353,10 @@ remote_target::remote_query_supported () if (packet_set_cmd_state (PACKET_no_resumed) != AUTO_BOOLEAN_FALSE) remote_query_supported_append (&q, "no-resumed+"); + if (packet_set_cmd_state (PACKET_memory_tagging_feature) + != AUTO_BOOLEAN_FALSE) + remote_query_supported_append (&q, "memory-tagging+"); + /* Keep this one last to work around a gdbserver <= 7.10 bug in the qSupported:xmlRegisters=i386 handling. */ if (remote_support_xml != NULL @@ -14402,7 +14420,63 @@ set_range_stepping (const char *ignore_args, int from_tty, bool remote_target::supports_memory_tagging () { - return false; + return remote_memory_tagging_p (); +} + +/* Create the qMemTags packet given ADDRESS, LEN and TYPE. */ + +static void +create_fetch_memtags_request (gdb::char_vector &packet, CORE_ADDR address, + size_t len, int type) +{ + int addr_size = gdbarch_addr_bit (target_gdbarch ()) / 8; + + std::string request = string_printf ("qMemTags:%s,%s:%s", + phex_nz (address, addr_size), + phex_nz (len, sizeof (len)), + phex_nz (type, sizeof (type))); + + strcpy (packet.data (), request.c_str ()); +} + +/* Parse the qMemTags packet reply into TAGS. + + Return true if successful, false otherwise. */ + +static bool +parse_fetch_memtags_reply (const gdb::char_vector &reply, + gdb::byte_vector &tags) +{ + if (reply.empty () || reply[0] == 'E' || reply[0] != 'm') + return false; + + /* Copy the tag data. */ + tags = hex2bin (reply.data () + 1); + + return true; +} + +/* Create the QMemTags packet given ADDRESS, LEN, TYPE and TAGS. */ + +static void +create_store_memtags_request (gdb::char_vector &packet, CORE_ADDR address, + size_t len, int type, + const gdb::byte_vector &tags) +{ + int addr_size = gdbarch_addr_bit (target_gdbarch ()) / 8; + + /* Put together the main packet, address and length. */ + std::string request = string_printf ("QMemTags:%s,%s:%s:", + phex_nz (address, addr_size), + phex_nz (len, sizeof (len)), + phex_nz (type, sizeof (type))); + request += bin2hex (tags.data (), tags.size ()); + + /* Check if we have exceeded the maximum packet size. */ + if (packet.size () < request.length ()) + error (_("Contents too big for packet QMemTags.")); + + strcpy (packet.data (), request.c_str ()); } /* Implement the "fetch_memtags" target_ops method. */ @@ -14411,7 +14485,18 @@ bool remote_target::fetch_memtags (CORE_ADDR address, size_t len, gdb::byte_vector &tags, int type) { - return 0; + /* Make sure the qMemTags packet is supported. */ + if (!remote_memory_tagging_p ()) + gdb_assert_not_reached ("remote fetch_memtags called with packet disabled"); + + struct remote_state *rs = get_remote_state (); + + create_fetch_memtags_request (rs->buf, address, len, type); + + putpkt (rs->buf); + getpkt (&rs->buf, 0); + + return parse_fetch_memtags_reply (rs->buf, tags); } /* Implement the "store_memtags" target_ops method. */ @@ -14420,7 +14505,19 @@ bool remote_target::store_memtags (CORE_ADDR address, size_t len, const gdb::byte_vector &tags, int type) { - return 0; + /* Make sure the QMemTags packet is supported. */ + if (!remote_memory_tagging_p ()) + gdb_assert_not_reached ("remote store_memtags called with packet disabled"); + + struct remote_state *rs = get_remote_state (); + + create_store_memtags_request (rs->buf, address, len, type, tags); + + putpkt (rs->buf); + getpkt (&rs->buf, 0); + + /* Verify if the request was successful. */ + return packet_check_result (rs->buf.data ()) == PACKET_OK; } void _initialize_remote (); @@ -14822,6 +14919,9 @@ Show the maximum size of the address (in bits) in a memory packet."), NULL, add_packet_config_cmd (&remote_protocol_packets[PACKET_no_resumed], "N stop reply", "no-resumed-stop-reply", 0); + add_packet_config_cmd (&remote_protocol_packets[PACKET_memory_tagging_feature], + "memory-tagging-feature", "memory-tagging-feature", 0); + /* Assert that we've registered "set remote foo-packet" commands for all packet configs. */ { -- 2.25.1