From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id KEd7KVyf7F/qCgAAWB0awg (envelope-from ) for ; Wed, 30 Dec 2020 10:40:12 -0500 Received: by simark.ca (Postfix, from userid 112) id A478F1F0AA; Wed, 30 Dec 2020 10:40:12 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7C8391E965 for ; Wed, 30 Dec 2020 10:40:09 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DF38D388C01C; Wed, 30 Dec 2020 15:40:08 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DF38D388C01C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1609342808; bh=y6C7p8MNeU8AMyXPfh/V6OB5YlpzF9AfoArKIWX7EDw=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=E922WJywZWgVjKyfYQpSZOwbE3JhPYTDX6atPaDvmkJAjn4hgCZsftC0Fk2DHhOLu wDt0GxRsIujW3Mlv+B0pyLoYWpsuy8DffpwoKhoaVEQw0/XU9z+ClDOH8IV/IC+3cx uzd+KgiMoX0EGoCUWhEpCFowz9z7k+GJ23FKEotI= Received: from mail-qt1-x833.google.com (mail-qt1-x833.google.com [IPv6:2607:f8b0:4864:20::833]) by sourceware.org (Postfix) with ESMTPS id 52C9A388C023 for ; Wed, 30 Dec 2020 15:40:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 52C9A388C023 Received: by mail-qt1-x833.google.com with SMTP id a6so11147545qtw.6 for ; Wed, 30 Dec 2020 07:40:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=y6C7p8MNeU8AMyXPfh/V6OB5YlpzF9AfoArKIWX7EDw=; b=mN3SBrtcftn5UeS0ICzfPh9x/lXk5itke7iRDyej7/kBGUCHsJ0s+uYwT+JnKYGUfk WlL1R1sTVjJXcf3jBkuTkEwEPLehbZrU5xYKXCL2Z9qZN9B0Vz9GESg0WuY2em6/hwwc YsFpSCv7aFKgPcP5GoJf///waLC1opE0sSKuTZiMhipH63tmzX+zlzhTzsjYkRdpyAkt ZKY1DeaHELEeFPu1GN4eK62QJz3meSsMq+UacNaxhxs/Do1OpGvJnQgcvX9eoX2sHhbQ LQgK367U5qlf1vAnzke8AiVmT6MDHo4cn21nelCgbq7BnW+tBoXaPnFMJkYrzZlJi98b jyWA== X-Gm-Message-State: AOAM5318sGDawiYx8naivTMiyBVXw3cqGQq11l5CmRra9muV173U8tcr 7CjrzhuU14xVAj8QMrfT42BQkpp469pdWA== X-Google-Smtp-Source: ABdhPJx6cCu3CODK2zU1+oMScd+GAa609Z2uyfICi/0QRzKL2ZdQPIvd1c+abSNyemOJ+OT3IRNiTw== X-Received: by 2002:a05:622a:208:: with SMTP id b8mr54444178qtx.124.1609342804232; Wed, 30 Dec 2020 07:40:04 -0800 (PST) Received: from localhost.localdomain ([2804:7f0:8284:370e:c9ba:c4ec:737b:57da]) by smtp.gmail.com with ESMTPSA id f6sm28589336qkh.2.2020.12.30.07.40.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Dec 2020 07:40:03 -0800 (PST) To: gdb-patches@sourceware.org Subject: [PATCH v4 20/25] New memory-tag commands Date: Wed, 30 Dec 2020 12:39:11 -0300 Message-Id: <20201230153916.1586725-21-luis.machado@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201230153916.1586725-1-luis.machado@linaro.org> References: <20201230153916.1586725-1-luis.machado@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Luis Machado via Gdb-patches Reply-To: Luis Machado Cc: david.spickett@linaro.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Updates on v4: - Update command names and function names. - Moved common functions to gdbsupport/common-utils.cc. -- Add new commands under the "memory-tag" prefix to allow users to inspect, modify and check memory tags in different ways. The available subcommands are the following: - memory-tag print-logical-tag : Prints the logical tag for a particular address. - memory-tag withltag : Prints the address tagged with the logical tag . - memory-tag print-allocation-tag : Prints the allocation tag for a particular address. - memory-tag setatag : Sets one or more allocation tags to the specified tags. - memory-tag check : Checks if the logical tag in
matches its allocation tag. These commands make use of the memory tagging gdbarch methods, and are still available, but disabled, when memory tagging is not supported by the architecture. I've pondered about a way to make these commands invisible when memory tagging is not available, but given the check is at runtime (and support may come and go based on a process' configuration), that is a bit too late in the process to either not include the commands or get rid of them. Ideas are welcome. gdb/ChangeLog: YYYY-MM-DD Luis Machado * printcmd.c: Include gdbsupport/rsp-low.h. (memory_tag_list): New static global. (process_print_command_args): Factored out of print_command_1. (print_command_1): Use process_print_command_args. (show_addr_not_tagged, show_memory_tagging_unsupported) (memory_tag_command, memory_tag_print_tag_command) (memory_tag_print_logical_tag_command) (memory_tag_print_allocation_tag_command, parse_with_logical_tag_input) (memory_tag_with_logical_tag_command, parse_set_allocation_tag_input) (memory_tag_set_allocation_tag_command, memory_tag_check_command): New functions. (_initialize_printcmd): Add "memory-tag" prefix and subcommands. gdbsupport/ChangeLog: YYYY-MM-DD Luis Machado * rsp-low.cc (fromhex, hex2bin): Move to ... * common-utils.cc: ... here. (fromhex) Change error message text to not be RSP-specific. * rsp-low.h (fromhex, hex2bin): Move to ... * common-utils.h: ... here. --- gdb/printcmd.c | 360 +++++++++++++++++++++++++++++++++++-- gdbsupport/common-utils.cc | 49 +++++ gdbsupport/common-utils.h | 15 ++ gdbsupport/rsp-low.cc | 49 ----- gdbsupport/rsp-low.h | 19 -- 5 files changed, 412 insertions(+), 80 deletions(-) diff --git a/gdb/printcmd.c b/gdb/printcmd.c index 974b0480c7..3736b35147 100644 --- a/gdb/printcmd.c +++ b/gdb/printcmd.c @@ -54,6 +54,11 @@ #include "gdbsupport/byte-vector.h" #include "gdbsupport/gdb_optional.h" #include "safe-ctype.h" +#include "gdbsupport/rsp-low.h" + +/* Chain containing all defined memory-tag subcommands. */ + +static struct cmd_list_element *memory_tag_list; /* Last specified output format. */ @@ -1221,31 +1226,38 @@ print_value (value *val, const value_print_options &opts) annotate_value_history_end (); } -/* Implementation of the "print" and "call" commands. */ +/* Helper for parsing arguments for print_command_1. */ -static void -print_command_1 (const char *args, int voidprint) +static struct value * +process_print_command_args (const char *args, value_print_options *print_opts) { - struct value *val; - value_print_options print_opts; - - get_user_print_options (&print_opts); + get_user_print_options (print_opts); /* Override global settings with explicit options, if any. */ - auto group = make_value_print_options_def_group (&print_opts); + auto group = make_value_print_options_def_group (print_opts); gdb::option::process_options (&args, gdb::option::PROCESS_OPTIONS_REQUIRE_DELIMITER, group); - print_command_parse_format (&args, "print", &print_opts); + print_command_parse_format (&args, "print", print_opts); const char *exp = args; if (exp != nullptr && *exp) { expression_up expr = parse_expression (exp); - val = evaluate_expression (expr.get ()); + return evaluate_expression (expr.get ()); } - else - val = access_value_history (0); + + return access_value_history (0); +} + +/* Implementation of the "print" and "call" commands. */ + +static void +print_command_1 (const char *args, int voidprint) +{ + value_print_options print_opts; + + struct value *val = process_print_command_args (args, &print_opts); if (voidprint || (val && value_type (val) && value_type (val)->code () != TYPE_CODE_VOID)) @@ -2796,6 +2808,271 @@ eval_command (const char *arg, int from_tty) execute_command (expanded.c_str (), from_tty); } +/* Convenience function for error checking in memory-tag commands. */ + +static void +show_addr_not_tagged (CORE_ADDR address) +{ + error (_("Address %s not in a region mapped with a memory tagging flag."), + paddress (target_gdbarch (), address)); +} + +/* Convenience function for error checking in memory-tag commands. */ + +static void +show_memory_tagging_unsupported (void) +{ + error (_("Memory tagging not supported or disabled by the current" + " architecture.")); +} + +/* Implement the "memory-tag" prefix command. */ + +static void +memory_tag_command (const char *arg, int from_tty) +{ + help_list (memory_tag_list, "memory-tag ", all_commands, gdb_stdout); +} + +/* Helper for print-logical-tag and print-allocation-tag. */ + +static void +memory_tag_print_tag_command (const char *args, enum memtag_type tag_type) +{ + if (args == nullptr) + error_no_arg (_("address or pointer")); + + /* Parse args into a value. If the value is a pointer or an address, + then fetch the logical or allocation tag. */ + value_print_options print_opts; + + struct value *val = process_print_command_args (args, &print_opts); + + /* If the address is not in a region memory mapped with a memory tagging + flag, it is no use trying to access/manipulate its allocation tag. + + It is OK to manipulate the logical tag though. */ + if (tag_type == tag_allocation + && !gdbarch_tagged_address_p (target_gdbarch (), val)) + show_addr_not_tagged (value_as_address (val)); + + std::string tag = gdbarch_memtag_to_string (target_gdbarch (), + val, tag_type); + if (tag.empty ()) + printf_filtered (_("%s tag unavailable.\n"), + tag_type == tag_logical? "Logical" : "Allocation"); + + struct value *v_tag = process_print_command_args (tag.c_str (), + &print_opts); + print_opts.output_format = 'x'; + print_value (v_tag, print_opts); +} + +/* Implement the "memory-tag print-logical-tag" command. */ + +static void +memory_tag_print_logical_tag_command (const char *args, int from_tty) +{ + if (!memory_tagging || !target_supports_memory_tagging ()) + show_memory_tagging_unsupported (); + + memory_tag_print_tag_command (args, tag_logical); +} + +/* Implement the "memory-tag print-allocation-tag" command. */ + +static void +memory_tag_print_allocation_tag_command (const char *args, int from_tty) +{ + if (!memory_tagging || !target_supports_memory_tagging ()) + show_memory_tagging_unsupported (); + + memory_tag_print_tag_command (args, tag_allocation); +} + +/* Parse ARGS and extract ADDR and TAG. + ARGS should have format . */ + +static void +parse_with_logical_tag_input (const char *args, struct value **val, + gdb::byte_vector &tags, + value_print_options *print_opts) +{ + /* Fetch the address. */ + std::string address_string = extract_string_maybe_quoted (&args); + + /* Parse the address into a value. */ + *val = process_print_command_args (address_string.c_str (), print_opts); + + /* Fetch the tag bytes. */ + std::string tag_string = extract_string_maybe_quoted (&args); + + /* Validate the input. */ + if (address_string.empty () || tag_string.empty ()) + error (_("Missing arguments.")); + + if (tag_string.length () != 2) + error (_("Error parsing tags argument. The tag should be 2 digits.")); + + tags = hex2bin (tag_string.c_str ()); +} + +/* Implement the "memory-tag with-logical-tag" command. */ + +static void +memory_tag_with_logical_tag_command (const char *args, int from_tty) +{ + if (!memory_tagging || !target_supports_memory_tagging ()) + show_memory_tagging_unsupported (); + + if (args == nullptr) + error_no_arg (_("
")); + + gdb::byte_vector tags; + struct value *val; + value_print_options print_opts; + + /* Parse the input. */ + parse_with_logical_tag_input (args, &val, tags, &print_opts); + + /* Setting the logical tag is just a local operation that does not touch + any memory from the target. Given an input value, we modify the value + to include the appropriate tag. + + For this reason we need to cast the argument value to a + (void *) pointer. This is so we have the right type for the gdbarch + hook to manipulate the value and insert the tag. + + Otherwise, this would fail if, for example, GDB parsed the argument value + into an int-sized value and the pointer value has a type of greater + length. */ + + /* Cast to (void *). */ + val = value_cast (builtin_type (target_gdbarch ())->builtin_data_ptr, + val); + + if (!gdbarch_set_memtags (target_gdbarch (), val, 0, tags, + tag_logical)) + printf_filtered (_("Could not update the logical tag data.\n")); + else + { + /* Always print it in hex format. */ + print_opts.output_format = 'x'; + print_value (val, print_opts); + } +} + +/* Parse ARGS and extract ADDR, LENGTH and TAGS. */ + +static void +parse_set_allocation_tag_input (const char *args, struct value **val, + size_t *length, gdb::byte_vector &tags) +{ + /* Fetch the address. */ + std::string address_string = extract_string_maybe_quoted (&args); + + /* Parse the address into a value. */ + value_print_options print_opts; + *val = process_print_command_args (address_string.c_str (), &print_opts); + + /* Fetch the length. */ + std::string length_string = extract_string_maybe_quoted (&args); + + /* Fetch the tag bytes. */ + std::string tags_string = extract_string_maybe_quoted (&args); + + /* Validate the input. */ + if (address_string.empty () || length_string.empty () || tags_string.empty ()) + error (_("Missing arguments.")); + + errno = 0; + *length = strtoulst (length_string.c_str (), NULL, 10); + if (errno != 0) + error (_("Error parsing length argument.")); + + if (tags_string.length () % 2) + error (_("Error parsing tags argument. Tags should be 2 digits per byte.")); + + tags = hex2bin (tags_string.c_str ()); + + /* If the address is not in a region memory mapped with a memory tagging + flag, it is no use trying to access/manipulate its allocation tag. */ + if (!gdbarch_tagged_address_p (target_gdbarch (), *val)) + show_addr_not_tagged (value_as_address (*val)); +} + +/* Implement the "memory-tag set-allocation-tag" command. + ARGS should be in the format
. */ + +static void +memory_tag_set_allocation_tag_command (const char *args, int from_tty) +{ + if (!memory_tagging || !target_supports_memory_tagging ()) + show_memory_tagging_unsupported (); + + if (args == nullptr) + error_no_arg (_(" ")); + + gdb::byte_vector tags; + size_t length = 0; + struct value *val; + + /* Parse the input. */ + parse_set_allocation_tag_input (args, &val, &length, tags); + + if (!gdbarch_set_memtags (target_gdbarch (), val, length, tags, + tag_allocation)) + printf_filtered (_("Could not update the allocation tag(s).\n")); + else + printf_filtered (_("Allocation tag(s) updated successfully.\n")); +} + +/* Implement the "memory-tag check" command. */ + +static void +memory_tag_check_command (const char *args, int from_tty) +{ + if (!memory_tagging || !target_supports_memory_tagging ()) + show_memory_tagging_unsupported (); + + if (args == nullptr) + error (_("Argument required (address or pointer)")); + + /* Parse the expression into a value. If the value is an address or + pointer, then check its logical tag against the allocation tag. */ + value_print_options print_opts; + + struct value *val = process_print_command_args (args, &print_opts); + + /* If the address is not in a region memory mapped with a memory tagging + flag, it is no use trying to access/manipulate its allocation tag. */ + if (!gdbarch_tagged_address_p (target_gdbarch (), val)) + show_addr_not_tagged (value_as_address (val)); + + CORE_ADDR addr = value_as_address (val); + + /* Check if the tag is valid. */ + if (!gdbarch_memtag_matches_p (target_gdbarch (), val)) + { + std::string ltag = gdbarch_memtag_to_string (target_gdbarch (), + val, tag_logical); + std::string atag = gdbarch_memtag_to_string (target_gdbarch (), + val, tag_allocation); + + printf_filtered (_("Logical tag (%s) does not match" + " the allocation tag (%s) for address %s.\n"), + ltag.c_str (), atag.c_str (), + paddress (target_gdbarch (), addr)); + } + else + { + std::string ltag = gdbarch_memtag_to_string (target_gdbarch (), + val, tag_logical); + printf_filtered (_("Memory tags for address %s match (%s).\n"), + paddress (target_gdbarch (), addr), ltag.c_str ()); + } +} + void _initialize_printcmd (); void _initialize_printcmd () @@ -3008,4 +3285,63 @@ certain operations have illegal tags."), NULL, show_memory_tagging, &setlist, &showlist); + + /* Memory tagging commands. */ + add_prefix_cmd ("memory-tag", class_vars, memory_tag_command, _("\ +Generic command for printing and manipulating memory tag properties."), + &memory_tag_list, "memory-tag ", 0, &cmdlist); + add_cmd ("print-logical-tag", class_vars, + memory_tag_print_logical_tag_command, + ("Print the logical tag for an address.\n\ +Usage: memory-tag print-logical-tag
.\n\ +
is an expression that evaluates to a pointer or memory address.\n\ +GDB will print the logical tag associated with
. The tag\n\ +interpretation is architecture-specific."), + &memory_tag_list); + add_cmd ("print-allocation-tag", class_vars, + memory_tag_print_allocation_tag_command, + _("Print the allocation tag for an address.\n\ +Usage: memory-tag print-allocation-tag
.\n\ +
is an expression that evaluates to a pointer or memory address.\n\ +GDB will print the allocation tag associated with
. The tag\n\ +interpretation is architecture-specific."), + &memory_tag_list); + add_cmd ("with-logical-tag", class_vars, memory_tag_with_logical_tag_command, + _("Set the logical tag for an address.\n\ +Usage: memory-tag with-logical-tag
\n\ +
is an expression that evaluates to a pointer or memory address.\n\ + is a sequence of hex bytes that will be interpreted by the\n\ +architecture as a single memory tag.\n\ +GDB will set the logical tag for
to , and will print the\n\ +resulting address with the updated tag."), + &memory_tag_list); + add_cmd ("set-allocation-tag", class_vars, + memory_tag_set_allocation_tag_command, + _("Set the allocation tag for an address.\n\ +Usage: memory-tag set-allocation-tag
\n\ +
is an expression that evaluates to a pointer or memory address\n\ + is the number of bytes that will get added to
to calculate\n\ +the memory range.\n\ + is a sequence of hex bytes that will be interpreted by the\n\ +architecture as one or more memory tags.\n\ +Sets the tags of the memory range [
,
+ )\n\ +to the specified tag bytes.\n\ +\n\ +If the number of tags is greater than or equal to the number of tag granules\n\ +in the [
,
+ ,
+ ] is stored to."), + &memory_tag_list); + add_cmd ("check", class_vars, memory_tag_check_command, + _("Validate the logical tag against the allocation tag.\n\ +Usage: memory-tag check
\n\ +
is an expression that evaluates to a pointer or memory address\n\ +GDB will fetch the logical and allocation tags for
and will\n\ +compare them for equality. If the tags do not match, GDB will show\n\ +additional information about the mismatch."), + &memory_tag_list); } diff --git a/gdbsupport/common-utils.cc b/gdbsupport/common-utils.cc index 4f5c26d075..d1c77af37b 100644 --- a/gdbsupport/common-utils.cc +++ b/gdbsupport/common-utils.cc @@ -392,3 +392,52 @@ align_down (ULONGEST v, int n) gdb_assert (n && (n & (n-1)) == 0); return (v & -n); } + +/* See gdbsupport/common-utils.h. */ + +int +fromhex (int a) +{ + if (a >= '0' && a <= '9') + return a - '0'; + else if (a >= 'a' && a <= 'f') + return a - 'a' + 10; + else if (a >= 'A' && a <= 'F') + return a - 'A' + 10; + else + error (_("Invalid hex digit %d"), a); +} + +/* See gdbsupport/common-utils.h. */ + +int +hex2bin (const char *hex, gdb_byte *bin, int count) +{ + int i; + + for (i = 0; i < count; i++) + { + if (hex[0] == 0 || hex[1] == 0) + { + /* Hex string is short, or of uneven length. + Return the count that has been converted so far. */ + return i; + } + *bin++ = fromhex (hex[0]) * 16 + fromhex (hex[1]); + hex += 2; + } + return i; +} + +/* See gdbsupport/common-utils.h. */ + +gdb::byte_vector +hex2bin (const char *hex) +{ + size_t bin_len = strlen (hex) / 2; + gdb::byte_vector bin (bin_len); + + hex2bin (hex, bin.data (), bin_len); + + return bin; +} diff --git a/gdbsupport/common-utils.h b/gdbsupport/common-utils.h index 30ee412365..8c32dcd60f 100644 --- a/gdbsupport/common-utils.h +++ b/gdbsupport/common-utils.h @@ -22,6 +22,7 @@ #include #include +#include "gdbsupport/byte-vector.h" #include "poison.h" @@ -195,4 +196,18 @@ in_inclusive_range (T value, T low, T high) extern ULONGEST align_up (ULONGEST v, int n); extern ULONGEST align_down (ULONGEST v, int n); +/* Convert hex digit A to a number, or throw an exception. */ +extern int fromhex (int a); + +/* HEX is a string of characters representing hexadecimal digits. + Convert pairs of hex digits to bytes and store sequentially into + BIN. COUNT is the maximum number of characters to convert. This + will convert fewer characters if the number of hex characters + actually seen is odd, or if HEX terminates before COUNT characters. + Returns the number of characters actually converted. */ +extern int hex2bin (const char *hex, gdb_byte *bin, int count); + +/* Like the above, but return a gdb::byte_vector. */ +gdb::byte_vector hex2bin (const char *hex); + #endif /* COMMON_COMMON_UTILS_H */ diff --git a/gdbsupport/rsp-low.cc b/gdbsupport/rsp-low.cc index 9bb16605dd..9b11190864 100644 --- a/gdbsupport/rsp-low.cc +++ b/gdbsupport/rsp-low.cc @@ -22,21 +22,6 @@ /* See rsp-low.h. */ -int -fromhex (int a) -{ - if (a >= '0' && a <= '9') - return a - '0'; - else if (a >= 'a' && a <= 'f') - return a - 'a' + 10; - else if (a >= 'A' && a <= 'F') - return a - 'A' + 10; - else - error (_("Reply contains invalid hex digit %d"), a); -} - -/* See rsp-low.h. */ - int tohex (int nib) { @@ -111,40 +96,6 @@ unpack_varlen_hex (const char *buff, /* packet to parse */ /* See rsp-low.h. */ -int -hex2bin (const char *hex, gdb_byte *bin, int count) -{ - int i; - - for (i = 0; i < count; i++) - { - if (hex[0] == 0 || hex[1] == 0) - { - /* Hex string is short, or of uneven length. - Return the count that has been converted so far. */ - return i; - } - *bin++ = fromhex (hex[0]) * 16 + fromhex (hex[1]); - hex += 2; - } - return i; -} - -/* See rsp-low.h. */ - -gdb::byte_vector -hex2bin (const char *hex) -{ - size_t bin_len = strlen (hex) / 2; - gdb::byte_vector bin (bin_len); - - hex2bin (hex, bin.data (), bin_len); - - return bin; -} - -/* See rsp-low.h. */ - std::string hex2str (const char *hex) { diff --git a/gdbsupport/rsp-low.h b/gdbsupport/rsp-low.h index 84eb839d3f..9a2b3e71d3 100644 --- a/gdbsupport/rsp-low.h +++ b/gdbsupport/rsp-low.h @@ -20,12 +20,6 @@ #ifndef COMMON_RSP_LOW_H #define COMMON_RSP_LOW_H -#include "gdbsupport/byte-vector.h" - -/* Convert hex digit A to a number, or throw an exception. */ - -extern int fromhex (int a); - /* Convert number NIB to a hex digit. */ extern int tohex (int nib); @@ -45,19 +39,6 @@ extern char *pack_hex_byte (char *pkt, int byte); extern const char *unpack_varlen_hex (const char *buff, ULONGEST *result); -/* HEX is a string of characters representing hexadecimal digits. - Convert pairs of hex digits to bytes and store sequentially into - BIN. COUNT is the maximum number of characters to convert. This - will convert fewer characters if the number of hex characters - actually seen is odd, or if HEX terminates before COUNT characters. - Returns the number of characters actually converted. */ - -extern int hex2bin (const char *hex, gdb_byte *bin, int count); - -/* Like the above, but return a gdb::byte_vector. */ - -gdb::byte_vector hex2bin (const char *hex); - /* Like hex2bin, but return a std::string. */ extern std::string hex2str (const char *hex); -- 2.25.1