From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id HKxoKEBh618CaQAAWB0awg (envelope-from ) for ; Tue, 29 Dec 2020 12:02:56 -0500 Received: by simark.ca (Postfix, from userid 112) id 8DA0E1F0B8; Tue, 29 Dec 2020 12:02:56 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 64D2F1E965 for ; Tue, 29 Dec 2020 12:02:55 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AA4F738350A3; Tue, 29 Dec 2020 17:02:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AA4F738350A3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1609261374; bh=ZrGSDmtRBkQBRTVVRMDY396o3Av/Xg5mB9QtjNK0ft0=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=Vk4AVjVCXAvjRGuBGRpx2JD5QZYUY2ozTEtIdoCPLeiJYyGhcBp42KamPHMlv8OjM 4qwHLIDlrmdhOllXFpNjpTPoCk8rpSQ4r4utjKU8fumpEQ+DtRwsriNnSIFZwdxZzE 6qu8L83rYhWAtpLLrNi9UZ6/bh7JRPPfXVXC4ipk= Received: from sonic301-22.consmr.mail.ir2.yahoo.com (sonic301-22.consmr.mail.ir2.yahoo.com [77.238.176.99]) by sourceware.org (Postfix) with ESMTPS id EE7DC3851C0D for ; Tue, 29 Dec 2020 17:02:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org EE7DC3851C0D X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1609261371; bh=Od/MCvhZ0jVztmq26YIORtZT80UOKD4aupQlE6MMI72=; h=From:To:Subject:Date:From:Subject; b=e+iqSlaubiHaGDuTu7/JecQRI0EZbZv42YTai9gzOW5XLTgf1pPJYCkFYlybAMbHb2XF5EsWUnRtenAXoqneI3X2+Ng03i14Qo5tf6eID8EsEDOQdXP8Cg52fw7Cy9IGiu54tgYWtQIYjwfuOLdoquXKhO8CpqNOBVlu2VB3Tq9jMWsEwI991Txj09/nAg8PV+4JU/oEoX0W1vP5DMQ7XT9od7gYeCtmvON26Vw9kIJzAklvqrDfcrC7FAMFEG6ArhUdcGZQVDye/jPgUtyyR6pEHpk63EebR2zOsPqPDlAqZYG9/6gY/FxcTt7bZb6f1gzjr90fo9NcEbKR4SeAVw== X-YMail-OSG: EY6aMuAVM1nXVj7h4utwoE6kCYc5YBYtg5cWOaAQtApWei0O3lTXnj2FV4I3DfJ elzvJNxJ4OA2UfgK5KEPeFi5zuPesh4rKCW5xr1ouIhq1q2GXJduXinFspBNQRSKeny7NxHSUduc KOsvPLdV4JlDkWyvyUq4s5jfMkAQrj_zjui4g597jx54QQZgQDdA6rDF.Tp6nAd_3icdiXIbJbQ7 8bjBHnuLaXq7M4GofKVMjK0hj2x7qR_vHgzjf4NW3XqLC7BmurkgMZ5HXlub3ZcrSg7JNUKbzrty BQIwIxHA7AcTdRqxFVlq5YyJVRAJOStLele73xalrzVYZnU.iTLbVsulw6ig3_HRP_kL6uGX7LBw tlOvOegqLW6jJ4hz01o7ViQBz8rIDQTRdLAt4fzXqQ47P8mESgWfgu69G2r679Bu1FPhvZIvlVyl SsV4ZHziPKaeEnpwxxSZ6mz5FfMyOPTc.fxiU1Zy793wKUBFew6.l4krM9Qt8tM2KPXfcy.mwDgL S.fTHYWg23yqV2Gy3eloFZIekxBByCoQ86v4Dj5903mCpSaLXUrNS89jqwZeUUA.J3oWF1s42SFt zflOPjLzLqYr6z25kyriBjcHuvN0wH_J9BKaq9P2DOQdK7XO2fsJ4zrSPA53GphQbWM9IR..Gho4 pgkKnIguB.vizgaEOUrw8tLGl7fXSMbcOPhnoXkrZb23WgMnW3E..2qLLpbtZFuaTIMIDekSYj.C HDwPU6P4qZfKKl9otus3sVoLXTStgWuTg0Kr2CyEJ5yBsFVjKh0YewDW8k4sSYOnlGVfpMK_34hy .ohQApTnhf5O_HcEbxVtRb7XltR3LmEgqo3MAB4s_adHGDIqPATfzgrQUQcYaY8GOl9cyXyuEWtA VIzuZcLZD5rvfaOAfPkbvzLPeLqiG1hCLjoW5bSxllwwuN_pxAit3bDmaAjLQbZwRi06cMhgNuNL qW4348fv9JsZlDXIYOi1YOecR6RZkjiFnKSGstlXNxvjY4nKHQw23yJUK5159WUiRciJhL7W2PrX 5FbsmB6as4nncgYYGP6gz2mbEc0ADMob76KXEDz72QmlgwIV9iwXx0P4szeI328dujlQIwTSFvPc 12gUwusZ9VuJgghEA2D1SQ20MDGqLs48q.ErOeJgGWHl0DALoNe7z6BNiDnmfHx9tB16.3q1MAS2 7g0p6yyFrj53eiyw3v0E8gVGncmc6wOIZVKLrFnh_joh4adsNseNYzh_tm8VcSQSneSNTsikVKf2 KBlNojRabQSl0VnNJ5ee.jDz8xGIbyfY2_FKhnjtoly5svr_aXE8qRozqRSDwpzG8HlTbWMsl7D6 uiQ82AvXQ1nF6NH7zOXpFOY5.6ru0YGjbjcpVrEix0OeYMM7sjn6ZBdnroDyYZidFrbWmIu0cNC7 QmBsE8OTukVvzIo1VrMYLuGubnphjdlepL6jB6KzM6dvkLWMrdMT4FBnp6CR1aC0NxNt1z2plUAa Ckj_lu5lHFW5PNIYxqlw7ijA2b4JuYaBpHJFDxVvTky.oMqlWVz1v_qPpddQDo.Ey1KdSMYwhaIn fQ_EYEBUft1K1xa2OAuiNm_384duUMgqY.dyBg_8nmce1lHnQmEpXKtwQ8yE2t0xkMKW.ftIPCF. 4yTd6KNUHeF9x1wjaDYcJZXzkZ..o4GNe.OWNXNlsGzw3Qz3gUQOgM4rQgcZyzWvN7E88rRLcs3E iLZASdkPRwmyKdCKcAkRQxAx9YGpdj71FPjk_0n7tkJbx4Z..NFngj._zorl_6Zo2kla_JQYPWV4 2piak.uHAKRlJpoe0Xn1BvMgK_dz0Gc.F4J39FPBFP6YiX712lHipUWbEss.xK2dSXewEbZvTIpi RFYhDEnlRE._lUvhjKNY8kajyNxnfBa07niknlF.etmQIAQQYlOfE56hVnArUarRONXiszkpNIFx aiM174JlgATDQfNoDfGUed5xCYAUwVgaMTyRPnzfNN055nUHb0c_Cg2p7e4XvSs5xstPbC5q119D LqAc2_LA59_mN4nUb2bzjcqo.JlNyrE9bVIkTi2XNjnBoPw1sgmGMWRWJDfbjzUXDvB5So8tkj.D q.80lMwtQ5aLMxJsszfhgVVLuueNxGPh9ucTy8OJvqlN9gS7eSQ9OObySWO0gnox2_4OCgV.5auE ubXiWgJ8X.T2YS5eth9o7uJ5KLAmonFetyEkHC.MESH.eDsGcVCT17ZEQUbd__LroZSo8L_mcBXN G0QxZvIyWiNAQCViJsLIxABmLali7wgWd43RdEBybUZ9tu7jOc4YtIXyB96Fsf3N7x1cgcoJxX7E 5Pqr5j8lasaXhD9T97xFlr2nK2DH3JEAmGYodVjKfFWDXIcCklzA3KLx_7ZTZM_Wcio_W5xzt_iz ppqNadLZtVBlCfvgNKVfnlHxQhOUrxtICtSYpCbZvwjWbTCY3DxViedMjsKBF1Ib5IYoys0.JIPA aDik- Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.ir2.yahoo.com with HTTP; Tue, 29 Dec 2020 17:02:51 +0000 Received: by smtp411.mail.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 1076516e444f24a80d67c937a4f3cedd; Tue, 29 Dec 2020 17:02:47 +0000 (UTC) To: gdb-patches@sourceware.org Subject: [PATCH 2/4] Return true in TuiWindow.is_valid only if TUI is enabled Date: Tue, 29 Dec 2020 18:02:25 +0100 Message-Id: <20201229170227.821-2-ssbssa@yahoo.de> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201229170227.821-1-ssbssa@yahoo.de> References: <20201229170227.821-1-ssbssa@yahoo.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Antivirus: Avast (VPS 201229-2, 12/29/2020), Outbound message X-Antivirus-Status: Clean X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Hannes Domani via Gdb-patches Reply-To: Hannes Domani Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" There seems to be no other way to determine if TUI is enabled, which is a problem in case the TUI is disabled, and you redraw the window contents based on some registered event. Then the TUI is redrawn, even though the TUI stays disabled, and the prompt is anywhere on the screen. gdb/ChangeLog: 2020-12-29 Hannes Domani * python/py-tui.c (gdbpy_tui_is_valid): Check tui_active as well. --- gdb/python/py-tui.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/python/py-tui.c b/gdb/python/py-tui.c index 87065eaf60..9c35778bcb 100644 --- a/gdb/python/py-tui.c +++ b/gdb/python/py-tui.c @@ -356,7 +356,7 @@ gdbpy_tui_is_valid (PyObject *self, PyObject *args) { gdbpy_tui_window *win = (gdbpy_tui_window *) self; - if (win->window != nullptr) + if (tui_active && win->window != nullptr) Py_RETURN_TRUE; Py_RETURN_FALSE; } -- 2.29.2