From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id FCeeGaHW4V+BcgAAWB0awg (envelope-from ) for ; Tue, 22 Dec 2020 06:21:05 -0500 Received: by simark.ca (Postfix, from userid 112) id 5B80B1F0AA; Tue, 22 Dec 2020 06:21:05 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6A0271E552 for ; Tue, 22 Dec 2020 06:21:04 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 109E8387547C; Tue, 22 Dec 2020 11:21:04 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 109E8387547C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1608636064; bh=kd3BKgmLg0/NR366bsevQ+WI3563SVsPuGGOn0fDfOs=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=qzkhaBBqfC/2oxDpju7t1rxyUD9Crbf6zmvEW5JjfIR/bcXjm9bDAfjw8txlVUQOt z7y9Dy9wNE6Pu3kPKC8OSRHRHsXndLCY5NyMAtQrCU8rL3ghqahZfu3PNXy+3Zch4L SEb8jnTILHMPeX7NMtQFXgFcUO8tRDAlGljAYvJM= Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by sourceware.org (Postfix) with ESMTPS id EAD1238708F9 for ; Tue, 22 Dec 2020 11:21:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org EAD1238708F9 Received: by mail-ej1-x62b.google.com with SMTP id ga15so17780554ejb.4 for ; Tue, 22 Dec 2020 03:21:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kd3BKgmLg0/NR366bsevQ+WI3563SVsPuGGOn0fDfOs=; b=GgjD9/6UHOWZLfQBnpGDP2eIF2JAIRmAu6gxNnkxY9R7/Pk1AwZmlpCjWw6gpQxJ54 prFZykj15YSsisafOXAXXaXSOA6kIbFkPS6tkA/N5MpUGtRwzk1qfHWm/qGhrgnmY0Th vwPn5cgepNCbqxdGNJo9AuQz7A7ItHYv32eC+CABDfLoa+p8eE586ydhq+9zwa5Qgtpu qpn6XMTiuGtbgzv6645ryD5+BlR4cbfxNOcNzx6VXTzuBs9tGfD5qpyRuMRwi5KaOK/u Ib1UHuYdxVSMx9jSyR+YhHM9ZOwmjg+cCb9ReUIFwstxupMLAm0+NC2ncK1q/xqE1s6r A0HA== X-Gm-Message-State: AOAM532JkCc+8/m3IbUnhF3aAIaY7aMNCjfe8fI8UhArOi6lFBxuT14B Kjiwiy6cKepecIu25HNbGSSX56aLXALkO3IK X-Google-Smtp-Source: ABdhPJy/FBd0z7oQE65F211a0BPJ2erE94cTY9HIJ4bJG1idgBuVn4OQjcL9XVkOVtsn1qeZTYD60g== X-Received: by 2002:a17:906:6a92:: with SMTP id p18mr18935617ejr.308.1608636061098; Tue, 22 Dec 2020 03:21:01 -0800 (PST) Received: from atlantis.home ([2a03:1b20:1:f410::21d]) by smtp.gmail.com with ESMTPSA id a10sm10292346ejk.92.2020.12.22.03.20.59 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 Dec 2020 03:21:00 -0800 (PST) To: gdb-patches@sourceware.org Subject: [PUSHED v2 1/2] arc: Take into account the REGNUM in supply/collect gdb hooks Date: Tue, 22 Dec 2020 12:21:01 +0100 Message-Id: <20201222112102.13411-1-shahab.vahedi@gmail.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201112134811.9074-1-shahab.vahedi@gmail.com> References: <20201112134811.9074-1-shahab.vahedi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Shahab Vahedi via Gdb-patches Reply-To: Shahab Vahedi Cc: Shahab Vahedi , Shahab Vahedi , Tom Tromey , Francois Bedard Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" From: Shahab Vahedi All the arc_linux_supply_*() target operations and the arc_linux_collect_v2_regset() in arc-linux-tdep.c were supplying/collecting all the registers in regcache as if the REGNUM was set to -1. The more efficient behavior is to examine the REGNUM and act accordingly. That is what this patch does. gdb/ChangeLog: * arc-linux-tdep.c (supply_register): New. (arc_linux_supply_gregset, arc_linux_supply_v2_regset, arc_linux_collect_v2_regset): Consider REGNUM. --- gdb/arc-linux-tdep.c | 41 ++++++++++++++++++++++++++++++++--------- 1 file changed, 32 insertions(+), 9 deletions(-) diff --git a/gdb/arc-linux-tdep.c b/gdb/arc-linux-tdep.c index ad68f494b3c..eca8d626084 100644 --- a/gdb/arc-linux-tdep.c +++ b/gdb/arc-linux-tdep.c @@ -460,6 +460,18 @@ arc_linux_skip_solib_resolver (struct gdbarch *gdbarch, CORE_ADDR pc) } } +/* Populate REGCACHE with register REGNUM from BUF. */ + +static void +supply_register (struct regcache *regcache, int regnum, const gdb_byte *buf) +{ + /* Skip non-existing registers. */ + if ((arc_linux_core_reg_offsets[regnum] == ARC_OFFSET_NO_REGISTER)) + return; + + regcache->raw_supply (regnum, buf + arc_linux_core_reg_offsets[regnum]); +} + void arc_linux_supply_gregset (const struct regset *regset, struct regcache *regcache, @@ -470,9 +482,14 @@ arc_linux_supply_gregset (const struct regset *regset, const bfd_byte *buf = (const bfd_byte *) gregs; - for (int reg = 0; reg <= ARC_LAST_REGNUM; reg++) - if (arc_linux_core_reg_offsets[reg] != ARC_OFFSET_NO_REGISTER) - regcache->raw_supply (reg, buf + arc_linux_core_reg_offsets[reg]); + /* regnum == -1 means writing all the registers. */ + if (regnum == -1) + for (int reg = 0; reg <= ARC_LAST_REGNUM; reg++) + supply_register (regcache, reg, buf); + else if (regnum <= ARC_LAST_REGNUM) + supply_register (regcache, regnum, buf); + else + gdb_assert_not_reached ("Invalid regnum in arc_linux_supply_gregset."); } void @@ -483,9 +500,12 @@ arc_linux_supply_v2_regset (const struct regset *regset, const bfd_byte *buf = (const bfd_byte *) v2_regs; /* user_regs_arcv2 is defined in linux arch/arc/include/uapi/asm/ptrace.h. */ - regcache->raw_supply (ARC_R30_REGNUM, buf); - regcache->raw_supply (ARC_R58_REGNUM, buf + REGOFF (1)); - regcache->raw_supply (ARC_R59_REGNUM, buf + REGOFF (2)); + if (regnum == -1 || regnum == ARC_R30_REGNUM) + regcache->raw_supply (ARC_R30_REGNUM, buf); + if (regnum == -1 || regnum == ARC_R58_REGNUM) + regcache->raw_supply (ARC_R58_REGNUM, buf + REGOFF (1)); + if (regnum == -1 || regnum == ARC_R59_REGNUM) + regcache->raw_supply (ARC_R59_REGNUM, buf + REGOFF (2)); } /* Populate BUF with register REGNUM from the REGCACHE. */ @@ -543,9 +563,12 @@ arc_linux_collect_v2_regset (const struct regset *regset, { bfd_byte *buf = (bfd_byte *) v2_regs; - regcache->raw_collect (ARC_R30_REGNUM, buf); - regcache->raw_collect (ARC_R58_REGNUM, buf + REGOFF (1)); - regcache->raw_collect (ARC_R59_REGNUM, buf + REGOFF (2)); + if (regnum == -1 || regnum == ARC_R30_REGNUM) + regcache->raw_collect (ARC_R30_REGNUM, buf); + if (regnum == -1 || regnum == ARC_R58_REGNUM) + regcache->raw_collect (ARC_R58_REGNUM, buf + REGOFF (1)); + if (regnum == -1 || regnum == ARC_R59_REGNUM) + regcache->raw_collect (ARC_R59_REGNUM, buf + REGOFF (2)); } /* Linux regset definitions. */ -- 2.29.2