From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id awgQM9b/4F8aXwAAWB0awg (envelope-from ) for ; Mon, 21 Dec 2020 15:04:38 -0500 Received: by simark.ca (Postfix, from userid 112) id C3E881F0AA; Mon, 21 Dec 2020 15:04:38 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.4 required=5.0 tests=DKIM_SIGNED,MAILING_LIST_MULTI, RCVD_IN_BL_SPAMCOP_NET,T_DKIM_INVALID,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id F113C1E99A for ; Mon, 21 Dec 2020 15:04:36 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2ED3E386F419; Mon, 21 Dec 2020 20:04:36 +0000 (GMT) Received: from gateway22.websitewelcome.com (gateway22.websitewelcome.com [192.185.47.109]) by sourceware.org (Postfix) with ESMTPS id 8C3C8386F023 for ; Mon, 21 Dec 2020 20:04:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8C3C8386F023 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway22.websitewelcome.com (Postfix) with ESMTP id 8669914D34 for ; Mon, 21 Dec 2020 14:04:13 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id rRPhk2SO6HPnUrRPhkG9iY; Mon, 21 Dec 2020 14:04:13 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:MIME-Version :Content-Type:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=MaOEd/hTPXu+VibyIfXLq3fMTZWaLl8rSrrj4Jlx1eE=; b=sGBML9Naojb2AeDVEAKhFuc0fL F/Kv1hrI6hVFY/Vs3MIax3bISKU3vDYtiqI0S5Z8h9gVY7a3lisypIPcgK5Jv1uStG7KCU0J+7Rn9 QvPO7sK7B3w1lSTRrPq7YTlg/; Received: from 97-122-81-39.hlrn.qwest.net ([97.122.81.39]:39710 helo=bapiya.Home) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1krRPh-001LyR-A6; Mon, 21 Dec 2020 13:04:13 -0700 From: Tom Tromey To: gdb-patches@sourceware.org Subject: [pushed] Move enum noside earlier in expression.h Date: Mon, 21 Dec 2020 13:04:11 -0700 Message-Id: <20201221200411.26204-1-tom@tromey.com> X-Mailer: git-send-email 2.17.2 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.81.39 X-Source-L: No X-Exim-ID: 1krRPh-001LyR-A6 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-81-39.hlrn.qwest.net (bapiya.Home) [97.122.81.39]:39710 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tom Tromey Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" For the expression rewrite series, I needed to move enum noside earlier in expression.h. Because this is a pure move, and because it seems harmless and uncontroversial to move an enum definition earlier in a file, I'm pushing it in early, to reduce the size of that series. Tested by rebuilding. gdb/ChangeLog 2020-12-21 Tom Tromey * expression.h (enum noside): Move earlier. --- gdb/ChangeLog | 4 ++++ gdb/expression.h | 44 ++++++++++++++++++++++---------------------- 2 files changed, 26 insertions(+), 22 deletions(-) diff --git a/gdb/expression.h b/gdb/expression.h index c07111c316f..f30c79309ae 100644 --- a/gdb/expression.h +++ b/gdb/expression.h @@ -67,6 +67,28 @@ enum exp_opcode : uint8_t OP_UNUSED_LAST }; +/* Values of NOSIDE argument to eval_subexp. */ + +enum noside + { + EVAL_NORMAL, + EVAL_SKIP, /* Only effect is to increment pos. + Return type information where + possible. */ + EVAL_AVOID_SIDE_EFFECTS /* Don't modify any variables or + call any functions. The value + returned will have the correct + type, and will have an + approximately correct lvalue + type (inaccuracy: anything that is + listed as being in a register in + the function in which it was + declared will be lval_register). + Ideally this would not even read + target memory, but currently it + does in many situations. */ + }; + union exp_element { enum exp_opcode opcode; @@ -135,28 +157,6 @@ extern expression_up parse_exp_1 (const char **, CORE_ADDR pc, /* From eval.c */ -/* Values of NOSIDE argument to eval_subexp. */ - -enum noside - { - EVAL_NORMAL, - EVAL_SKIP, /* Only effect is to increment pos. - Return type information where - possible. */ - EVAL_AVOID_SIDE_EFFECTS /* Don't modify any variables or - call any functions. The value - returned will have the correct - type, and will have an - approximately correct lvalue - type (inaccuracy: anything that is - listed as being in a register in - the function in which it was - declared will be lval_register). - Ideally this would not even read - target memory, but currently it - does in many situations. */ - }; - extern struct value *evaluate_subexp_standard (struct type *, struct expression *, int *, enum noside); -- 2.17.2