From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id zFyvKYdq1186XgAAWB0awg (envelope-from ) for ; Mon, 14 Dec 2020 08:37:11 -0500 Received: by simark.ca (Postfix, from userid 112) id 9E7161F0AA; Mon, 14 Dec 2020 08:37:11 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.4 required=5.0 tests=DKIM_SIGNED,MAILING_LIST_MULTI, RDNS_NONE,T_DKIM_INVALID,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3EE241E552 for ; Mon, 14 Dec 2020 08:37:11 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AE7FD3851C0D; Mon, 14 Dec 2020 13:37:10 +0000 (GMT) Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by sourceware.org (Postfix) with ESMTPS id A0B713857C71 for ; Mon, 14 Dec 2020 13:37:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A0B713857C71 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=andrew.burgess@embecosm.com Received: by mail-wr1-x443.google.com with SMTP id 91so16430968wrj.7 for ; Mon, 14 Dec 2020 05:37:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=qTkXBvk0SRc7ANO62vcZFOGLP3Sv8/0Q5LE5ZqE5SOE=; b=JbSNaSLpHhYRbScDLrR05c9LCwl45POQGg2Y2GKBZSxlQ/80yimCRY/z8a/xzFXwfw 5fBXihpdwITjA+Km93xTOMk8ra5UiS1tStfJu3fq6FSP5fQLn1JA9FqdS5MAkgpWUm3X /XvS3Z9Y32CTjl2BrPGVFE1o0CHKI8J5zfWXB4nz7m5xWZivXN0JMwGL2irm4YT065sw K+9Fu7ZTD0y0D1ZXT2pnsWFRIcIic+bW34ukmibN0BpwfBAT3LWjMUyzoKGBWbJpJRKH 0FkAuQlXI6SkiMxmA/2TtMWvdSGICGDHiDwatoqqSR+QW448uOOQPGXF8KsxcwZyw22G TDgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=qTkXBvk0SRc7ANO62vcZFOGLP3Sv8/0Q5LE5ZqE5SOE=; b=aSUmi2V3E+v5/4qTYA8ebP1G6GEsSSncWJgm+ddpLwsEdZE95jjEaPofX1UYNUh0G0 jAnvAclXcnfasg2KBFTWw+ZgfuC65gt1jA19A7XACRm2ctQSy8qH3BTp+Yt602FkiEgI jhWTQpxs42SFGqFmiQ9A+W5GmTSQh4sEmn8rAjLz8SRJI1g+HCX01hZNt8nl+/S5uKP7 1dua5RKoUNnyEHr1OEA7WJU/UmYrDtMHpAvazVfmAiBaqt9EbePxWJ2T9icsEPkUyg6o dKFF1nlCYvFA0xsgWa7GIafyhzMYAEYbTNPVOOR+90S0Yj7zL/rM4V3QC6+sC2pQAfrQ YP0Q== X-Gm-Message-State: AOAM533ncOSDrkrOsxH+8M8bsprlabiHRl2u7IwqULdqTHPQPeRv6k/M Bw2hfjYsCkPqDbBWxDpL5daE0XjIYNLwfw== X-Google-Smtp-Source: ABdhPJxCk42sJaZZa4uqkPgx68Wb7L1+Hz0Ib5HXJuA//RpDUQBPBWgkeyJJtmhsy+/thYYKe4oMgw== X-Received: by 2002:a05:6000:1d0:: with SMTP id t16mr5818727wrx.203.1607953026736; Mon, 14 Dec 2020 05:37:06 -0800 (PST) Received: from localhost (host86-180-62-188.range86-180.btcentralplus.com. [86.180.62.188]) by smtp.gmail.com with ESMTPSA id n14sm30903192wmi.1.2020.12.14.05.37.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Dec 2020 05:37:05 -0800 (PST) Date: Mon, 14 Dec 2020 13:37:04 +0000 From: Andrew Burgess To: Jim Wilson Subject: Re: [PATCH 6/8] bfd/binutils: add support for RISC-V CSRs in core files Message-ID: <20201214133704.GJ2945@embecosm.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux/5.8.13-100.fc31.x86_64 (x86_64) X-Uptime: 13:34:43 up 5 days, 18:19, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Binutils , gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" * Jim Wilson [2020-12-02 15:50:58 -0800]: > On Wed, Dec 2, 2020 at 9:39 AM Andrew Burgess > wrote: > > > diff --git a/include/elf/common.h b/include/elf/common.h > > index 1dbf0b11983..54d5d989a39 100644 > > --- a/include/elf/common.h > > +++ b/include/elf/common.h > > @@ -663,6 +663,8 @@ > > /* note name must be "LINUX". */ > > #define NT_ARC_V2 0x600 /* ARC HS accumulator/extra > > registers. */ > > /* note name must be "LINUX". */ > > +#define NT_RISCV_CSR 0x501 /* RISC-V Control and Status > > Registers */ > > + /* note name must be "CORE". */ > > #define NT_SIGINFO 0x53494749 /* Fields of siginfo_t. */ > > #define NT_FILE 0x46494c45 /* Description of mapped > > files. */ > > > > Odd that the 0x5XX numbering was skipped for ARC, though I don't see any > reason for it, so it appears OK to use for RISC-V. I would suggest keeping > them in numerical order to make the file easier to read, so if you want to > use 0x501 put it before the ARC entry. > > Otherwise, this looks OK to me with a trivial change here. On further reflection I wonder if I should submit a patch to the Linux kernel to try and reserve this (or some other suitable) number, otherwise there's a risk that whatever we pick could be used by the kernel for some other architecture? Thanks, Andrew