From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 0FDdKR58zl+QTQAAWB0awg (envelope-from ) for ; Mon, 07 Dec 2020 14:01:50 -0500 Received: by simark.ca (Postfix, from userid 112) id A4ADD1F0BC; Mon, 7 Dec 2020 14:01:50 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,RDNS_NONE, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A905C1EFBB for ; Mon, 7 Dec 2020 14:01:49 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7614E39540CC; Mon, 7 Dec 2020 19:01:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7614E39540CC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1607367708; bh=uXqXf1p0Bgnz4bFfUyhJN7bKf1RE5AX85KmqOe3cA2Y=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=fzxdKgfFcA/74Bk10nCT7Vznv96cdbW65IcPxIl2ayE5vbFt8di2UL+xj26NAGIwN l5vo8IFpsIN5Sod7bkZ59XWlIXdhn3wODmYRrzXiAPhcz6+k7Tj99jkjYSjI9F0vzE +QaMj2rn4pCb58021KVZWqYpQhpP5qCqiqsPRnO4= Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2045.outbound.protection.outlook.com [40.107.244.45]) by sourceware.org (Postfix) with ESMTPS id 2CAD93951C10 for ; Mon, 7 Dec 2020 19:01:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2CAD93951C10 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lQTkTQ095LYgSWlSwlhFWaPVLX0u69JXvnoNW7m/JY9DCnTcKzvoUt/icXG5iRZOjaH6w/pU4OI0XUQ8cB1Ru1pfEKpAU6qHybCHMLuvc2b5WtNXiyVIFjV2cQm2z2yz8Iu2tKubuga0WneLh2zKJTXSXyFtugmNHWcIeisfyXdDJ9cAuj001y4z/LQoHHfamRfAcRVwgyD0+CcK8qvIue72+YEAC/KmbY7niqlnLuunaasxh6JrgU6Z/CULfAZCanXW4CLgbmCFYSZyziVcvww9scHPaZRapU2NgX4DhYK8tipN0KHmal0iVRdBlD5FOqeR2scCMZkUNHdLOiuEgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uXqXf1p0Bgnz4bFfUyhJN7bKf1RE5AX85KmqOe3cA2Y=; b=iyDSRNGhV9WFZ8bunSPpXtoBD5onPCMB5d9Sqxcg+1DS8LrsVoiSiofdkBQdyfDtB4GzVdkiIqgBtiu58OmbzeJA8DYPZH9eXXh7S04ocXzsYRYMDxW63uWUNZf185IchbTr6qyJEZnuVQltOpsvJBuT8NGGOOC+ZXndbnrhvsBBuMvyAhcQaLxT0aYzjxFLQOnrmukgvaSOsNq15zPIxALhB9Ufwbwi9gsh7eljnL2iTRw4jYPWjipq4PaRMA21eC3uHqQ3DxRRSQJdep3qmIRLk8m/D2Q9pfZ22wKkE8d67kWHTq57lumGtzCqOqOQGd1IvMZUpv/Q5Bwl36X2Yw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from DM6PR12MB2762.namprd12.prod.outlook.com (2603:10b6:5:45::15) by DM6PR12MB4561.namprd12.prod.outlook.com (2603:10b6:5:2ac::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3632.18; Mon, 7 Dec 2020 19:01:34 +0000 Received: from DM6PR12MB2762.namprd12.prod.outlook.com ([fe80::6841:61df:984b:b3c]) by DM6PR12MB2762.namprd12.prod.outlook.com ([fe80::6841:61df:984b:b3c%3]) with mapi id 15.20.3632.021; Mon, 7 Dec 2020 19:01:34 +0000 To: gdb-patches@sourceware.org Subject: [PATCH 26/30] Remove DWARF expression composition check Date: Mon, 7 Dec 2020 19:00:27 +0000 Message-Id: <20201207190031.13341-27-Zoran.Zaric@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201207190031.13341-1-Zoran.Zaric@amd.com> References: <20201207190031.13341-1-Zoran.Zaric@amd.com> Content-Type: text/plain X-Originating-IP: [2a00:23c7:5a85:6801:5c7:2db6:d2c2:ae4e] X-ClientProxiedBy: AM4PR0101CA0053.eurprd01.prod.exchangelabs.com (2603:10a6:200:41::21) To DM6PR12MB2762.namprd12.prod.outlook.com (2603:10b6:5:45::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost.localdomain (2a00:23c7:5a85:6801:5c7:2db6:d2c2:ae4e) by AM4PR0101CA0053.eurprd01.prod.exchangelabs.com (2603:10a6:200:41::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3632.17 via Frontend Transport; Mon, 7 Dec 2020 19:01:33 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 26a651b5-dd1c-4775-9cf8-08d89ae28440 X-MS-TrafficTypeDiagnostic: DM6PR12MB4561: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: j0m7/FKTRaJkgkj8nO6i1ZjqGl2ws2vXjPDVR0PtYAHig4A7ah3eXv6C25Frg8iF/sxAiyAS/Ul/zc5gu6OmD+1AAKp9xLe/xuHc0bwGQh86uoyYiaqwROUqEeysiEnBqBoMfkofQhd0lHdioxwGXT6eUR5CHOplC/pWbkEQCk+BNloLVXV+sN0S1qQ/726Ja4C+KmxzoKvzg4LKjM6Rn+fuc6DzCiW5fWjQs66hg3Dg7FaKh6hgO5ZMMbGXrkKrUYEW6A0WRWUEU0k9GdG5VtqdZKx1BJ6QJ2qm32mYS2kZTE2Tm71tygyRfIoGVXzvR6IOA0Tsfe1JGI0NJ9/ec3ICYy6+yweFbJqlO9rO3z0taGDZSwhAj3k+u6IMOrkQ X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2762.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(346002)(39860400002)(366004)(136003)(396003)(1076003)(83380400001)(86362001)(6506007)(4326008)(69590400008)(52116002)(36756003)(2906002)(6512007)(8676002)(6486002)(16526019)(2616005)(66946007)(66476007)(66556008)(6916009)(5660300002)(186003)(8936002)(478600001)(6666004)(316002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?4p0wT8XH9gLAIZUR12lnfcvcgBbuBJiQjbqaz8EY4Iif46XCTsX23VBzF906?= =?us-ascii?Q?0ovaWvqv9t0qi7LMQmDtyQhzs7PmVW6SLzNqAudeFhxCExWn6NN4kZo5I4bI?= =?us-ascii?Q?7pgELBb8PieWK5H0yjR5J04SQZCcneeTwHZSiZRL9C5nZFG9qNcBlP4HubM0?= =?us-ascii?Q?zZIpgbmmBKMPImpdadCGn9YvyeGRvIK6hj3RASQK/IxwTxgPzRaG76ZyAh0w?= =?us-ascii?Q?1g8biDYzJ29EN/iza+xtFVcbUCUOwd4/hL6mkS5NYVNDsOqefLF3NxPqAUDE?= =?us-ascii?Q?XtwIFGocy+F+M/ub+mcC4tlYpbO3Fu7F5zyblv0Mbsf7eVxEsbN7iy96MNsa?= =?us-ascii?Q?BxI9/+FHWL9QxrvRT22T+TtJ0ipYpw8dIkr1sgtBSU6G77seKc+YAcLPL17w?= =?us-ascii?Q?+52OvLmAMGLP5XCrJlz9YgrvTk+NY28sSuYzvLsp43DyYRQFDgCMldX+o/Ku?= =?us-ascii?Q?G3VLxffjZkGv1h+kPDiHh2+WXpGdKvfb3UOVBg1rJh2Oy5oSF76JCfn7+s3I?= =?us-ascii?Q?rwKZ83EMx+c8coETsTVWy9McTEP/Tsug0zRVbI3AHSCR1HKoql9AmhqZj47P?= =?us-ascii?Q?aca071sAGW/n/ktjHWSulHV+2++2n5mgq5+LCL6IPaPzfouBWs+TIhyjerqJ?= =?us-ascii?Q?fmoMnv6uugMpNHr+JP0Tlja+zrf2nhu8zl2b33L4UtULIeDIbIGBJw2o3iRa?= =?us-ascii?Q?cVK7ikwwZGCdwxiLNSYYkohRSQCYD9kTPUkJDZYMFuZoMuReKE65/Ss8f889?= =?us-ascii?Q?ggop6Ne5f0c8/KZKnCTS0ZK7pAVp2jgK+Y9Ap9LSYiFp4j/XM+kOjXQIJgxB?= =?us-ascii?Q?ZvSDy5TWnrDPki2wgZG5cDH98H/PsW0/WAgzTfPACJnH12LDGd/lzneRaLv9?= =?us-ascii?Q?YbUt2jbD/RGxrirJS5xvQnKBT3dE+FPMZ86rgDoj9zFcxgOGChsD/J1VmmIj?= =?us-ascii?Q?q8mD8TyUIAyl5vU79tJ9WDysxPDqCA/8W/eMiq8aFZqj/1U7L5FSLkrs+RHO?= =?us-ascii?Q?RolVojWculnAqW3R0KPYO6bHGs22cJYPEvOfNz5ovl5qUguChB4uw1ztIoWr?= =?us-ascii?Q?hWL+iis3?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2762.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2020 19:01:34.0351 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-Network-Message-Id: 26a651b5-dd1c-4775-9cf8-08d89ae28440 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wdWytmXYVdq5+ZG8uV/H5qGyOUJcpCgb9KziHITT4M3YCG8KJk3W7ik7uQxtZ+Ummqpa0IRvbfgnq1IHc6r0Lg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4561 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Zoran Zaric via Gdb-patches Reply-To: Zoran Zaric Cc: Zoran Zaric Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" The dwarf_expr_require_composition function reports an error if the last operation is not a leaf node of the DWARF expression. This was previously used to prevent location description operations to be used freely in the DWARF expression. With the new approach, everything all operations are treated the same and everything is composable, so there is no need for the previous restriction in the expression evaluator. gdb/ChangeLog: * dwarf2/expr.c (dwarf_expr_context::execute_stack_op): Remove the use of dwarf_expr_require_composition. --- gdb/dwarf2/expr.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/gdb/dwarf2/expr.c b/gdb/dwarf2/expr.c index ee3732a6d9..1f07502059 100644 --- a/gdb/dwarf2/expr.c +++ b/gdb/dwarf2/expr.c @@ -2971,7 +2971,6 @@ dwarf_expr_context::execute_stack_op (const gdb_byte *op_ptr, case DW_OP_reg29: case DW_OP_reg30: case DW_OP_reg31: - dwarf_expr_require_composition (op_ptr, op_end, "DW_OP_reg"); ensure_have_frame (this->frame, "DW_OP_reg"); result = op - DW_OP_reg0; @@ -2980,7 +2979,6 @@ dwarf_expr_context::execute_stack_op (const gdb_byte *op_ptr, case DW_OP_regx: op_ptr = safe_read_uleb128 (op_ptr, op_end, ®); - dwarf_expr_require_composition (op_ptr, op_end, "DW_OP_regx"); ensure_have_frame (this->frame, "DW_OP_regx"); result = reg; @@ -2997,8 +2995,6 @@ dwarf_expr_context::execute_stack_op (const gdb_byte *op_ptr, result_entry = entry_factory->create_implicit (op_ptr, len, BFD_ENDIAN_UNKNOWN); op_ptr += len; - dwarf_expr_require_composition (op_ptr, op_end, - "DW_OP_implicit_value"); } break; @@ -3014,8 +3010,6 @@ dwarf_expr_context::execute_stack_op (const gdb_byte *op_ptr, = entry_factory->create_implicit (value->get_contents (), TYPE_LENGTH (type), type_byte_order (type)); - - dwarf_expr_require_composition (op_ptr, op_end, "DW_OP_stack_value"); } break; @@ -3039,9 +3033,6 @@ dwarf_expr_context::execute_stack_op (const gdb_byte *op_ptr, this->per_cu, this->addr_size, die_offset, len); - - dwarf_expr_require_composition (op_ptr, op_end, - "DW_OP_implicit_pointer"); } break; -- 2.17.1