From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id MJdFOft7zl9ETQAAWB0awg (envelope-from ) for ; Mon, 07 Dec 2020 14:01:15 -0500 Received: by simark.ca (Postfix, from userid 112) id 592D41F096; Mon, 7 Dec 2020 14:01:14 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,RDNS_NONE, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 98E2A1EFBB for ; Mon, 7 Dec 2020 14:01:12 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0D9163951887; Mon, 7 Dec 2020 19:01:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0D9163951887 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1607367672; bh=hG0tkcIyEvNGvLRJ9cFU7DbYj7T90Any+zAckn7Lk5c=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=SBWDoxtOh2lJoqsGXmsWxnrgm2bRZC9s8fCSP7KiPxG7Nf6k+XSJEn6Xs1goaQlhc 9o81k/XDMHu9pIskNfI6IfgFFQKPJm0+fNkguFOAkszQL0WCVJO7Xi2rBCtUl1X4ld CxDX1OH8LTdLslWagE7LdtqZVFx7bolUPFZYQAig= Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2049.outbound.protection.outlook.com [40.107.244.49]) by sourceware.org (Postfix) with ESMTPS id 0A3E13951809 for ; Mon, 7 Dec 2020 19:01:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0A3E13951809 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IQwN2qi1GqpCjvg2Drj5A+dnfNhInr2ugl4+B9cflE4XfQebnMyoFrxpwd2/j6ajavdDLRjhty/+Krlz+dZ7bOYGIiwHU9PbvCeva3IXTztpEvhLnRQWMcm7Ec5GA4UdLBba3a/bbyH3gmShRLXiQy332bL3h5vcb3vs8CwGydYp1L0KTOOY7RgZ/GTw8ZvMCF684LtnP4/qgMbDuQaF5v7JYRvVsFY9xsLkPtJI/Eb/wWtlfd/YZ7iu14KsB+zvDTcVndKfTzZ0LaGmwnz7EF5g4HJeGlJ1qGiiQ1qWnWL8GilntX/w9YBYFQbqePNIpyV53XcNQRiBR3Ww1B08tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hG0tkcIyEvNGvLRJ9cFU7DbYj7T90Any+zAckn7Lk5c=; b=dLSGKH0PPRGWF8vKjUnMzeCuh9qCy3+vjkhVBnJCjFL22EzLErxsxjERTPg6xc4SUOIv8VVZ9OXu0pc6ZF6OGx74yWXxN6HOL+cpCTX/5Sdv4gEqqEZJ13lW03mXmVIRANLl/ASM+rVr12VMg+AIm8tnbZsQ5jzCdYdqMmSd+3ivUJPQ6XRwrIyJuUYtHOi9ezLTtjHGjwS6S743QsvXT9IjWWTkIiAE5KHtiTVHTfIu6+C3n8tgBcNePFdQg7kkq6l+xCx48VjnQq2421bd9xCRwUDVjF42Nilv2WRYpDSdxXGRN5gUcvrLacx3F1Tk1QviihT3gH8jVW+qN4ALBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from DM6PR12MB2762.namprd12.prod.outlook.com (2603:10b6:5:45::15) by DM6PR12MB4561.namprd12.prod.outlook.com (2603:10b6:5:2ac::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3632.18; Mon, 7 Dec 2020 19:01:02 +0000 Received: from DM6PR12MB2762.namprd12.prod.outlook.com ([fe80::6841:61df:984b:b3c]) by DM6PR12MB2762.namprd12.prod.outlook.com ([fe80::6841:61df:984b:b3c%3]) with mapi id 15.20.3632.021; Mon, 7 Dec 2020 19:01:02 +0000 To: gdb-patches@sourceware.org Subject: [PATCH 09/30] Inline get_reg_value method of dwarf_expr_context Date: Mon, 7 Dec 2020 19:00:10 +0000 Message-Id: <20201207190031.13341-10-Zoran.Zaric@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201207190031.13341-1-Zoran.Zaric@amd.com> References: <20201207190031.13341-1-Zoran.Zaric@amd.com> Content-Type: text/plain X-Originating-IP: [2a00:23c7:5a85:6801:5c7:2db6:d2c2:ae4e] X-ClientProxiedBy: AM4PR0101CA0053.eurprd01.prod.exchangelabs.com (2603:10a6:200:41::21) To DM6PR12MB2762.namprd12.prod.outlook.com (2603:10b6:5:45::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost.localdomain (2a00:23c7:5a85:6801:5c7:2db6:d2c2:ae4e) by AM4PR0101CA0053.eurprd01.prod.exchangelabs.com (2603:10a6:200:41::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3632.17 via Frontend Transport; Mon, 7 Dec 2020 19:01:01 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 27303d2c-c26e-4a3a-c497-08d89ae27150 X-MS-TrafficTypeDiagnostic: DM6PR12MB4561: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qI0Wpq61piEohhYPvUL3M3kAEvx225YaeP4TKrvKZQ23PL0UsH5/sCeA+eyVksY+hG1Xu1KXz8hng3hErOWBFVcpA46hlu/SUBXvQ07YRkNWlUESQC9RsQw17hCbE9hjLxzrB4Fi5MC0/V9mfJIX2x+p0lxH0RbrlrLxK0PA3QipTPBPuTtqY3zB297qTqLzwKeCl+67VzEiv28BVMzz33aqkRZeKKcKCL+L4IqOMH399A7A3BdX78UArJ6eg1YKSB+c+B2gjcXyAaJ8y6ONRaQWuWIArbyI6RzQf0fTTNB6k7hvCbP6KLZDGufiMjAaVTfsMBPM8zkObWOqJ4Z76a8GHFrFPq2AqxQ2Ra7hY+WhhImFwnRIlUxSjWqK39c2 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2762.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(346002)(39860400002)(366004)(136003)(396003)(1076003)(83380400001)(86362001)(6506007)(4326008)(69590400008)(52116002)(36756003)(2906002)(6512007)(8676002)(6486002)(16526019)(2616005)(66946007)(66476007)(66556008)(6916009)(5660300002)(186003)(8936002)(478600001)(6666004)(316002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?xconNnVYjJWJ63CR8YS2GMd5HQyNMlfJ+BOTRxtuXXbsKnZVQv00rwcQfgSW?= =?us-ascii?Q?Gp6ctlx5+qoYS+aGFYNlhMFo3qPKwOdi4aMZwvABIj15v0aKTAI0d//umvOb?= =?us-ascii?Q?Z25YFs4672sgTg0v5Eh+CWbofRpx867qJ1bvDLsdGFAEb3tfKQ2TTOwSoyw9?= =?us-ascii?Q?B5x4XqkYxcMqbtkgnw2ZxvU/s5NN95mbNcAAxmrPA2ibSB5+FVuIUBMLcLfJ?= =?us-ascii?Q?fPdXrNfB9kfF3ahQosc04x+gGSezK5qrU6TCELTYFmtX1scPw4PnKTWNv82H?= =?us-ascii?Q?WyKDgrmb8qF/bazHESXwIREJgqbY0xLPUoabFYd43D27pMM+9lpKZ41qMt/0?= =?us-ascii?Q?AvoQ2HM+H0oJoRkTuJDLHAYwi2pns5AgI3oqJRneDKejQRMK7tgC2C4zwsmi?= =?us-ascii?Q?y/VSv+VUOTVL8pqlD9jm2PBnMXrVI7IyY7dvdVTea4huqHsEvkpv8/pmqGH1?= =?us-ascii?Q?8bYU6YavR18+VUn3VxsbAgyUDgRiPBQ9D9sNZjeJ7XjD7TH1VROciHuOX5Bc?= =?us-ascii?Q?nS8Stzdpv13Teebb4au7Kyl94DE+SXLsnLztXGrimYp9i6mt4wqmcPe8O2ox?= =?us-ascii?Q?EDFeIVK3EPO27u5NCn7W5PZqKbJ4phZT0ZOm4zoX5TAYnp9K92B+sEnRSjwn?= =?us-ascii?Q?OVD7PkXeLBPcmmO0OXQO30c1dQOg5WfigirZ0orsO2Rwv9ivr5UaqmlEtdW/?= =?us-ascii?Q?2SdpRtRa0e/AgjRqtc3HAq2JSptFMf7WwdTwd4xmY9iPS06apr4D9eHvTwKS?= =?us-ascii?Q?+iFsNErmR7UVJhJkHDheP2amfJSQKABb+TfRmaZr3zVqEdD4/tW4YwEVVrYT?= =?us-ascii?Q?9zdejxRKMLkgCWND3SO4+3CmuDoYXFuMP5YQJiSIGlwTM5CI6pZT4FRXPaJ3?= =?us-ascii?Q?5o5jzdj1Tl4dBnGl6f2yTOrNbXxV1kSuJXrC38Q5ZKh3RO2wCCBnEF9vL15c?= =?us-ascii?Q?Pf8m6mE6Nq70Yuh9EJhiwwjKeMygvTvv/PRT6zrum4z1Yt8VAvfNgViNF34x?= =?us-ascii?Q?/yM/DE0iW72CxN2i0mp7tvP2K+z582Zd3Jp1+a1FNmEZsfHY1LQmGr6nHIOB?= =?us-ascii?Q?xeL7H8tn?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2762.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2020 19:01:02.6520 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-Network-Message-Id: 27303d2c-c26e-4a3a-c497-08d89ae27150 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cRhztRdT/ic0uE7nOhXqyFjqHY/v72PvgqYU5SCvJuS8tgkzHIBWYMiEOKA1RzErQEBYdzkBB6ZTW8ICZb+rxw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4561 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Zoran Zaric via Gdb-patches Reply-To: Zoran Zaric Cc: Zoran Zaric Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" The get_reg_value method is a small function that is only called once, so it can be inlined to simplify the dwarf_expr_context class. gdb/ChangeLog: * dwarf2/expr.c (dwarf_expr_context::get_reg_value): Remove method. (dwarf_expr_context::execute_stack_op): Inline get_reg_value method. * dwarf2/expr.h (dwarf_expr_context::get_reg_value): Remove method. --- gdb/dwarf2/expr.c | 24 +++++++----------------- gdb/dwarf2/expr.h | 6 ------ 2 files changed, 7 insertions(+), 23 deletions(-) diff --git a/gdb/dwarf2/expr.c b/gdb/dwarf2/expr.c index 33237e1f27..a7bc084755 100644 --- a/gdb/dwarf2/expr.c +++ b/gdb/dwarf2/expr.c @@ -180,19 +180,6 @@ dwarf_expr_context::fetch (int n) /* See expr.h. */ -struct value * -dwarf_expr_context::get_reg_value (struct type *type, int reg) -{ - ensure_have_frame (frame, "DW_OP_regval_type"); - - struct gdbarch *gdbarch = get_frame_arch (frame); - int regnum = dwarf_reg_to_regnum_or_error (gdbarch, reg); - - return value_from_register (type, regnum, frame); -} - -/* See expr.h. */ - void dwarf_expr_context::get_frame_base (const gdb_byte **start, size_t * length) @@ -1543,14 +1530,17 @@ dwarf_expr_context::execute_stack_op (const gdb_byte *op_ptr, case DW_OP_regval_type: case DW_OP_GNU_regval_type: { - struct type *type; - op_ptr = safe_read_uleb128 (op_ptr, op_end, ®); op_ptr = safe_read_uleb128 (op_ptr, op_end, &uoffset); cu_offset type_die_cu_off = (cu_offset) uoffset; - type = get_base_type (type_die_cu_off, 0); - result_val = this->get_reg_value (type, reg); + ensure_have_frame (this->frame, "DW_OP_regval_type"); + + struct type *type = get_base_type (type_die_cu_off, 0); + int regnum + = dwarf_reg_to_regnum_or_error (get_frame_arch (this->frame), + reg); + result_val = value_from_register (type, regnum, this->frame); } break; diff --git a/gdb/dwarf2/expr.h b/gdb/dwarf2/expr.h index 71c10ebe3b..a04a67c0f8 100644 --- a/gdb/dwarf2/expr.h +++ b/gdb/dwarf2/expr.h @@ -215,12 +215,6 @@ struct dwarf_expr_context void execute_stack_op (const gdb_byte *op_ptr, const gdb_byte *op_end); void pop (); - /* Return a value of type TYPE, stored in register number REGNUM - of the frame associated to the given BATON. - - REGNUM is a DWARF register number. */ - struct value *get_reg_value (struct type *type, int regnum); - /* Return the location expression for the frame base attribute, in START and LENGTH. The result must be live until the current expression evaluation is complete. */ -- 2.17.1