From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 0HeIAtEtyl9MMQAAWB0awg (envelope-from ) for ; Fri, 04 Dec 2020 07:38:41 -0500 Received: by simark.ca (Postfix, from userid 112) id EED7D1F0AB; Fri, 4 Dec 2020 07:38:40 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.3 required=5.0 tests=MAILING_LIST_MULTI,RDNS_NONE, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 95C0C1E552 for ; Fri, 4 Dec 2020 07:38:39 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5492D3973024; Fri, 4 Dec 2020 12:38:39 +0000 (GMT) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id BF4C23846416 for ; Fri, 4 Dec 2020 12:38:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org BF4C23846416 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tdevries@suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id D3487ACC2 for ; Fri, 4 Dec 2020 12:38:35 +0000 (UTC) Date: Fri, 4 Dec 2020 13:38:34 +0100 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [committed][gdb/testsuite] Make gdb.arch/amd64-gs_base.exp unsupported for i386 Message-ID: <20201204123832.GA4805@delia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Hi, With target board unix/-m32 I run into: ... (gdb) print /x $fs_base^M $1 = void^M (gdb) FAIL: gdb.arch/amd64-gs_base.exp: print fs_base ... The problem is that the fs_base register is not supported for i386. Fix this by making the test unsupported if fs_base/gs_base don't show up in info register sys output. Tested on x86_64-linux. Committed to trunk. Thanks, - Tom [gdb/testsuite] Make gdb.arch/amd64-gs_base.exp unsupported for i386 gdb/testsuite/ChangeLog: 2020-12-03 Tom de Vries PR testsuite/26990 * gdb.arch/amd64-gs_base.exp: Handle -m32 where fs_base and gs_base are unsupported. --- gdb/testsuite/gdb.arch/amd64-gs_base.exp | 26 +++++++++++++++++++++++++- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/gdb/testsuite/gdb.arch/amd64-gs_base.exp b/gdb/testsuite/gdb.arch/amd64-gs_base.exp index 3e14031d2d..d29043bb79 100644 --- a/gdb/testsuite/gdb.arch/amd64-gs_base.exp +++ b/gdb/testsuite/gdb.arch/amd64-gs_base.exp @@ -30,6 +30,31 @@ if ![runto_main] { return -1 } +# Test the presence of fs_base and gs_base on the system +# register group and values. +# +set ws "\[\t \]+" +set info_reg_out [multi_line "info register sys" \ + "fs_base${ws}$hex${ws}$decimal"\ + "gs_base${ws}$hex${ws}$decimal"\ + "orig_rax${ws}$hex${ws}\[-\]$decimal" ] +set info_reg_out_m32 [multi_line "info register sys" \ + "orig_eax${ws}$hex${ws}\[-\]$decimal" ] + +set supported 0 +gdb_test_multiple "info register sys" "" { + -re -wrap $info_reg_out { + set supported 1 + } + -re -wrap $info_reg_out_m32 { + } +} + +if { ! $supported } { + unsupported "target does not support fs_base and gs_base" + return -1 +} + gdb_test "print /x \$fs_base" "= $hex" "print fs_base" gdb_test "print /x \$gs_base" "= $hex" "print gs_base" @@ -39,7 +64,6 @@ gdb_test "print \$gs_base = 3" "= 3" "set gs_base" # Test the presence of fs_base and gs_base on the system # register group and values. # -set ws "\[\t \]+" set info_reg_out [multi_line "info register sys" \ "fs_base${ws}0x2${ws}2"\ "gs_base${ws}0x3${ws}3"\