From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id oK51MWsjxV+3LAAAWB0awg (envelope-from ) for ; Mon, 30 Nov 2020 11:52:59 -0500 Received: by simark.ca (Postfix, from userid 112) id C62241F0AB; Mon, 30 Nov 2020 11:52:59 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C90101F0AA for ; Mon, 30 Nov 2020 11:52:58 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B94F33898031; Mon, 30 Nov 2020 16:52:57 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B94F33898031 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1606755177; bh=DUx+rj4t2TwAHcrxpKlZEWIbYoCyHnvK0OUDj5YreUo=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=svqnlaZdaccv5vKOiXAOKWKlkH0TqPta/AWNBhpZ/gaueXWbQvQSNv+SPD9TMVGN5 hPY6xNdoaafu+CALTA01kOI2Ql2BtZCDC/GBo89Ta1w2AGCE+WJeFQy+38HxyQ39og 2C4LnSGeA+UTyI5hjRzATv4lh5YSAstZbYD54LIk= Received: from barracuda.ebox.ca (barracuda.ebox.ca [96.127.255.19]) by sourceware.org (Postfix) with ESMTPS id 29D54388A404 for ; Mon, 30 Nov 2020 16:52:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 29D54388A404 X-ASG-Debug-ID: 1606755173-0c856e6cd5295ea0001-fS2M51 Received: from smtp.ebox.ca (smtp.ebox.ca [96.127.255.82]) by barracuda.ebox.ca with ESMTP id i64quZ4qY0FQx6f8 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 30 Nov 2020 11:52:53 -0500 (EST) X-Barracuda-Envelope-From: simon.marchi@efficios.com X-Barracuda-RBL-Trusted-Forwarder: 96.127.255.82 Received: from epycamd.internal.efficios.com (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) by smtp.ebox.ca (Postfix) with ESMTP id 6461F441B21; Mon, 30 Nov 2020 11:52:53 -0500 (EST) X-Barracuda-RBL-IP: 192.222.181.218 X-Barracuda-Effective-Source-IP: 192-222-181-218.qc.cable.ebox.net[192.222.181.218] X-Barracuda-Apparent-Source-IP: 192.222.181.218 To: gdb-patches@sourceware.org Subject: [PATCH 4/4] gdb: make record-full target clear its async event handler in wait Date: Mon, 30 Nov 2020 11:52:51 -0500 X-ASG-Orig-Subj: [PATCH 4/4] gdb: make record-full target clear its async event handler in wait Message-Id: <20201130165251.830482-5-simon.marchi@efficios.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201130165251.830482-1-simon.marchi@efficios.com> References: <20201130165251.830482-1-simon.marchi@efficios.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Barracuda-Connect: smtp.ebox.ca[96.127.255.82] X-Barracuda-Start-Time: 1606755173 X-Barracuda-Encrypted: DHE-RSA-AES256-SHA X-Barracuda-URL: https://96.127.255.19:443/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at ebox.ca X-Barracuda-Scan-Msg-Size: 1516 X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.50 X-Barracuda-Spam-Status: No, SCORE=0.50 using global scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=8.0 tests=BSF_RULE7568M X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.86230 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.50 BSF_RULE7568M Custom Rule 7568M X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Cc: Simon Marchi Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" For the same reason explained in the previous patch (which was for the record-btrace target), move clearing of the async event handler of the record-full target to the wait method. I'm not sure if/where that target needs to re-set its async event handler in the wait method. Since it only supports a single thread, there probably can't be multiple events to report at the same time. gdb/ChangeLog: * record-full.c (record_full_async_inferior_event_handler): Don't clear async event handler. (record_full_base_target::wait): Clear async event handler at beginning. Change-Id: I146fbdb53d99e3a32766ac7cd337ac5ed7fd9adf --- gdb/record-full.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gdb/record-full.c b/gdb/record-full.c index 410028aed60..a7bd0bdcd62 100644 --- a/gdb/record-full.c +++ b/gdb/record-full.c @@ -904,7 +904,6 @@ static struct async_event_handler *record_full_async_inferior_event_token; static void record_full_async_inferior_event_handler (gdb_client_data data) { - clear_async_event_handler (record_full_async_inferior_event_token); inferior_event_handler (INF_REG_EVENT); } @@ -1464,6 +1463,8 @@ record_full_base_target::wait (ptid_t ptid, struct target_waitstatus *status, { ptid_t return_ptid; + clear_async_event_handler (record_full_async_inferior_event_token); + return_ptid = record_full_wait_1 (this, ptid, status, options); if (status->kind != TARGET_WAITKIND_IGNORE) { -- 2.29.2