From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id jBfmH+rfvl/9GgAAWB0awg (envelope-from ) for ; Wed, 25 Nov 2020 17:51:22 -0500 Received: by simark.ca (Postfix, from userid 112) id 760021F0AB; Wed, 25 Nov 2020 17:51:22 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CB3641E776 for ; Wed, 25 Nov 2020 17:51:21 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1280E3857C4F; Wed, 25 Nov 2020 22:51:21 +0000 (GMT) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id 40F313857C4F for ; Wed, 25 Nov 2020 22:51:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 40F313857C4F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tdevries@suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 5A25DABDE for ; Wed, 25 Nov 2020 22:51:17 +0000 (UTC) Date: Wed, 25 Nov 2020 23:51:15 +0100 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH][gdb/testsuite] Fix count usage in gdb.reverse/insn-reverse.exp Message-ID: <20201125225114.GA16467@delia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Hi, Consider the test-case gdb.reverse/insn-reverse.exp. After the loop setting count, the valid entries in various arrays range from 0 to $count - 1 inclusive. Then $count is decremented: ... incr count -1 ... after which the valid entries range from 0 to $count inclusive. The first subsequent loop handles that properly: ... for {set i $count} {$i >= 0} {incr i -1} { ... but the following loop does not, because it treats $count as exclusive bound: ... for {set i 0} {$i < $count} {incr i} { ... Fix this by removing the incr, and using $count - 1 as starting value in the first loop. Any comments? Thanks, - Tom [gdb/testsuite] Fix count usage in gdb.reverse/insn-reverse.exp gdb/testsuite/ChangeLog: 2020-11-25 Tom de Vries * gdb.reverse/insn-reverse.exp: Fix count handling. --- gdb/testsuite/gdb.reverse/insn-reverse.exp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/gdb/testsuite/gdb.reverse/insn-reverse.exp b/gdb/testsuite/gdb.reverse/insn-reverse.exp index 5627f9d2605..39e276964f9 100644 --- a/gdb/testsuite/gdb.reverse/insn-reverse.exp +++ b/gdb/testsuite/gdb.reverse/insn-reverse.exp @@ -102,9 +102,8 @@ proc test { func testcase_nr } { gdb_test "si" "" "" } - incr count -1 # Registers contents after each backward single step. - for {set i $count} {$i >= 0} {incr i -1} { + for {set i [expr $count - 1]} {$i >= 0} {incr i -1} { gdb_test "reverse-stepi" "" "" set post_regs($i) [capture_command_output "info all-registers" ""] }