From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id gMw6I0J4vF+yWwAAWB0awg (envelope-from ) for ; Mon, 23 Nov 2020 22:04:34 -0500 Received: by simark.ca (Postfix, from userid 112) id 8B5361F0AB; Mon, 23 Nov 2020 22:04:34 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI autolearn=unavailable autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 44C8F1E58E for ; Mon, 23 Nov 2020 22:04:34 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 02D2E3892018; Tue, 24 Nov 2020 03:04:34 +0000 (GMT) Received: from rock.gnat.com (rock.gnat.com [IPv6:2620:20:4000:0:a9e:1ff:fe9b:1d1]) by sourceware.org (Postfix) with ESMTP id 329F43857021 for ; Tue, 24 Nov 2020 03:04:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 329F43857021 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=brobecker@adacore.com Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 115E5116561; Mon, 23 Nov 2020 22:04:31 -0500 (EST) X-Virus-Scanned: Debian amavisd-new at gnat.com Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id zTi3Ta7zk4e1; Mon, 23 Nov 2020 22:04:31 -0500 (EST) Received: from float.home (localhost.localdomain [127.0.0.1]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPS id AA2D01162CA; Mon, 23 Nov 2020 22:04:30 -0500 (EST) Received: by float.home (Postfix, from userid 1000) id D32BBA6B96; Tue, 24 Nov 2020 07:04:25 +0400 (+04) Date: Tue, 24 Nov 2020 07:04:25 +0400 From: Joel Brobecker To: Simon Marchi Subject: Re: [RFA] Add TYPE_CODE_FIXED_POINT handling in print_type_scalar Message-ID: <20201124030425.GB1370653@adacore.com> References: <20201118034727.GF617116@adacore.com> <1606050776-62740-1-git-send-email-brobecker@adacore.com> <35a95886-01ac-4c1b-7a47-f4e02d98215d@simark.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <35a95886-01ac-4c1b-7a47-f4e02d98215d@simark.ca> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" > > gdb/ChangeLog: > > > > * typeprint.c (print_type_scalar): Add handling of > > TYPE_CODE_FIXED_POINT. > > > > gdb/testsuite/ChangeLog: > > > > * gdb.dwarf2/dw2-fixed-point.exp: Fix the expected output of > > the "ptype pck__fp1_range_var" test for the module-2 and pascal > > languages. Remove the associated setup_xfail. > > > > The ptype output for range types in modula-2 and pascal is a little > > odd (the type info is repeated twice around the ".." operator), but > > I guess that's how they present range types in those languages. > > Yeah, it seems like it. Thanks for doing this, the change to handle > fixed point in the generic print_type_scalar function looks good to me. Thank you Simon. Patch pushed to master. -- Joel